Sivecano/dwl - Change MBIOTFB64GH3E53GQRKHD2DJ7ITNT3CYH237F6DRIS4DSFN5CT4AC

Make drag_icon a persistent scene node

If there is no current drag icon, this node will be empty, but we now have drag_icon != NULL as an invariant. This allows us to eliminate a conditional, since there's no harm in moving an empty node's coordinates around with the pointer.

ΔSLOC: -1

Created by Devin J. Pohly on July 13, 2023

MBIOTFB64GH3E53GQRKHD2DJ7ITNT3CYH237F6DRIS4DSFN5CT4AC

Dependencies

In channels

main

Change contents

Insertion in dwl.c at line 334 [5.4]
[3.161]
[4.120]
```
static struct wlr_scene_tree *drag_icon;
```
Deletion in dwl.c at line 1667 [5.4]
B:BD[6.22070] → [6.22070:22099]
```
	struct wlr_drag_icon *icon;
```

Replacement in dwl.c at line 1677 [5.4]

B:BD[6.22324] → [6.22324:22521]

	/* Update drag icon's position if any */
	if (seat->drag && (icon = seat->drag->icon))
		wlr_scene_node_set_position(icon->data, cursor->x + icon->surface->sx,
				cursor->y + icon->surface->sy);

[6.22324]

[6.22521]

	/* Update drag icon's position */
	wlr_scene_node_set_position(&drag_icon->node, cursor->x, cursor->y);

Insertion in dwl.c at line 2169 [5.4]

[2.1161]

[6.39934]

	drag_icon = wlr_scene_tree_create(&scene->tree);
	wlr_scene_node_place_below(&drag_icon->node, &layers[LyrBlock]->node);

Replacement in dwl.c at line 2342 [5.4]

B:BD[6.46183] → [4.912:1075]

	drag->icon->data = icon = wlr_scene_subsurface_tree_create(&scene->tree, drag->icon->surface);
	wlr_scene_node_place_below(&icon->node, &layers[LyrBlock]->node);

[6.46183]

[6.46279]

	drag->icon->data = icon = wlr_scene_subsurface_tree_create(drag_icon, drag->icon->surface);