Sivecano/dwl - Change ZSSVUMLBSC7P4VMBM5GPNOBJGCUGYQGSU5SXIIZWX54Y674EZWDAC

commit entire output config, or fail and rollback

The wlr-output-management protocol requires that either all of the changes from an apply request be applied successfully, in which case a "succeeded" event is sent, or all of the changes are reverted and a "failed" event is sent. As written, this could partially commit changes, then fail.

Test the changes first (even for an "apply" event), then commit or rollback as appropriate.

Created by Devin J. Pohly on January 18, 2021

ZSSVUMLBSC7P4VMBM5GPNOBJGCUGYQGSU5SXIIZWX54Y674EZWDAC

Dependencies

In channels

main

Change contents

Replacement in dwl.c at line 1548 [3.4]

B:BD[2.1546] → [2.1546:1683]

		if (test) {
			ok &= wlr_output_test(wlr_output);
			wlr_output_rollback(wlr_output);
		} else
			ok &= wlr_output_commit(wlr_output);

[2.1546]

[2.1683]

		if (!(ok = wlr_output_test(wlr_output)))
			break;
	}
	wl_list_for_each(config_head, &config->heads, link) {
		if (ok && !test)
			wlr_output_commit(config_head->state.output);
		else
			wlr_output_rollback(config_head->state.output);