ZJ/nidobyte - Change Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC

rocket: User sign up guard forwards over failures When no user can be found, the User implementation of FromRequest was failing, which is a mistake. This meant that no other routes were tried and thus assigning policies to routes failed. This changes fixes that by forwarding instead. To be frank, this is over forwarding, and can still be improved on.

Created by zj on October 7, 2021

Y52KSJEFIX7KIL3MWH65WKHKXIX34T3VUSBVH2SBJ4ZJHM767J4AC

Dependencies

In channels

main

Change contents

Replacement in templates/landing.html.tera at line 11 [3.1622]

B:BD[2.2713] → [2.2713:2814]

        <a class="btn btn-primary btn-lg ps-4 gap-3" href="/users/sign_up" role="button">Sign up</a>

[2.2713]

[2.2814]

        <a class="btn btn-primary btn-lg ps-4 gap-3" href="/users/new" role="button">Sign up</a>

Deletion in src/controllers/users.rs at line 13 [4.33]
B:BD[4.327] → [4.327:362]
```
use rocket::outcome::try_outcome;
```

Replacement in src/controllers/users.rs at line 20 [4.33]

B:BD[4.518] → [4.518:735]

    async fn from_request(request: &'r Request<'_>) -> request::Outcome<Self, Self::Error> {
        let db = try_outcome!(request.guard::<&State<Database>>().await);
        //            &State<Database>>().await);

[4.518]

[4.735]

    async fn from_request(request: &'r Request<'_>) -> request::Outcome<User, ()> {
        let db: &State<Database> = match request.guard().await {
            Outcome::Success(db) => db,
            _ => return Outcome::Failure((Status::Unauthorized, ())),
        };

Replacement in src/controllers/users.rs at line 29 [4.33]

B:BD[4.868] → [4.868:941]

            None => return Outcome::Failure((Status::Unauthorized, ())),

[4.868]

[4.941]

            None => return Outcome::Forward(()),

Replacement in src/controllers/users.rs at line 34 [4.33]

B:BD[4.1041] → [4.1041:1110]

            Err(_e) => Outcome::Failure((Status::Unauthorized, ())),

[4.1041]

[4.1110]

            Err(_e) => Outcome::Forward(()), // TODO this is a failure

Insertion in src/controllers/users.rs at line 39 [4.33]

[4.1129]

#[get("/users/new", rank = 1)]
fn new_already_user(_user: User) -> Redirect {
    Redirect::to("/")
}

Deletion in src/controllers/users.rs at line 47 [4.33]
∅:D[2.4280] → [4.1237:1340]
B:BD[4.1237] → [4.1237:1340]
```
}
#[get("/users/new", rank = 1)]
fn new_already_user(_user: User) -> Redirect {
    Redirect::to("/")
```