akkartik/driver.love - Change 5HBC66CSFQ257TO3DJYBUNKE5RKR47CUJNMYP6Y4F7T6W7LNRV4AC

hoist f4-handling out of editor substrate

I'm not sure why I thought it was necessary to put it in there.

The only difference in behavior from this commit: selecting text and hitting 'f4' used to delete the selected text before submitting. Now it no longer deletes. I've never relied on this.

'f4' needs no viewport book-keeping or A/B refreshing, so this should also be slightly less wasteful.

Created by Kartik K. Agaram on July 23, 2023

5HBC66CSFQ257TO3DJYBUNKE5RKR47CUJNMYP6Y4F7T6W7LNRV4AC

Dependencies

In channels

main

Change contents

Deletion in edit.lua at line 250 [7.413]

B:BD[7.10962] → [8.14:48]

B:BD[8.48] → [9.17:49]

∅:D[9.49] → [8.48:105]

B:BD[8.48] → [8.48:105]

B:BD[8.105] → [3.16:164]

∅:D[3.164] → [10.54:155]

B:BD[10.54] → [10.54:155]

B:BD[10.155] → [4.16:46]

∅:D[4.46] → [8.216:224]

∅:D[10.155] → [8.216:224]

B:BD[8.216] → [8.216:224]

B:BD[8.224] → [9.50:124]

B:BD[9.124] → [2.16:44]

∅:D[2.44] → [9.124:132]

B:BD[9.124] → [9.124:132]

∅:D[9.158] → [11.13:66]

B:BD[8.224] → [11.13:66]

  -- repl
  if chord == 'f4' then
    State.load_time_error = nil
    live.send_definition_to_app(State)
    while true do
      local response_string = live.receive_from_app()
      if response_string then
        Client_app_test_failures = json.decode(response_string)
        break
      end
      if live.receive_run_time_error_from_app() then
        break
      end
      love.timer.sleep(0.001)
    end
    if Load_time_error then
      State.load_time_error = Load_time_error
      Load_time_error = nil
    end
    if on.code_submit then on.code_submit(State) end

Replacement in edit.lua at line 251 [7.413]
B:BD[8.236] → [8.236:268]
```
  elseif State.search_term then
```
[8.236]
[5.17]
```
  if State.search_term then
```

File addition: 0112-submit_definition (----------)

[12.2]

submit_definition = function(State)
	State.load_time_error = nil
	live.send_definition_to_app(State)
	while true do
		local response_string = live.receive_from_app()
		if response_string then
			Client_app_test_failures = json.decode(response_string)
			break
		end
		if live.receive_run_time_error_from_app() then
			break
		end
		love.timer.sleep(0.001)
	end
	if Load_time_error then
		State.load_time_error = Load_time_error
		Load_time_error = nil
	end
	if on.code_submit then on.code_submit(State) end
end

Replacement in 0023-on.keychord_press at line 45 [13.26]

B:BD[13.328] → [13.328:429]

B:BD[13.429] → [6.945:1034]

∅:D[6.1034] → [13.429:644]

B:BD[13.429] → [13.429:644]

B:BD[13.644] → [6.1035:1285]

		local old_top = {line=Cursor_node.editor.screen_top1.line, pos=Cursor_node.editor.screen_top1.pos}
		local old_definition_name = live.get_cmd_from_buffer(Cursor_node.editor.lines[1].data)
		edit.keychord_press(Cursor_node.editor, chord, key)
		if not eq(Cursor_node.editor.screen_top1, old_top) then
			Viewport.y = Cursor_node.y + y_of_schema1(Cursor_node.editor, Cursor_node.editor.screen_top1)
		end
		local definition_name = live.get_cmd_from_buffer(Cursor_node.editor.lines[1].data)
		maybe_update_key_in_definitions(old_definition_name, definition_name, Cursor_node)
		if chord == 'return' then
			A(--[[preserve screen_top of cursor node]] true)

[13.328]

[6.1285]

		if chord == 'f4' then
			submit_definition(Cursor_node.editor)

Replacement in 0023-on.keychord_press at line 48 [13.26]

B:BD[6.1292] → [6.1292:1344]

			B(--[[preserve screen_top of cursor node]] true)

[6.1292]

[6.1344]

			local old_top = {line=Cursor_node.editor.screen_top1.line, pos=Cursor_node.editor.screen_top1.pos}
			local old_definition_name = live.get_cmd_from_buffer(Cursor_node.editor.lines[1].data)
			edit.keychord_press(Cursor_node.editor, chord, key)
			if not eq(Cursor_node.editor.screen_top1, old_top) then
				Viewport.y = Cursor_node.y + y_of_schema1(Cursor_node.editor, Cursor_node.editor.screen_top1)
			end
			local definition_name = live.get_cmd_from_buffer(Cursor_node.editor.lines[1].data)
			maybe_update_key_in_definitions(old_definition_name, definition_name, Cursor_node)
			if chord == 'return' then
				A(--[[preserve screen_top of cursor node]] true)
			else
				B(--[[preserve screen_top of cursor node]] true)
			end

Replacement in 0023-on.keychord_press at line 95 [13.26]
B:BD[13.1610] → [13.1610:1613]
```
end
```
[13.1610]
```
end
```