akkartik/luaML.love - Change HPP3MEH2VINRT7LAF7QIIDVA76GBO4CN3R5UIF2P4M3RH3DOBL5QC

delete some seemingly redundant code

We're patching line_cache and then immediately clearing it using Text.redraw_all.

Created by akkartik on July 8, 2024

HPP3MEH2VINRT7LAF7QIIDVA76GBO4CN3R5UIF2P4M3RH3DOBL5QC

Dependencies

In channels

main

Change contents

Deletion in undo.lua at line 84 [5.1]

B:BD[3.852] → [4.1:51]

B:BD[4.51] → [2.368:445]

∅:D[2.445] → [4.94:176]

B:BD[4.94] → [4.94:176]

B:BD[4.176] → [2.446:531]

∅:D[2.531] → [4.227:313]

B:BD[4.227] → [4.227:313]

function patch_placeholders(line_cache, from, to)
  assert(from.start_line == to.start_line, 'failed to patch undo operation')
  for i=from.end_line,from.start_line,-1 do
    table.remove(line_cache, i)
  end
  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')
  for i=1,#to.lines do
    table.insert(line_cache, to.start_line+i-1, {})
  end
end

Deletion in source_undo.lua at line 84 [6.5]

B:BD[6.2662] → [6.2662:2712]

B:BD[6.2712] → [2.2686:2763]

∅:D[2.2763] → [6.2755:2837]

B:BD[6.2755] → [6.2755:2837]

B:BD[6.2837] → [2.2764:2849]

∅:D[2.2849] → [6.2888:2974]

B:BD[6.2888] → [6.2888:2974]

function patch_placeholders(line_cache, from, to)
  assert(from.start_line == to.start_line, 'failed to patch undo operation')
  for i=from.end_line,from.start_line,-1 do
    table.remove(line_cache, i)
  end
  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')
  for i=1,#to.lines do
    table.insert(line_cache, to.start_line+i-1, {})
  end
end

Deletion in source_edit.lua at line 444 [6.152440]
B:BD[6.161104] → [6.161104:161174]
```
      patch_placeholders(State.line_cache, event.after, event.before)
```

Deletion in edit.lua at line 443 [9.413]

B:BD[7.8139] → [8.1967:2037]

      patch_placeholders(State.line_cache, event.after, event.before)