akkartik/sokoban.love - Change G3DLS5OUO77V4MC6754KTETRCTVUBYBHMGR7MTV52IYYM7QA3ROQC

audit all asserts

Each one should provide a message that will show up within LÖVE. Stop relying on nearby prints to the terminal.

I also found some unnecessary ones.

There is some potential here for performance regressions: the format() calls will trigger whether or not the assertion fails, and cause allocations. So far Lua's GC seems good enough to manage the load even with Moby Dick, even in some situations that caused issues in the past like undo.

Created by akkartik on November 18, 2023

G3DLS5OUO77V4MC6754KTETRCTVUBYBHMGR7MTV52IYYM7QA3ROQC

Dependencies

In channels

main

Change contents

Replacement in undo.lua at line 39 [12.1]
B:BD[10.122] → [11.1:13]
```
  assert(s)
```
[10.122]
[11.13]
```
  assert(s, 'failed to snapshot operation for undo history')
```

Replacement in undo.lua at line 43 [12.1]

B:BD[10.218] → [13.680:707]

  assert(#State.lines > 0)

[10.218]

[14.22]

  assert(#State.lines > 0, 'failed to snapshot operation for undo history')

Replacement in undo.lua at line 69 [12.1]

B:BD[12.2268] → [12.2268:2288]

      assert(false)

[12.2268]

[12.2288]

      assert(false, ('unknown line mode %s'):format(line.mode))

Replacement in undo.lua at line 83 [12.1]

B:BD[10.591] → [10.591:634]

  assert(from.start_line == to.start_line)

[10.591]

[10.634]

  assert(from.start_line == to.start_line, 'failed to patch undo operation')

Replacement in undo.lua at line 87 [12.1]

B:BD[10.711] → [10.711:762]

  assert(#to.lines == to.end_line-to.start_line+1)

[10.711]

[10.762]

  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')

Replacement in undo.lua at line 94 [12.1]

B:BD[15.51] → [15.51:94]

  assert(from.start_line == to.start_line)

[15.51]

[15.94]

  assert(from.start_line == to.start_line, 'failed to patch undo operation')

Replacement in undo.lua at line 98 [12.1]

B:BD[15.176] → [15.176:227]

  assert(#to.lines == to.end_line-to.start_line+1)

[15.176]

[15.227]

  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')

Replacement in text.lua at line 15 [17.1]

B:BD[16.63] → [4.162:214]

  assert(#line_cache.screen_line_starting_pos >= 1)

[16.63]

[4.214]

  assert(#line_cache.screen_line_starting_pos >= 1, 'line cache missing screen line info')

Replacement in text.lua at line 138 [17.1]

B:BD[18.79] → [19.3:60]

  assert(State.lines[State.cursor1.line].mode == 'text')

[18.79]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in text.lua at line 215 [17.1]

∅:D[20.122] → [21.2810:2865]

B:BD[21.2810] → [21.2810:2865]

    assert(Text.le1(State.screen_top1, State.cursor1))

[20.122]

[22.83]

    assert(Text.le1(State.screen_top1, State.cursor1), ('screen_top (line=%d,pos=%d) is below cursor (line=%d,pos=%d)'):format(State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos))

Replacement in text.lua at line 393 [17.1]

∅:D[23.816] → [18.3868:3925]

B:BD[18.3868] → [18.3868:3925]

  assert(State.lines[State.cursor1.line].mode == 'text')

[23.816]

[18.3925]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in text.lua at line 419 [17.1]

B:BD[24.1922] → [24.1922:1956]

    assert(screen_line_index > 1)

[24.1858]

[25.3]

    assert(screen_line_index > 1, 'bumped up against top screen line in line')

Replacement in text.lua at line 436 [17.1]

∅:D[23.1280] → [18.5916:5973]

B:BD[18.5916] → [18.5916:5973]

  assert(State.lines[State.cursor1.line].mode == 'text')

[23.1280]

[18.5973]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in text.lua at line 438 [17.1]
B:BD[18.6132] → [5.3:31]
```
  assert(State.cursor1.pos)
```
[18.6132]
[23.1281]
```
  assert(State.cursor1.pos, 'cursor has no pos')
```

Replacement in text.lua at line 512 [17.1]

B:BD[26.1135] → [18.8116:8150]

    assert(State.cursor1.pos > 1)

[26.1135]

[18.8150]

    assert(State.cursor1.pos > 1, 'bumped up against start of line')

Deletion in text.lua at line 546 [17.1]
B:BD[27.1013] → [27.1013:1036]
```
  assert(start_offset)
```

Replacement in text.lua at line 547 [17.1]

B:BD[27.1079] → [27.1079:1115]

  assert(end_offset > start_offset)

[27.1079]

[27.1115]

  assert(end_offset > start_offset, ('end_offset %d not > start_offset %d'):format(end_offset, start_offset))

Replacement in text.lua at line 553 [17.1]

∅:D[23.2106] → [28.188:245]

B:BD[28.188] → [28.188:245]

  assert(State.lines[State.cursor1.line].mode == 'text')

[23.2106]

[28.245]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in text.lua at line 586 [17.1]

B:BD[28.823] → [28.823:880]

  assert(State.lines[State.cursor1.line].mode == 'text')

[28.823]

[28.880]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in text.lua at line 611 [17.1]
B:BD[17.464] → [29.1642:1658]
```
  assert(false)
```
[17.464]
[30.1]
```
  assert(false, ('invalid pos %d'):format(loc1.pos))
```
Replacement in text.lua at line 625 [17.1]
B:BD[7.1764] → [7.1764:1780]
```
  assert(false)
```
[7.1764]
[7.1780]
```
  assert(false, ('invalid pos %d'):format(loc1.pos))
```

Replacement in text.lua at line 650 [17.1]

B:BD[31.2634] → [31.2634:2683]

    assert(State.cursor1.line == #State.lines+1)

[31.2634]

[31.2683]

    assert(State.cursor1.line == #State.lines+1, 'tried to ensure bottom line of file is text, but failed')

Replacement in text.lua at line 682 [17.1]

B:BD[32.776] → [33.586:614]

B:BD[33.614] → [31.3409:3466]

      assert(top2.line > 1)
      assert(State.lines[top2.line-1].mode == 'drawing')

[32.776]

[33.665]

      assert(top2.line > 1, 'tried to snap cursor to buttom of screen but failed')
      assert(State.lines[top2.line-1].mode == 'drawing', "expected a drawing but it's not")

Replacement in text.lua at line 715 [17.1]

B:BD[34.86] → [15.5639:5673]

  assert(my >= line_cache.starty)

[35.1078]

[36.863]

  assert(my >= line_cache.starty, 'failed to map y pixel to line')

Replacement in text.lua at line 738 [17.1]
B:BD[36.1307] → [36.1307:1323]
```
  assert(false)
```
[36.1307]
[17.464]
```
  assert(false, 'failed to map y pixel to line')
```
Replacement in text.lua at line 804 [17.1]
B:BD[17.1164] → [37.149:165]
```
  assert(false)
```
[17.1164]
[17.1179]
```
  assert(false, 'failed to map x pixel to pos')
```
Replacement in text.lua at line 835 [17.1]
B:BD[38.7860] → [38.7860:7876]
```
  assert(false)
```
[38.7860]
[39.3657]
```
  assert(false, 'failed to map x pixel to pos')
```

Replacement in text.lua at line 866 [17.1]

B:BD[40.8167] → [40.8167:8195]

  assert(result.screen_pos)

[40.8167]

[40.8195]

  assert(result.screen_pos, 'failed to convert schema-1 coordinate to schema-2')

Replacement in text.lua at line 908 [17.1]

B:BD[41.1124] → [41.1124:1141]

  assert(result)

[41.1124]

[41.1141]

  assert(result, "Text.offset returned nil; this is likely a failure to handle utf8")

Replacement in source_undo.lua at line 39 [42.5]
B:BD[42.1384] → [42.1384:1396]
```
  assert(s)
```
[42.1384]
[42.1396]
```
  assert(s, 'failed to snapshot operation for undo history')
```

Replacement in source_undo.lua at line 43 [42.5]

B:BD[42.1431] → [42.1431:1458]

  assert(#State.lines > 0)

[42.1431]

[42.1458]

  assert(#State.lines > 0, 'failed to snapshot operation for undo history')

Replacement in source_undo.lua at line 68 [42.5]

B:BD[43.2209] → [43.2209:2252]

      print(line.mode)
      assert(false)

[43.2209]

[43.2252]

      assert(false, ('unknown line mode %s'):format(line.mode))

Replacement in source_undo.lua at line 82 [42.5]

B:BD[42.2401] → [42.2401:2444]

  assert(from.start_line == to.start_line)

[42.2401]

[42.2444]

  assert(from.start_line == to.start_line, 'failed to patch undo operation')

Replacement in source_undo.lua at line 86 [42.5]

B:BD[42.2521] → [42.2521:2572]

  assert(#to.lines == to.end_line-to.start_line+1)

[42.2521]

[42.2572]

  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')

Replacement in source_undo.lua at line 93 [42.5]

B:BD[42.2712] → [42.2712:2755]

  assert(from.start_line == to.start_line)

[42.2712]

[42.2755]

  assert(from.start_line == to.start_line, 'failed to patch undo operation')

Replacement in source_undo.lua at line 97 [42.5]

B:BD[42.2837] → [42.2837:2888]

  assert(#to.lines == to.end_line-to.start_line+1)

[42.2837]

[42.2888]

  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')

Replacement in source_text.lua at line 20 [42.83723]

B:BD[42.87430] → [44.255:307]

  assert(#line_cache.screen_line_starting_pos >= 1)

[42.87430]

[44.307]

  assert(#line_cache.screen_line_starting_pos >= 1, 'line cache missing screen line info')

Replacement in source_text.lua at line 212 [42.83723]

B:BD[42.97835] → [45.7:64]

  assert(State.lines[State.cursor1.line].mode == 'text')

[42.97835]

[46.523]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in source_text.lua at line 289 [42.83723]

B:BD[42.102856] → [42.102856:102911]

    assert(Text.le1(State.screen_top1, State.cursor1))

[42.102856]

[42.102911]

    assert(Text.le1(State.screen_top1, State.cursor1), ('screen_top (line=%d,pos=%d) is below cursor (line=%d,pos=%d)'):format(State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos))

Replacement in source_text.lua at line 455 [42.83723]

B:BD[42.109127] → [43.6890:6947]

  assert(State.lines[State.cursor1.line].mode == 'text')

[42.109127]

[42.109238]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in source_text.lua at line 481 [42.83723]

B:BD[42.110541] → [42.110541:110575]

    assert(screen_line_index > 1)

[42.110541]

[42.110575]

    assert(screen_line_index > 1, 'bumped up against top screen line in line')

Replacement in source_text.lua at line 498 [42.83723]

B:BD[42.114836] → [43.8920:8977]

  assert(State.lines[State.cursor1.line].mode == 'text')

[42.114836]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in source_text.lua at line 500 [42.83723]
B:BD[42.114995] → [5.36:64]
```
  assert(State.cursor1.pos)
```
[42.114995]
[42.114995]
```
  assert(State.cursor1.pos, 'cursor has no pos')
```
Replacement in source_text.lua at line 574 [42.83723]
B:BD[42.120380] → [42.120380:120414]
```
    assert(State.cursor1.pos > 1)
```
[42.120380]
[42.120414]
```
    assert(State.cursor1.pos > 1, 'bumped up against start of line')
```
Deletion in source_text.lua at line 608 [42.83723]
B:BD[42.122540] → [42.122540:122563]
```
  assert(start_offset)
```

Replacement in source_text.lua at line 609 [42.83723]

B:BD[42.122606] → [42.122606:122642]

  assert(end_offset > start_offset)

[42.122606]

[42.122642]

  assert(end_offset > start_offset, ('end_offset %d not > start_offset %d'):format(end_offset, start_offset))

Replacement in source_text.lua at line 615 [42.83723]

B:BD[42.122747] → [46.3367:3424]

  assert(State.lines[State.cursor1.line].mode == 'text')

[42.122747]

[42.122864]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in source_text.lua at line 648 [42.83723]

B:BD[42.123998] → [43.9868:9925]

  assert(State.lines[State.cursor1.line].mode == 'text')

[42.123998]

[42.124163]

  assert(State.lines[State.cursor1.line].mode == 'text', 'line is not text')

Replacement in source_text.lua at line 673 [42.83723]
B:BD[42.125056] → [42.125056:125072]
```
  assert(false)
```
[42.125056]
[42.125072]
```
  assert(false, ('invalid pos %d'):format(loc1.pos))
```
Replacement in source_text.lua at line 687 [42.83723]
B:BD[8.4230] → [8.4230:4246]
```
  assert(false)
```
[8.4230]
[8.4246]
```
  assert(false, ('invalid pos %d'):format(loc1.pos))
```

Replacement in source_text.lua at line 712 [42.83723]

B:BD[43.10959] → [43.10959:11008]

    assert(State.cursor1.line == #State.lines+1)

[43.10959]

[43.11008]

    assert(State.cursor1.line == #State.lines+1, 'tried to ensure bottom line of file is text, but failed')

Replacement in source_text.lua at line 744 [42.83723]

B:BD[43.11422] → [43.11422:11507]

      assert(top2.line > 1)
      assert(State.lines[top2.line-1].mode == 'drawing')

[43.11422]

[43.11507]

      assert(top2.line > 1, 'tried to snap cursor to buttom of screen but failed')
      assert(State.lines[top2.line-1].mode == 'drawing', "expected a drawing but it's not")

Replacement in source_text.lua at line 777 [42.83723]
B:BD[42.130885] → [42.130885:130919]
```
  assert(my >= line_cache.starty)
```
[42.130885]
[42.130919]
```
  assert(my >= line_cache.starty, 'failed to map y pixel to line')
```
Replacement in source_text.lua at line 800 [42.83723]
B:BD[42.135357] → [42.135357:135373]
```
  assert(false)
```
[42.135357]
[42.135373]
```
  assert(false, 'failed to map y pixel to line')
```
Replacement in source_text.lua at line 866 [42.83723]
B:BD[42.138549] → [42.138549:138565]
```
  assert(false)
```
[42.138549]
[42.138565]
```
  assert(false, 'failed to map x pixel to pos')
```
Replacement in source_text.lua at line 897 [42.83723]
B:BD[42.139373] → [42.139373:139389]
```
  assert(false)
```
[42.139373]
[42.139389]
```
  assert(false, 'failed to map x pixel to pos')
```
Replacement in source_text.lua at line 928 [42.83723]
B:BD[42.140409] → [42.140409:140437]
```
  assert(result.screen_pos)
```
[42.140409]
[42.141090]
```
  assert(result.screen_pos, 'failed to convert schema-1 coordinate to schema-2')
```
Replacement in source_text.lua at line 970 [42.83723]
B:BD[42.142323] → [42.142323:142340]
```
  assert(result)
```
[42.142323]
[42.142340]
```
  assert(result, "Text.offset returned nil; this is likely a failure to handle utf8")
```

Replacement in source_select.lua at line 36 [47.23288]

B:BD[47.25073] → [47.25073:25104]

    assert(maxl == line_index)

[47.25073]

[47.25104]

    assert(maxl == line_index, ('maxl %d not equal to line_index %d'):format(maxl, line_index))

Replacement in source_select.lua at line 39 [47.23288]

B:BD[47.25144] → [47.25144:25175]

    assert(minl == line_index)

[47.25144]

[47.25175]

    assert(minl == line_index, ('minl %d not equal to line_index %d'):format(minl, line_index))

Replacement in source_select.lua at line 42 [47.23288]

B:BD[47.25203] → [47.25203:25251]

    assert(minl == maxl and minl == line_index)

[47.25203]

[47.25251]

    assert(minl == maxl and minl == line_index, ('minl %d, maxl %d and line_index %d are not all equal'):format(minl, maxl, line_index))

Replacement in source_select.lua at line 130 [47.23288]
B:BD[47.28832] → [47.28832:28854]
```
  assert(minl < maxl)
```
[47.28832]
[47.28854]
```
  assert(minl < maxl, ('minl %d not < maxl %d'):format(minl, maxl))
```
Replacement in source_select.lua at line 157 [47.23288]
B:BD[47.29732] → [47.29732:29754]
```
  assert(minl < maxl)
```
[47.29732]
[47.29754]
```
  assert(minl < maxl, ('minl %d not < maxl %d'):format(minl, maxl))
```
Replacement in source_file.lua at line 66 [42.150241]
B:BD[43.12869] → [43.12869:12886]
```
    assert(line)
```
[43.12869]
[43.12886]
```
    assert(line, 'drawing in file is incomplete')
```

Replacement in source_file.lua at line 91 [42.150241]

B:BD[43.14202] → [43.14202:14246]

      print(shape.mode)
      assert(false)

[43.14202]

[43.14246]

      assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in source_file.lua at line 125 [42.150241]

B:BD[43.15474] → [43.15474:15518]

      print(shape.mode)
      assert(false)

[43.15474]

[43.15518]

      assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in source_file.lua at line 163 [42.150241]
B:BD[43.16369] → [43.16369:16383]
```
    assert(i)
```
[43.16369]
[43.16383]
```
    assert(i, 'drawing in array is incomplete')
```

Replacement in source_file.lua at line 189 [42.150241]

B:BD[43.17716] → [43.17716:17760]

      print(shape.mode)
      assert(false)

[43.17716]

[43.17760]

      assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in source_edit.lua at line 161 [42.152440]

B:BD[42.155429] → [48.602:776]

∅:D[48.776] → [42.155473:155530]

B:BD[42.155473] → [42.155473:155530]

B:BD[42.155530] → [46.6410:6506]

∅:D[46.6506] → [42.155670:155694]

B:BD[42.155670] → [42.155670:155694]

  if #State.lines ~= #State.line_cache then
    print(('line_cache is out of date; %d when it should be %d'):format(#State.line_cache, #State.lines))
    assert(false)
  end
  if not Text.le1(State.screen_top1, State.cursor1) then
    print(State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos)
    assert(false)
  end

[42.155429]

[42.155694]

  assert(#State.lines == #State.line_cache, ('line_cache is out of date; %d elements when it should be %d'):format(#State.line_cache, #State.lines))
  assert(Text.le1(State.screen_top1, State.cursor1), ('screen_top (line=%d,pos=%d) is below cursor (line=%d,pos=%d)'):format(State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos))

Replacement in source_edit.lua at line 206 [42.152440]

B:BD[43.21468] → [43.21468:21511]

      print(line.mode)
      assert(false)

[43.21468]

[42.156342]

      assert(false, ('unknown line mode %s'):format(line.mode))

Replacement in select.lua at line 36 [49.43980]

B:BD[49.45604] → [49.45604:45635]

    assert(maxl == line_index)

[49.45604]

[49.45635]

    assert(maxl == line_index, ('maxl %d not equal to line_index %d'):format(maxl, line_index))

Replacement in select.lua at line 39 [49.43980]

B:BD[49.45675] → [49.45675:45706]

    assert(minl == line_index)

[49.45675]

[49.45706]

    assert(minl == line_index, ('minl %d not equal to line_index %d'):format(minl, line_index))

Replacement in select.lua at line 42 [49.43980]

B:BD[49.45734] → [49.45734:45782]

    assert(minl == maxl and minl == line_index)

[49.45734]

[49.45782]

    assert(minl == maxl and minl == line_index, ('minl %d, maxl %d and line_index %d are not all equal'):format(minl, maxl, line_index))

Replacement in select.lua at line 130 [49.43980]
B:BD[49.47652] → [49.47652:47674]
```
  assert(minl < maxl)
```
[49.47652]
[50.2897]
```
  assert(minl < maxl, ('minl %d not < maxl %d'):format(minl, maxl))
```
Replacement in select.lua at line 157 [49.43980]
B:BD[49.48425] → [49.48425:48447]
```
  assert(minl < maxl)
```
[49.48425]
[50.3510]
```
  assert(minl < maxl, ('minl %d not < maxl %d'):format(minl, maxl))
```

Replacement in search.lua at line 142 [49.48846]

B:BD[49.52011] → [49.52011:52037]

  assert (endpos >= #pat)

[49.52011]

[49.52037]

  assert (endpos >= #pat, ('rfind: endpos %d should be >= #pat %d at this point'):format(endpos, #pat))

Replacement in log_browser.lua at line 78 [42.191782]

∅:D[6.148] → [42.194820:194864]

B:BD[42.194820] → [42.194820:194864]

  assert(#State.lines == #State.line_cache)

[6.148]

[42.194864]

  assert(#State.lines == #State.line_cache, ('line_cache is out of date; %d elements when it should be %d'):format(#State.line_cache, #State.lines))

Replacement in log_browser.lua at line 98 [42.191782]

∅:D[51.358] → [42.195959:195997]

B:BD[42.195959] → [42.195959:195997]

        else assert(line.section_end)

[51.358]

[42.195997]

        else assert(line.section_end, "log line has a section name, but it's neither the start nor end of a section")

Replacement in geom.lua at line 41 [52.11579]

B:BD[52.12514] → [52.12514:12554]

    print(shape.mode)
    assert(false)

[52.12514]

[52.12554]

    assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in file.lua at line 58 [52.15083]
B:BD[52.16435] → [52.16435:16452]
```
    assert(line)
```
[52.16435]
[52.16452]
```
    assert(line, 'drawing in file is incomplete')
```

Replacement in file.lua at line 83 [52.15083]

B:BD[53.244] → [53.244:288]

      print(shape.mode)
      assert(false)

[53.244]

[52.17060]

      assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in file.lua at line 117 [52.15083]

B:BD[53.394] → [53.394:438]

      print(shape.mode)
      assert(false)

[53.394]

[52.18168]

      assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in file.lua at line 153 [52.15083]
B:BD[54.2092] → [54.2092:2106]
```
    assert(i)
```
[54.2092]
[55.2801]
```
    assert(i, 'drawing in array is incomplete')
```

Replacement in file.lua at line 179 [52.15083]

B:BD[54.3157] → [54.3157:3201]

      print(shape.mode)
      assert(false)

[54.3157]

[54.3201]

      assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in edit.lua at line 83 [56.413]

B:BD[56.3184] → [57.97073:97108]

    current_drawing_mode = 'line',

[56.3184]

[57.97108]

    current_drawing_mode = 'line',  -- one of the available shape modes

Replacement in edit.lua at line 160 [56.413]

B:BD[58.1023] → [59.642:816]

∅:D[59.816] → [60.988:1165]

B:BD[35.1895] → [60.988:1165]

  if #State.lines ~= #State.line_cache then
    print(('line_cache is out of date; %d when it should be %d'):format(#State.line_cache, #State.lines))
    assert(false)
  end
  if not Text.le1(State.screen_top1, State.cursor1) then
    print(State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos)
    assert(false)
  end

[58.1023]

[2.268]

  assert(#State.lines == #State.line_cache, ('line_cache is out of date; %d elements when it should be %d'):format(#State.line_cache, #State.lines))
  assert(Text.le1(State.screen_top1, State.cursor1), ('screen_top (line=%d,pos=%d) is below cursor (line=%d,pos=%d)'):format(State.screen_top1.line, State.screen_top1.pos, State.cursor1.line, State.cursor1.pos))

Replacement in edit.lua at line 201 [56.413]

B:BD[56.5492] → [61.1067:1110]

      print(line.mode)
      assert(false)

[56.5492]

[56.5845]

      assert(false, ('unknown line mode %s'):format(line.mode))

Deletion in drawing.lua at line 36 [62.98]
B:BD[62.935] → [62.935:953]
```
    assert(shape)
```

Replacement in drawing.lua at line 115 [62.98]

B:BD[63.1687] → [63.1687:1727]

    print(shape.mode)
    assert(false)

[63.1687]

[63.1727]

    assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in drawing.lua at line 208 [62.98]

B:BD[64.4021] → [64.4021:4061]

    print(shape.mode)
    assert(false)

[64.4021]

[63.4352]

    assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in drawing.lua at line 239 [62.98]
B:BD[64.4193] → [65.1263:1301]
∅:D[65.1301] → [64.4225:4243]
∅:D[57.129908] → [64.4225:4243]
B:BD[64.4225] → [64.4225:4243]
```
    print(State.current_drawing_mode)
    assert(false)
```
[64.4193]
[30.1671]
```
    assert(false, ('unknown drawing mode %s'):format(State.current_drawing_mode))
```
Replacement in drawing.lua at line 254 [62.98]
∅:D[66.179] → [67.218:254]
∅:D[9.207] → [67.218:254]
∅:D[68.225] → [67.218:254]
∅:D[69.2924] → [67.218:254]
∅:D[57.130025] → [67.218:254]
B:BD[67.218] → [67.218:254]
```
  assert(drawing.mode == 'drawing')
```
[9.207]
[70.17]
```
  assert(drawing.mode == 'drawing', 'Drawing.update: line is not a drawing')
```

Replacement in drawing.lua at line 341 [62.98]

B:BD[71.1574] → [71.1574:1621]

        assert(#drawing.pending.vertices <= 2)

[71.1574]

[71.1621]

        assert(#drawing.pending.vertices <= 2, 'Drawing.mouse_release: rectangle has too many pending vertices')

Replacement in drawing.lua at line 356 [62.98]

B:BD[71.2272] → [71.2272:2319]

        assert(#drawing.pending.vertices <= 2)

[71.2272]

[71.2319]

        assert(#drawing.pending.vertices <= 2, 'Drawing.mouse_release: square has too many pending vertices')

Replacement in drawing.lua at line 385 [62.98]
B:BD[64.6342] → [71.3819:3855]
∅:D[71.3855] → [64.6384:6406]
B:BD[64.6384] → [64.6384:6406]
```
        print(drawing.pending.mode)
        assert(false)
```
[64.6342]
[72.3044]
```
        assert(false, ('unknown drawing mode %s'):format(drawing.pending.mode))
```

Replacement in drawing.lua at line 543 [62.98]

B:BD[73.11016] → [73.11016:11040]

            assert(idx)

[73.11016]

[73.11040]

            assert(idx, 'point to delete is not in vertices')

Deletion in drawing.lua at line 639 [62.98]
B:BD[52.19849] → [52.19849:19873]
```
          assert(shape)
```
Deletion in drawing.lua at line 656 [62.98]
B:BD[52.20452] → [52.20452:20476]
```
          assert(point)
```

Replacement in drawing.lua at line 692 [62.98]

B:BD[52.21459] → [52.21459:21499]

    print(shape.mode)
    assert(false)

[52.21459]

[74.186]

    assert(false, ('unknown drawing mode %s'):format(shape.mode))

Replacement in drawing.lua at line 697 [62.98]

B:BD[74.230] → [74.230:265]

  assert(shape.mode == 'freehand')

[74.230]

[74.265]

  assert(shape.mode == 'freehand', 'can only smoothen freehand shapes')

Replacement in commands.lua at line 139 [42.204370]
B:BD[3.162] → [3.162:178]
```
  assert(index)
```
[3.162]
[3.178]
```
  assert(index, 'file missing from manifest')
```

audit all asserts

Dependencies

In channels

Change contents

Replacement in undo.lua at line 39 [12.1]

Replacement in undo.lua at line 43 [12.1]

Replacement in undo.lua at line 69 [12.1]

Replacement in undo.lua at line 83 [12.1]

Replacement in undo.lua at line 87 [12.1]

Replacement in undo.lua at line 94 [12.1]

Replacement in undo.lua at line 98 [12.1]

Replacement in text.lua at line 15 [17.1]

Replacement in text.lua at line 138 [17.1]

Replacement in text.lua at line 215 [17.1]

Replacement in text.lua at line 393 [17.1]

Replacement in text.lua at line 419 [17.1]

Replacement in text.lua at line 436 [17.1]

Replacement in text.lua at line 438 [17.1]

Replacement in text.lua at line 512 [17.1]

Deletion in text.lua at line 546 [17.1]

Replacement in text.lua at line 547 [17.1]

Replacement in text.lua at line 553 [17.1]

Replacement in text.lua at line 586 [17.1]

Replacement in text.lua at line 611 [17.1]

Replacement in text.lua at line 625 [17.1]

Replacement in text.lua at line 650 [17.1]

Replacement in text.lua at line 682 [17.1]

Replacement in text.lua at line 715 [17.1]

Replacement in text.lua at line 738 [17.1]

Replacement in text.lua at line 804 [17.1]

Replacement in text.lua at line 835 [17.1]

Replacement in text.lua at line 866 [17.1]

Replacement in text.lua at line 908 [17.1]

Replacement in source_undo.lua at line 39 [42.5]

Replacement in source_undo.lua at line 43 [42.5]

Replacement in source_undo.lua at line 68 [42.5]

Replacement in source_undo.lua at line 82 [42.5]

Replacement in source_undo.lua at line 86 [42.5]

Replacement in source_undo.lua at line 93 [42.5]

Replacement in source_undo.lua at line 97 [42.5]

Replacement in source_text.lua at line 20 [42.83723]

Replacement in source_text.lua at line 212 [42.83723]

Replacement in source_text.lua at line 289 [42.83723]

Replacement in source_text.lua at line 455 [42.83723]

Replacement in source_text.lua at line 481 [42.83723]

Replacement in source_text.lua at line 498 [42.83723]

Replacement in source_text.lua at line 500 [42.83723]

Replacement in source_text.lua at line 574 [42.83723]

Deletion in source_text.lua at line 608 [42.83723]

Replacement in source_text.lua at line 609 [42.83723]

Replacement in source_text.lua at line 615 [42.83723]

Replacement in source_text.lua at line 648 [42.83723]

Replacement in source_text.lua at line 673 [42.83723]

Replacement in source_text.lua at line 687 [42.83723]

Replacement in source_text.lua at line 712 [42.83723]

Replacement in source_text.lua at line 744 [42.83723]

Replacement in source_text.lua at line 777 [42.83723]

Replacement in source_text.lua at line 800 [42.83723]

Replacement in source_text.lua at line 866 [42.83723]

Replacement in source_text.lua at line 897 [42.83723]

Replacement in source_text.lua at line 928 [42.83723]

Replacement in source_text.lua at line 970 [42.83723]

Replacement in source_select.lua at line 36 [47.23288]

Replacement in source_select.lua at line 39 [47.23288]

Replacement in source_select.lua at line 42 [47.23288]

Replacement in source_select.lua at line 130 [47.23288]

Replacement in source_select.lua at line 157 [47.23288]

Replacement in source_file.lua at line 66 [42.150241]