akkartik/sokoban.love - Change GVOLLPQFFP5G7KCCSCPH42ZHGA5BORMTYN63FUNPXWW7FUK5OW2AC

bugfix: initial textinput event on iOS

love.textinput is fragile on iOS. Various things can cause an app to stop receiving textinput events. Resizing the window is one reliable way, but there's also another ghost, something that's triggering on every frame of LÖVE.

Fortunately, it looks like love.keyboard.setTextInput(true) reliably resubscribes the app to textinput events, regardless of their cause.

https://github.com/love2d/love/issues/1959

The one remaining open question here is why the call in App.keychord_press (equivalent to love.keypressed) doesn't fix the breakage caused by the initial window resize (that happens before any keys are pressed). I've confirmed that keypressed comes before textinput on iOS just like everywhere else.

Created by akkartik on November 19, 2023

GVOLLPQFFP5G7KCCSCPH42ZHGA5BORMTYN63FUNPXWW7FUK5OW2AC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 3 [7.2]
[5.1864]
[6.3]
```
OS = love.system.getOS()
```
Deletion in main.lua at line 13 [7.2]
B:BD[4.1] → [4.1:26]
∅:D[4.26] → [8.20:21]
∅:D[5.1931] → [8.20:21]
B:BD[9.184348] → [8.20:21]
```
OS = love.system.getOS()
```

Replacement in main.lua at line 219 [7.2]

B:BD[10.1203] → [3.0:107]

  love.keyboard.setTextInput(true)  -- magic. keeps iOS from losing textinput events after switching apps.

[10.1203]

[9.188176]

  if OS == 'iOS' then
    love.keyboard.setTextInput(true)  -- magic. iOS is prone to losing textinput events.
                                      -- https://github.com/love2d/love/issues/1959
  end

Replacement in app.lua at line 71 [13.2]

∅:D[11.870] → [12.994:1036]

B:BD[12.994] → [12.994:1036]

  App.screen.resize = love.window.setMode

[11.870]

[12.1036]


  App.screen.resize = function(width, height, flags)
    love.window.setMode(width, height, flags)
    if OS == 'iOS' then
      love.keyboard.setTextInput(true)  -- magic. iOS seems to lose textinput events after calls to setMode.
                                        -- https://github.com/love2d/love/issues/1959
    end
  end