akkartik/techmeet.love - Change OPCDU4JRKPTMJXGWCQ3FTYTGQO5CJVSLCOKSDWOFHBFHNQFH4FIQC

Collaborative wiki for a few of us. Fork of lines.love.

regression when we changed how we check for cursor in viewport

scenario:

scroll a way down the surface
append
press C-home to scroll up

Before this commit, panning keychords didn't trigger when cursor was out of viewport.

Ideally I'd clear cursor_x and cursor_y when initializing an editor state. But that breaks some tests.

Hopefully there aren't any other boundary conditions lurking here. This is a deliberately introduced incompatibility.

Created by Kartik K. Agaram on August 18, 2022

OPCDU4JRKPTMJXGWCQ3FTYTGQO5CJVSLCOKSDWOFHBFHNQFH4FIQC

Dependencies

In channels

main

Change contents

Insertion in main.lua at line 244 [6.2]

[4.36]

[5.5036]

  -- clear cursor pixel, leave it up to next draw to set them
  result.cursor_x = nil
  result.cursor_y = nil

Insertion in main.lua at line 1110 [6.2]
[3.1780]
[7.548]
```
--?     print(pane.cursor_x, pane.cursor_y)
```
Replacement in edit.lua at line 90 [10.413]
∅:D[8.450] → [9.97000:97036]
∅:D[5.9599] → [9.97000:97036]
B:BD[10.3084] → [9.97000:97036]
```
    -- cursor coordinates in pixels
```
[8.450]
[9.97036]
```
    -- cursor coordinates in pixels (nil => cursor is outside viewport)
```
Insertion in commands.lua at line 125 [12.39]
[2.747]
[11.1516]
```
--?     print(Cursor_pane.col, Cursor_pane.row, #Surface)
```