akkartik/wardley.love - Change M7QK5UKUYRA7WW4C5FAUV3WOKNVGSRFB4WKPIRPVZLNB32FIZ77QC

get rid of dubious heuristic helper

When we run into errors that aren't just assertion failures we should just be able to look at the entire call stack.

Created by Kartik K. Agaram on January 23, 2023

M7QK5UKUYRA7WW4C5FAUV3WOKNVGSRFB4WKPIRPVZLNB32FIZ77QC

Dependencies

In channels

main

Change contents

Replacement in app.lua at line 72 [5.2]

B:BD[4.33] → [3.18:72]

  App.run_tests(record_error_with_heuristic_location)

[4.33]

[6.1829]

  App.run_tests(record_error)

Deletion in app.lua at line 453 [5.2]

B:BD[7.395] → [7.395:534]

∅:D[8.268] → [9.60839:60966]

∅:D[7.534] → [9.60839:60966]

B:BD[9.60839] → [9.60839:60966]

B:BD[9.60966] → [11.95:222]

B:BD[11.222] → [2.18:115]

∅:D[2.115] → [9.61148:61188]

∅:D[11.313] → [9.61148:61188]

B:BD[9.61148] → [9.61148:61188]

end
-- Test_errors will be an array
-- add test_name and guess at file/line
function record_error_with_heuristic_location(test_name, err)
  local err_without_line_number = err:gsub('^[^:]*:[^:]*: ', '')
  local stack_trace = debug.traceback('', --[[stack frame]]5)
  local file_and_line_number = stack_trace:gsub('stack traceback:\n', ''):gsub(': .*', '') --[[strip newline and tab]] :sub(3)
  local full_error = test_name..' -- '..err_without_line_number..' ('..file_and_line_number..')'
  table.insert(Test_errors, full_error)