ambersz/procgen-skill-tree - Change 3J7QNHQ4F2VBYCK6SWKPO3AW3YYAJZNWOW6XNSURSRDZOE2ZIGQAC

catch a nasty deep prop copy shouldUpdate bug

Created by Bowei Liu on December 24, 2020

3J7QNHQ4F2VBYCK6SWKPO3AW3YYAJZNWOW6XNSURSRDZOE2ZIGQAC

Dependencies

In channels

main

Change contents

Replacement in frontend/src/lib/util/misc.ts at line 211 [5.45665]

B:BD[4.1610] → [2.452:524]

    console.log({ stack: new Error().stack, batchSize: batch.length });

[4.1610]

    // console.log({ stack: new Error().stack, batchSize: batch.length });
    console.log({ batchSize: batch.length });

Insertion in frontend/src/lib/util/misc.ts at line 214 [5.45665]

[4.1624]

      if (batch.length !== 0) { console.log({ fired: batch.length }); }

Replacement in frontend/src/pixi/BaseApplication.ts at line 47 [8.158]

B:BD[6.149] → [7.835:938]

      x: Math.min(1280, window?.x || Infinity) - 8,
      y: Math.min(720, window?.y || Infinity) - 8,

[6.149]

[6.218]

      x: Math.min(1280, window?.x || Infinity - 8),
      y: Math.min(720, window?.y || Infinity - 8),

Insertion in frontend/src/pixi/BaseApplication.ts at line 135 [8.158]

[4.3537]

    console.log("base app rerender called", { size: props.gameState.playerSave.allocatedPointNodeSet.size() });

Insertion in frontend/src/pixi/RootApplication.ts at line 166 [9.3626]

[7.1347]


    let prevSize = prevProps.gameState.playerSave.allocatedPointNodeSet.size()
    let nextSize = props.gameState.playerSave.allocatedPointNodeSet.size()
    if (prevSize !== nextSize) { console.log('rootapp shouldUpdate', { prevSize, nextSize }); }

Replacement in frontend/src/pixi/RootApplication.ts at line 226 [9.3626]
B:BD[10.968] → [10.968:1000]
```
    if (this.state.tick > 60) {
```
[10.968]
[10.1000]
```
    if (this.state.tick > 60 && !props.gameState.worldGen.zLevels[-1]) {
```
Replacement in frontend/src/pixi/RootApplication.ts at line 236 [9.3626]
B:BD[10.1283] → [10.1283:1316]
```
    if (this.state.tick > 120) {
```
[10.1283]
[10.1316]
```
    if (this.state.tick > 120 && !props.gameState.worldGen.zLevels[1]) {
```
Replacement in frontend/src/pixi/components/PointNodeComponent.ts at line 47 [11.9408]
B:BD[11.11491] → [11.11491:11529]
```
      this.container.tint = 0x00AAFF;
```
[11.11491]
[11.11529]
```
      this.container.tint = 0x000000;
```

Deletion in frontend/src/pixi/components/PointNodeComponent.ts at line 79 [11.9408]

B:BD[11.11965] → [11.11965:12099]

B:BD[12.1168] → [13.2003:2110]

∅:D[13.2110] → [11.12205:12319]

B:BD[11.12205] → [11.12205:12319]

      updaters.playerSave.allocatedPointNodeSet.update((prev, prevGameState) => {
        // if we were already selected, allocate us
        if (prevGameState.playerUI.selectedPointNode?.pointNodeId === args.selfPointNodeRef.pointNodeId) {
          prev.put(args.selfPointNodeRef);
          return prev.clone();
        }
        return prev;
      })

Replacement in frontend/src/pixi/components/PointNodeComponent.ts at line 80 [11.9408]

B:BD[11.12405] → [11.12405:12523]

B:BD[11.12523] → [13.2284:2391]

        // if we were already selected, allocate us and add to the history (maybe this should be managed elsewhere??)
        if (prevGameState.playerUI.selectedPointNode?.pointNodeId === args.selfPointNodeRef.pointNodeId) {

[11.12405]

[11.12629]

        // if we were already selected, but not yet allocated, allocate us and add to the history (maybe this should be managed elsewhere??)
        if (prevGameState.playerUI.selectedPointNode?.pointNodeId === args.selfPointNodeRef.pointNodeId && 
          !prevGameState.playerSave.allocatedPointNodeSet.contains(args.selfPointNodeRef)
        ) {

Insertion in frontend/src/pixi/components/PointNodeComponent.ts at line 85 [11.9408]
[11.12673]
[11.12673]
```
          console.log({ prev, actualPrev : [...prev]});
```

Insertion in frontend/src/pixi/components/PointNodeComponent.ts at line 90 [11.9408]

[11.12741]

      updaters.playerSave.allocatedPointNodeSet.update((prev, prevGameState) => {
        let history = prevGameState.playerSave.allocatedPointNodeHistory
        let mostRecent = history[history.length - 1]
          console.log({ history, actualHistory: [...history] });
        // if we were already selected, try to allocate us
        if (!prev.contains(mostRecent)) {
          prev.put(mostRecent);
          const next = prev.clone();
          console.log({ prev, next, prevSize: prev.size(), nextSize: next.size(), isEqual: prev === next })
          return next;
        }
        return prev;
      })

Insertion in frontend/src/pixi/components/ZLevelComponent.ts at line 82 [11.12896]

[7.3089]

          return true;
        } else {
          continue;
        }
      }
      if (key === 'allocatedPointNodeSubset') {
        if (prevProps[key].hash() !== props[key].hash()) {

Insertion in frontend/src/pixi/components/ZLevelComponent.ts at line 142 [11.12896]

[7.3362]

[3.6654]

    this.staleProps.allocatedPointNodeSubset = this.staleProps.allocatedPointNodeSubset.clone();