athaller/hstdb - Change 4LR5AJ4AX277G4G3SRDHNCIJIOCRZ6I4TUNTSZOAVUX4MW5GYFTQC

Clippy

Created by Alexander Thaller on September 28, 2020

4LR5AJ4AX277G4G3SRDHNCIJIOCRZ6I4TUNTSZOAVUX4MW5GYFTQC

Dependencies

In channels

main

Change contents

Insertion in src/main.rs at line 1 [4.9144]

[4.9144]

[5.4075]

#![warn(clippy::pedantic)]
#![warn(clippy::nursery)]
#![warn(clippy::unwrap_used)]
#![warn(rust_2018_idioms, unused_lifetimes)]

Replacement in src/run.rs at line 109 [3.1890]

B:BD[3.4275] → [3.4275:4312]

        command,
        dir_filter,

[3.4275]

[3.4312]

        &command,
        &dir_filter,

Replacement in src/run.rs at line 112 [3.1890]
B:BD[3.4332] → [3.4332:4354]
```
        command_text,
```
[3.4332]
[3.4354]
```
        &command_text,
```
Replacement in src/run.rs at line 180 [3.1890]
B:BD[3.6130] → [3.6130:6162]
```
    server.start(socket_path)?;
```
[3.6130]
[3.6162]
```
    server.start(&socket_path)?;
```
Replacement in src/server.rs at line 74 [4.10542]
∅:D[6.1269] → [5.8063:8095]
B:BD[5.8063] → [5.8063:8095]
```
    fn is_stop(&self) -> bool {
```
[6.1269]
[6.1270]
```
    const fn is_stop(&self) -> bool {
```

Replacement in src/server.rs at line 76 [4.10542]

B:BD[6.1291] → [6.1291:1368]

            RunState::Stop => true,
            RunState::Continue => false,

[6.1291]

[6.1368]

            Self::Stop => true,
            Self::Continue => false,

Replacement in src/server.rs at line 117 [4.10542]

B:BD[7.17926] → [7.17926:18000]

    pub fn start(mut self, socket_path: PathBuf) -> Result<Self, Error> {

[7.17926]

[2.183]

    pub fn start(mut self, socket_path: &PathBuf) -> Result<Self, Error> {

Replacement in src/server.rs at line 192 [4.10542]

B:BD[4.11440] → [7.18188:18245]

        self.store.add(entry).map_err(Error::AddStore)?;

[4.11440]

[6.2114]

        self.store.add(&entry).map_err(Error::AddStore)?;

Replacement in src/store.rs at line 48 [5.10073]
B:BD[5.10561] → [7.18308:18349]
```
pub fn new(data_dir: PathBuf) -> Store {
```
[5.10561]
[7.18349]
```
pub const fn new(data_dir: PathBuf) -> Store {
```

Replacement in src/store.rs at line 82 [5.10073]

B:BD[8.5620] → [8.5620:5679]

    pub fn add(&self, entry: Entry) -> Result<(), Error> {

[8.5620]

[8.5679]

    pub fn add(&self, entry: &Entry) -> Result<(), Error> {

Replacement in src/store.rs at line 87 [5.10073]

B:BD[8.5889] → [7.18492:18525]

∅:D[7.18525] → [8.5936:6007]

B:BD[8.5936] → [8.5936:6007]

        self.add_entry(&entry)?;
        self.commit(format!("add entry from {:?}", &entry.hostname))?;

[8.5889]

[5.12373]

        self.add_entry(entry)?;
        self.commit(format!("add entry from {:?}", entry.hostname))?;

Replacement in src/store.rs at line 124 [5.10073]

B:BD[9.176] → [10.316:356]

B:BD[10.356] → [11.615:652]

        command_filter: Option<String>,
        dir_filter: Option<PathBuf>,

[9.176]

[12.133]

        command_filter: &Option<String>,
        dir_filter: &Option<PathBuf>,

Replacement in src/store.rs at line 127 [5.10073]
B:BD[12.159] → [13.303:340]
```
        command_text: Option<Regex>,
```
[12.159]
[9.176]
```
        command_text: &Option<Regex>,
```

Replacement in src/store.rs at line 156 [5.10073]

B:BD[10.444] → [10.444:559]

B:BD[10.559] → [11.653:721]

                if let Some(ref command) = command_filter {
                    entry.command.starts_with(command)
                } else {
                    true
                }

[10.444]

[11.721]

                command_filter
                    .as_ref()
                    .map_or(true, |command| entry.command.starts_with(command))

Replacement in src/store.rs at line 161 [5.10073]

B:BD[11.766] → [11.766:818]

                if let Some(ref dir) = dir_filter {

[11.766]

[12.160]

                dir_filter.as_ref().map_or(true, |dir| {

Replacement in src/store.rs at line 167 [5.10073]
∅:D[14.57] → [10.559:627]
∅:D[12.350] → [10.559:627]
∅:D[11.856] → [10.559:627]
B:BD[10.559] → [10.559:627]
```
                } else {
                    true
                }
```
[12.350]
[10.627]
```
                })
```

Replacement in src/store.rs at line 170 [5.10073]

B:BD[13.371] → [13.371:546]

                if let Some(ref regex) = command_text {
                    regex.is_match(&entry.command)
                } else {
                    true
                }

[13.371]

[13.546]

                command_text
                    .as_ref()
                    .map_or(true, |regex| regex.is_match(&entry.command))