boogerlad/mj - Change BNLZWPJDKWXBK5KQXKQALAL4WOLOHLM4ZWLORKDPKC7EBYRY23VAC

save and serve product image dimensions to "improve lazy loading performance" and prevent reflow after the image is loaded. Before you think this is dumb, see https://youtu.be/4-d_SoCHeWE The browser can use the computed aspect ratio(therefor, scaled variants of the image will work the same! dimensions in db(x, y) don't have to match actual dimension at `destination`) and the css rules to figure out the dimensions of the containing element before the image is downloaded. also, seems cloudinary image uploads can fail with 500 'General Error'. pretty stupid description if you ask me, but that shouldn't fail a scrape.

Created by boogerlad on May 19, 2020

BNLZWPJDKWXBK5KQXKQALAL4WOLOHLM4ZWLORKDPKC7EBYRY23VAC

Dependencies

In channels

main

Change contents

Insertion in initialize.sql at line 155 [6.17]
[4.7441]
[5.1298]
```
	x smallint,
	y smallint,
```
Insertion in initialize.sql at line 641 [6.17]
[7.1985]
[7.1985]
```
	x smallint,
	y smallint,
```
Insertion in initialize.sql at line 662 [6.17]
[7.2218]
[7.2218]
```
		x,
		y,
```
Replacement in initialize.sql at line 676 [6.17]
B:BD[7.2426] → [7.2426:2443]
```
				destination
```
[7.2426]
[7.2443]
```
				destination,
				x,
				y
```
Insertion in initialize.sql at line 908 [6.17]
[8.793]
[8.793]
```
	x smallint,
	y smallint,
```
Insertion in initialize.sql at line 928 [6.17]
[3.2187]
[3.2187]
```
		x,
		y,
```
Insertion in initialize.sql at line 985 [6.17]
[3.3556]
[3.3556]
```
	x smallint,
	y smallint,
```
Insertion in initialize.sql at line 1022 [6.17]
[3.4613]
[8.1538]
```
		x,
		y,
```
Replacement in scrape/common.js at line 539 [10.4897]
B:BD[9.2878] → [9.2878:2900]
```
				let destination;
```
[9.2878]
[9.2900]
```
				let destination, x, y;
```

Replacement in scrape/common.js at line 549 [10.4897]

B:BD[9.3332] → [9.3332:3470]

						destination = (await cloudinary.uploader.upload(response, {public_id: response.substring(5), unique_filename: false})).secure_url;

[9.3332]

[9.3470]

						response = response.split('\n');
						[x, y] = response[1].split('x');
						try {
							destination = (await cloudinary.uploader.upload(response[0], {public_id: response[0].substring(5), unique_filename: false})).secure_url;
						} catch(e) {
							console.error(e);
							console.error('skipping image upload due to cloudinary outage')
							return;
						}

Replacement in scrape/common.js at line 566 [10.4897]
B:BD[9.3631] → [9.3631:3650]
```
						destination
```
[9.3631]
[9.3650]
```
						destination,
						x,
						y
```
Replacement in scrape/common.js at line 572 [10.4897]
B:BD[9.3689] → [9.3689:3699]
```
						$3
```
[9.3689]
[9.3699]
```
						$3,
						$4,
						$5
```
Replacement in scrape/common.js at line 577 [10.4897]
∅:D[2.29] → [9.3751:3787]
B:BD[9.3751] → [9.3751:3787]
```
					[productID, pic, destination]
```
[2.29]
[9.3787]
```
					[productID, pic, destination, x, y]
```

Replacement in scrape/common.js at line 588 [10.4897]

B:BD[9.4257] → [9.4257:4539]

						await postgres.query('update product_image set destination = $1 where product_image_id = $2', [
							(await cloudinary.uploader.upload(response, {public_id: response.substring(5), unique_filename: false})).secure_url,
							product_images[0].product_image_id
						]);

[9.4257]

[9.4539]

						response = response.split('\n');
						try {
							await postgres.query('update product_image set destination = $1, x = $2, y = $3 where product_image_id = $2', [
								(await cloudinary.uploader.upload(response[0], {public_id: response[0].substring(5), unique_filename: false})).secure_url,
								product_images[0].product_image_id, ...response[1].split('x')
							]);
						} catch(e) {
							console.error(e);
							console.error('skipping image upload due to cloudinary outage?')
							return;
						}

Insertion in scrape/image.sh at line 23 [10.10640]
[11.575]
[11.575]
```
		identify -format "%wx%h" "/tmp/$filename"
```
Insertion in scrape/image.sh at line 35 [10.10640]
[11.1035]
[11.1035]
```
				identify -format "%wx%h" "/tmp/$filename"
```

Dependencies

In channels

Change contents

Insertion in initialize.sql at line 155 [6.17]

Insertion in initialize.sql at line 641 [6.17]

Insertion in initialize.sql at line 662 [6.17]

Replacement in initialize.sql at line 676 [6.17]

Insertion in initialize.sql at line 908 [6.17]

Insertion in initialize.sql at line 928 [6.17]

Insertion in initialize.sql at line 985 [6.17]

Insertion in initialize.sql at line 1022 [6.17]

Replacement in scrape/common.js at line 539 [10.4897]

Replacement in scrape/common.js at line 549 [10.4897]

Replacement in scrape/common.js at line 566 [10.4897]

Replacement in scrape/common.js at line 572 [10.4897]

Replacement in scrape/common.js at line 577 [10.4897]

Replacement in scrape/common.js at line 588 [10.4897]

Insertion in scrape/image.sh at line 23 [10.10640]

Insertion in scrape/image.sh at line 35 [10.10640]