cryptix/caberl - Change QHK3BXHEC6IAAI7HK76Y7W3IQQIEFH7TD7AYMBCLOE7U2L7BT2LQC

save raw_post binary for replication

also: link posts to users and remove signature for some deduplication

Created by Henry on October 24, 2023

QHK3BXHEC6IAAI7HK76Y7W3IQQIEFH7TD7AYMBCLOE7U2L7BT2LQC

Dependencies

In channels

main

Change contents

Deletion in test/cable_posts_SUITE.erl at line 21 [4.2]
B:BD[3.55] → [3.55:80]
```
     , {signature, _Sig}
```
Deletion in test/cable_posts_SUITE.erl at line 41 [4.2]
B:BD[3.220] → [3.220:245]
```
     , {signature, _Sig}
```
Deletion in test/cable_posts_SUITE.erl at line 59 [4.2]
B:BD[3.315] → [3.315:340]
```
     , {signature, _Sig}
```
Deletion in test/cable_posts_SUITE.erl at line 75 [4.2]
B:BD[3.486] → [3.486:511]
```
     , {signature, _Sig}
```
Deletion in test/cable_posts_SUITE.erl at line 90 [4.2]
B:BD[3.722] → [3.722:747]
```
     , {signature, _Sig}
```
Deletion in test/cable_posts_SUITE.erl at line 108 [4.2]
B:BD[3.817] → [3.817:842]
```
     , {signature, _Sig}
```
Deletion in test/cable_posts_SUITE.erl at line 123 [4.2]
B:BD[3.1000] → [3.1000:1025]
```
     , {signature, _Sig}
```
Insertion in test/cable_database_suite.erl at line 17 [3.1367]
[3.1768]
[3.1768]
```
%% quick sanity test
```
Replacement in test/cable_database_suite.erl at line 21 [3.1367]
B:BD[3.1881] → [2.244:271]
```
    [Header, _] = Decoded,
```
[3.1881]
[2.271]
```
    [Header, Body] = Decoded,
```
Replacement in test/cable_database_suite.erl at line 24 [3.1367]
B:BD[3.2154] → [3.2154:2195]
```
    {ok, Id} = db:savePost(Db, Decoded),
```
[3.2154]
[3.2195]
```
    {ok, Id} = db:savePost(Db, Decoded, Bin),
```

Replacement in test/cable_database_suite.erl at line 26 [3.1367]

B:BD[3.2220] → [3.2220:2351]

B:BD[3.2351] → [2.318:359]

    {ok, LoadedPost} = db:loadPost(Db, Id),
    ?assertEqual(Decoded, LoadedPost),
    {ok, LoadedByHash} = db:loadPost(Db, Hash),
    ?assertEqual(Decoded, LoadedByHash),

[3.2220]

[2.359]

    {ok, [Header, Body, Bin]} = db:loadPost(Db, Id),
    {ok, [Header, Body, Bin]} = db:loadPost(Db, Hash),

Replacement in test/cable_database_suite.erl at line 42 [3.1367]

B:BD[2.806] → [2.806:848]

                   [Header, _] = Decoded,

[2.806]

[2.848]

                   [Header, Body] = Decoded,

Replacement in test/cable_database_suite.erl at line 44 [3.1367]

B:BD[2.849] → [2.849:905]

                   {ok, Id} = db:savePost(Db, Decoded),

[2.849]

[2.905]

                   {ok, Id} = db:savePost(Db, Decoded, Bin),

Replacement in test/cable_database_suite.erl at line 47 [3.1367]

B:BD[2.950] → [2.950:1063]

                   {ok, LoadedPost} = db:loadPost(Db, Id),
                   ?assertEqual(Decoded, LoadedPost),

[2.950]

[2.1063]

                   {ok, [LoadedHeader, LoadedBody, LoadedBin]} = db:loadPost(Db, Id),
                   ?assertEqual(Header, LoadedHeader),
                   ?assertEqual(Body, LoadedBody),
                   ?assertEqual(Bin, LoadedBin),

Replacement in test/cable_database_suite.erl at line 53 [3.1367]

B:BD[2.1125] → [2.1125:1243]

                   {ok, LoadedByHash} = db:loadPost(Db, Hash),
                   ?assertEqual(Decoded, LoadedByHash)

[2.1125]

[2.1243]

                   {ok, [LoadedHeader, LoadedBody, LoadedBin]} = db:loadPost(Db, Hash)

Replacement in db/schema.sql at line 9 [3.2646]

B:BD[3.2944] → [3.2944:3040]

  -- public key that authored this post
  public_key blob not null,
  signature  blob not null,

[3.2944]

[3.3040]


  user_id integer not null,
  raw_post blob not null,

Insertion in db/schema.sql at line 14 [3.2646]
[3.3041]
[3.3041]
Replacement in db/schema.sql at line 46 [3.2646]
B:BD[3.4195] → [3.4195:4199]
```
  )
```
[3.4195]
[3.4199]
```
  ),
  foreign key(user_id) references users(id)
```
Replacement in db/schema.sql at line 53 [3.2646]
B:BD[3.4250] → [3.4250:4276]
```
    parent blob not null,
```
[3.4250]
[3.4276]
```
    parent blob not null
```

Replacement in db/schema.sql at line 55 [3.2646]

B:BD[3.4277] → [3.4277:4372]

    foreign key(source) references posts(hash),
    foreign key(parent) references posts(hash)

[3.4277]

[3.4372]

    -- we will get posts for which we don't have the parent's (yet)
    -- foreign key(source) references posts(hash),
    -- foreign key(parent) references posts(hash)

Deletion in apps/cable/src/posts.erl at line 101 [5.5381]
B:BD[3.4725] → [3.4725:4763]
```
             , {signature, Signature}
```

Replacement in apps/cable/src/db.erl at line 3 [6.84]

B:BD[6.121] → [3.5137:5195]

-export([start_link/1, close/1, savePost/2, loadPost/2]).

[6.121]

[6.146]

-export([start_link/1, close/1, savePost/3, loadPost/2]).

Replacement in apps/cable/src/db.erl at line 12 [6.84]

B:BD[3.5259] → [3.5259:5324]

savePost(Db, Post) ->
    gen_server:call(Db, {savePost, Post}).

[3.5259]

[3.5324]

savePost(Db, Post, Data) when is_binary(Data) ->
    gen_server:call(Db, {savePost, Post, Data}).

Insertion in apps/cable/src/db.erl at line 20 [6.84]
[3.5524]
[6.259]

Replacement in apps/cable/src/db.erl at line 30 [6.84]

B:BD[3.5579] → [3.5579:5697]

    %% we might get links for which we don't have posts yet
    %% sqlite3:sql_exec(Db, "PRAGMA foreign_keys = ON;"),

[3.5579]

[6.430]

    ok = sqlite3:sql_exec(Db, "PRAGMA foreign_keys = ON;"),

Replacement in apps/cable/src/db.erl at line 38 [6.84]

B:BD[3.5700] → [3.5700:5764]

handle_call({savePost, Post}, _From, [{sql, Db}, _] = State) ->

[3.5700]

[3.5764]

handle_call({savePost, Post, Binary}, _From, [{sql, Db}, _] = State) ->

Replacement in apps/cable/src/db.erl at line 40 [6.84]

B:BD[3.5791] → [3.5791:5871]

    {value, {links, Links}, HeaderSansLinks} = lists:keytake(links, 1, Header),

[3.5791]

[3.5871]

    {value, {links, Links}, HeaderWOLinks} = lists:keytake(links, 1, Header),
    {value, {public_key, PubKey}, HeaderTrimmed} = lists:keytake(public_key, 1, HeaderWOLinks),

Replacement in apps/cable/src/db.erl at line 49 [6.84]

B:BD[3.6249] → [3.6249:6327]

    PostInsert = HeaderSansLinks ++ case proplists:get_value(type, Header) of

[3.6249]

[3.6327]

    %% establish user id
    {rowid, _RowId} = sqlite3:sql_exec(Db, "INSERT INTO users (public_key) VALUES (?) ON CONFLICT DO NOTHING;", [{blob, PubKey}]),
    [{columns, ["id","public_key","name"]}, {rows, [{UserId, {blob, PubKey}, _Name}]}] = sqlite3:read(Db, users, {public_key, {blob, PubKey}}),
    %% construct post insert statement
    PostInsert = [{user_id, UserId}, {raw_post, Binary}] ++ HeaderTrimmed ++ case proplists:get_value(type, Header) of

Insertion in apps/cable/src/db.erl at line 69 [6.84]
[3.6702]
[3.6702]
```
    %% convert all <<binaries>> to {blob, Bin}
```

Replacement in apps/cable/src/db.erl at line 83 [6.84]

B:BD[3.7356] → [2.2209:2265]

    Res= sqlite3:read(Db, posts, {hash, {blob, Hash}}),

[3.7356]

[2.2265]

    Res = sqlite3:read(Db, posts, {hash, {blob, Hash}}),

Replacement in apps/cable/src/db.erl at line 88 [6.84]

B:BD[2.2361] → [2.2361:2425]

    Post = unpackPost(Db, Res),
    {reply, {ok, Post}, State};

[2.2361]

[2.2425]

    {reply, {ok, unpackPost(Db, Res)}, State};

Replacement in apps/cable/src/db.erl at line 128 [6.84]

B:BD[2.2458] → [2.2458:2595]

    ExpectedCols = ["id", "hash", "type", "timestamp", "public_key", "signature", "channel", "text", "topic", "deletedHashes", "infos"],

[2.2458]

[2.2595]

    ExpectedCols = ["id", "hash", "type", "timestamp", "user_id", "raw_post", "channel", "text", "topic", "deletedHashes", "infos"],

Replacement in apps/cable/src/db.erl at line 130 [6.84]

B:BD[2.2654] → [2.2654:2727]

    {_RowId, {blob, Hash}, Type, Timestamp, {blob, PubKey}, {blob, Sig},

[2.2654]

[2.2727]

    {_RowId, {blob, Hash}, Type, Timestamp, UserId, {blob, RawPost},

Insertion in apps/cable/src/db.erl at line 135 [6.84]

[2.3029]

    [{columns, ["public_key"]}, {rows, [{{blob, PubKey}}]}] = sqlite3:sql_exec(Db, "SELECT public_key from users where id = ?", [UserId]),

Deletion in apps/cable/src/db.erl at line 138 [6.84]
B:BD[2.3065] → [2.3065:3097]
```
             , {signature, Sig}
```
Replacement in apps/cable/src/db.erl at line 166 [6.84]
B:BD[2.4134] → [2.4134:4154]
```
    [Header, Body].
```
[2.4134]
[6.1506]
```
    [Header, Body, RawPost].
```

Replacement in apps/cable/src/db.erl at line 177 [6.84]

B:BD[3.9475] → [3.9475:9642]

               channels => [ColId, {name, text, not_null}, {topic, text, not_null}],
               users => [ColId, {pubkey, blob, not_null}, {name, text, not_null}]

[3.9475]

[3.9642]

               channels => [{name, text, [primary_key]}, {topic, text, not_null}],
               users => [ColId, {public_key, blob, [unique, not_null]}, {name, text}]

save raw_post binary for replication

Dependencies

In channels

Change contents

Deletion in test/cable_posts_SUITE.erl at line 21 [4.2]

Deletion in test/cable_posts_SUITE.erl at line 41 [4.2]

Deletion in test/cable_posts_SUITE.erl at line 59 [4.2]

Deletion in test/cable_posts_SUITE.erl at line 75 [4.2]

Deletion in test/cable_posts_SUITE.erl at line 90 [4.2]

Deletion in test/cable_posts_SUITE.erl at line 108 [4.2]

Deletion in test/cable_posts_SUITE.erl at line 123 [4.2]

Insertion in test/cable_database_suite.erl at line 17 [3.1367]

Replacement in test/cable_database_suite.erl at line 21 [3.1367]

Replacement in test/cable_database_suite.erl at line 24 [3.1367]