cryptix/caberl - Change YA3ELS7AQZ2XCZZVNMZOM3TSVCWU7HSBVMDXFCIOFTXAYFZSRL2AC

fix decode_hash_response

Created by Henry on October 11, 2023

YA3ELS7AQZ2XCZZVNMZOM3TSVCWU7HSBVMDXFCIOFTXAYFZSRL2AC

Dependencies

In channels

main

Change contents

Replacement in test/cable_basic_SUITE.erl at line 5 [3.22]

B:BD[3.253] → [3.253:277]

B:BD[3.277] → [4.2:66]

B:BD[4.66] → [5.2:88]

hash_response_test() ->
    [{binary, Bin}, {obj, TestObj}] = examples:hash_response(),
    [{header, Header},  {ttl, 1}, {hashes, Hashes}] = wire:decode_hash_response(Bin),

[3.253]

[5.88]

post_request_test() ->
    [{binary, Bin}, {obj, TestObj}] = examples:post_request(),
    [{header, Header},  {ttl, 1}, {hashes, Hashes}] = wire:decode_post_request(Bin),

Insertion in test/cable_basic_SUITE.erl at line 10 [3.22]
[2.52]
[2.52]
```
    ?assertEqual(2, proplists:get_value(msgType, Header)),
```
Insertion in test/cable_basic_SUITE.erl at line 18 [3.22]
[5.271]
[5.271]
```
    ?assertEqual(3, proplists:get_value(msgType, Header)),
```
Insertion in test/cable_basic_SUITE.erl at line 31 [3.22]
[5.427]
[2.138]
```
    ?assertEqual(4, proplists:get_value(msgType, Header)),
```
Insertion in test/cable_basic_SUITE.erl at line 45 [3.22]
[5.961]
[2.383]
```
    ?assertEqual(5, proplists:get_value(msgType, Header)),
```
Insertion in test/cable_basic_SUITE.erl at line 56 [3.22]
[6.19]
[6.19]
```
    ?assertEqual(6, proplists:get_value(msgType, Header)),
```

Replacement in test/cable_basic_SUITE.erl at line 59 [3.22]

B:BD[6.56] → [6.56:299]

B:BD[6.299] → [2.504:583]

∅:D[2.583] → [6.376:385]

B:BD[6.376] → [6.376:385]

% TODO: is this one supposed to break?
hash_response2_test() ->
    [{binary, Bin}, {obj, _TestObj}] = examples:hash_response2(),
    try
        Error = wire:decode_hash_response(Bin),
        ?assert(Error)
    catch
        error:Reason ->
            ?assertEqual("invalid hash_count - expected 2 but got 32", Reason)
    end.

[6.56]

[6.385]

hash_response_test() ->
    [{binary, Bin}, {obj, TestObj}] = examples:hash_response(),
    Decoded = wire:decode_hash_response(Bin),
    [ {header, Header}
    , {hashes, Hashes}
    ] = Decoded,
    ?assertEqual(0, proplists:get_value(msgType, Header)),
    % TODO: assert Hash values
    ?assertEqual(length(maps:get(<<"hashes">>, TestObj)), length(Hashes)),
    assert_header(Header, TestObj).

Insertion in test/cable_basic_SUITE.erl at line 76 [3.22]
[5.1324]
[2.584]
```
    ?assertEqual(1, proplists:get_value(msgType, Header)),
```
Insertion in test/cable_basic_SUITE.erl at line 86 [3.22]
[6.851]
[6.851]
```
    ?assertEqual(7, proplists:get_value(msgType, Header)),
```

Replacement in test/cable_basic_SUITE.erl at line 180 [3.22]

B:BD[4.1649] → [6.3899:3963]

    ?assertEqual(ReqId, proplists:get_value(requestId, Header)).

[4.1649]

    ?assertEqual(ReqId, proplists:get_value(requestId, Header)).

Replacement in apps/cable/src/wire.erl at line 3 [3.5336]

B:BD[3.5353] → [6.3972:4188]

-export([decode_hash_response/1, decode_cancel_request/1, decode_channel_time_range_request/1, decode_channel_state_request/1, decode_channel_list_request/1, decode_post_response/1, decode_channel_list_response/1]).

[3.5353]

[3.5390]

-export([decode_post_request/1, decode_hash_response/1, decode_cancel_request/1, decode_channel_time_range_request/1, decode_channel_state_request/1, decode_channel_list_request/1, decode_post_response/1, decode_channel_list_response/1]).

Insertion in apps/cable/src/wire.erl at line 8 [3.5336]
[3.5436]
[3.5436]
Insertion in apps/cable/src/wire.erl at line 20 [3.5336]
[3.5775]
[3.5775]
```
% TODO: assert message type on all concrete decoders
```

Insertion in apps/cable/src/wire.erl at line 24 [3.5336]

[4.2159]

    Header = decode_response_header(Data),
    Payload = proplists:get_value(payload, Header),
    {HashCount, Rest} = decode_varint(Payload),
    Hashes = [Hash || <<Hash:32/binary>> <= Rest],
    case length(Hashes) =:= HashCount of
        false -> 
            ErrMsg = io_lib:format("invalid hash_count - stated ~p but got ~p", [HashCount, length(Hashes)]),
            erlang:error(lists:flatten(ErrMsg));
        true ->
        [ {header, proplists:delete(payload, Header)}
        , {hashes, Hashes}
        ]
    end.
decode_post_request(Data) ->

Replacement in apps/cable/src/wire.erl at line 45 [3.5336]

B:BD[6.4398] → [6.4398:4510]

            ErrMsg = io_lib:format("invalid hash_count - expected ~p but got ~p", [length(Hashes), HashCount]),

[6.4398]

[6.4510]

            ErrMsg = io_lib:format("invalid hash_count - stated ~p but got ~p", [HashCount, length(Hashes)]),

Replacement in apps/cable/src/examples.erl at line 7 [7.11]

B:BD[5.2891] → [6.8707:8781]

-export([hash_response/0, cancel_request/0, channel_time_range_request/0,

[5.2891]

[6.8781]

-export([post_request/0, cancel_request/0, channel_time_range_request/0,

Replacement in apps/cable/src/examples.erl at line 9 [7.11]

B:BD[6.8833] → [6.8833:8896]

   hash_response2/0, post_response/0, channel_list_response/0,

[6.8833]

[6.8896]

   hash_response/0, post_response/0, channel_list_response/0,

Replacement in apps/cable/src/examples.erl at line 13 [7.11]

B:BD[7.145] → [7.145:164]

B:BD[7.164] → [6.8985:9582]

hash_response() ->
  D = <<"{\"name\":\"hash response\",\"type\":\"response\",\"id\":2,\"binary\":\"6b020000000095050429010320265674e8aac2dfddd78f86fe5a3dd68d976ca3f5ba23645ec7381480921d0d10705340e5528f2ef03a6797b72b1bb9f37f9009ad408247387c4bcc4d2a3371af700793dd51d4cb3c18a6df46f88bfe1665fba9b277487ddecd1e031441d69d\",\"obj\":{\"msgLen\":107,\"msgType\":2,\"reqid\":\"95050429\",\"ttl\":1,\"hashes\":[\"20265674e8aac2dfddd78f86fe5a3dd68d976ca3f5ba23645ec7381480921d0d\",\"10705340e5528f2ef03a6797b72b1bb9f37f9009ad408247387c4bcc4d2a3371\",\"af700793dd51d4cb3c18a6df46f88bfe1665fba9b277487ddecd1e031441d69d\"]}}">>,

[7.69]

[7.760]

post_request() ->
  D = <<"{\"name\":\"post request\",\"type\":\"request\",\"id\":2,\"binary\":\"6b020000000095050429010320265674e8aac2dfddd78f86fe5a3dd68d976ca3f5ba23645ec7381480921d0d10705340e5528f2ef03a6797b72b1bb9f37f9009ad408247387c4bcc4d2a3371af700793dd51d4cb3c18a6df46f88bfe1665fba9b277487ddecd1e031441d69d\",\"obj\":{\"msgLen\":107,\"msgType\":2,\"reqid\":\"95050429\",\"ttl\":1,\"hashes\":[\"20265674e8aac2dfddd78f86fe5a3dd68d976ca3f5ba23645ec7381480921d0d\",\"10705340e5528f2ef03a6797b72b1bb9f37f9009ad408247387c4bcc4d2a3371\",\"af700793dd51d4cb3c18a6df46f88bfe1665fba9b277487ddecd1e031441d69d\"]}}">>,

Replacement in apps/cable/src/examples.erl at line 33 [7.11]
B:BD[6.9610] → [6.9610:9630]
```
hash_response2() ->
```
[6.9610]
[6.9630]
```
hash_response() ->
```
Replacement in apps/cable/src/examples.erl at line 80 [7.11]
B:BD[7.1556] → [7.1556:1571]
```
   {obj, Obj}].
```
[7.1556]
```
   {obj, Obj}].
```

fix decode_hash_response

Dependencies

In channels

Change contents

Replacement in test/cable_basic_SUITE.erl at line 5 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 10 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 18 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 31 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 45 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 56 [3.22]

Replacement in test/cable_basic_SUITE.erl at line 59 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 76 [3.22]

Insertion in test/cable_basic_SUITE.erl at line 86 [3.22]

Replacement in test/cable_basic_SUITE.erl at line 180 [3.22]

Replacement in apps/cable/src/wire.erl at line 3 [3.5336]

Insertion in apps/cable/src/wire.erl at line 8 [3.5336]

Insertion in apps/cable/src/wire.erl at line 20 [3.5336]

Insertion in apps/cable/src/wire.erl at line 24 [3.5336]

Replacement in apps/cable/src/wire.erl at line 45 [3.5336]

Replacement in apps/cable/src/examples.erl at line 7 [7.11]

Replacement in apps/cable/src/examples.erl at line 9 [7.11]

Replacement in apps/cable/src/examples.erl at line 13 [7.11]

Replacement in apps/cable/src/examples.erl at line 33 [7.11]

Replacement in apps/cable/src/examples.erl at line 80 [7.11]