fiddlerwoaroof/crawl - Change EQTVT6PY3KU75ULAO3CFDPMBG5WSPSSJIUSDUK4JMGALBOLOXNOQC

files.cc, newgame.cc: support savegame paths with spaces in them

For instance, on Mac OS X, we save to this path: ~/Library/Application Support/Dungeon Crawl Stone Soup

But if we just pass this path to an external program via system() without doing anything to it, the app assumes that spaces are intended to indicate separate parameters.

We have to escape the paths in one of two ways.

UNIX (backslashes): ~/This\ Crappy\ Path\ Has\ Spaces\ In\ It

or Windows (doublequotes): "C:\This Crappy Path Has Spaces In It"

Signed-off-by: Steven Noonan <steven@uplinklabs.net>

Created by Steven Noonan on September 30, 2009

EQTVT6PY3KU75ULAO3CFDPMBG5WSPSSJIUSDUK4JMGALBOLOXNOQC

Dependencies

In channels

main

Change contents

Replacement in crawl-ref/source/newgame.cc at line 638 [4.1132300]

B:BD[3.64] → [3.64:117]

        const std::string directory = get_savedir();

[3.64]

[4.1139614]

        std::string directory = get_savedir();

Insertion in crawl-ref/source/newgame.cc at line 640 [4.1132300]

[4.1139615]

[5.382100]

        escape_path_spaces(basename);
        escape_path_spaces(directory);

Replacement in crawl-ref/source/files.cc at line 696 [4.3084589]

B:BD[5.863506] → [3.406:470]

        const std::string zipname = get_savedir_path(basename);

[5.863506]

[5.863564]

        std::string zipname = get_savedir_path(basename);
        escape_path_spaces(zipname);

Insertion in crawl-ref/source/files.cc at line 701 [4.3084589]
[5.863663]
[3.471]
```
        escape_path_spaces(filename);
```

Replacement in crawl-ref/source/files.cc at line 703 [4.3084589]

B:BD[3.472] → [3.472:519]

        const std::string dir = get_savedir();

[3.472]

[5.863663]

        std::string dir = get_savedir();
        escape_path_spaces(dir);

Replacement in crawl-ref/source/files.cc at line 729 [4.3084589]

∅:D[2.2935] → [6.18210:18278]

B:BD[6.18210] → [6.18210:18278]

                    const std::string dollname = basename + ".tdl";

[2.2935]

[6.18278]

                    std::string dollname = basename + ".tdl";
                    const std::string dollpath = get_savedir_path(dollname);

Insertion in crawl-ref/source/files.cc at line 732 [4.3084589]
[6.18305]
[6.18305]
```
                    escape_path_spaces(dollname);
```

Deletion in crawl-ref/source/files.cc at line 740 [4.3084589]

B:BD[6.18605] → [6.18605:18682]

                    const std::string dollpath = get_savedir_path(dollname);

Insertion in crawl-ref/source/files.cc at line 1660 [4.3084589]
[5.870945]
[5.870945]
```
    escape_path_spaces(basename);
```