fiddlerwoaroof/crawl - Change LCDAVMTTCXQW6AOXG4IHXGRGVNMA47ZKHXW3NDYK2YFJFBMCFFQAC

Fix 2018066: Crash when "autoinscribing" non-artefacts.

Fix 2017743: Game hanging for "good random choices" for Thieves/Wanderers

git-svn-id: https://crawl-ref.svn.sourceforge.net/svnroot/crawl-ref/trunk@6543 c06c8d41-db1a-0410-9941-cceddc491573

Created by j-p-e-g on July 14, 2008

LCDAVMTTCXQW6AOXG4IHXGRGVNMA47ZKHXW3NDYK2YFJFBMCFFQAC

Dependencies

In channels

main

Change contents

Insertion in crawl-ref/source/newgame.cc at line 3854 [6.1132300]

[4.226267]

[5.12901]

        if (you.char_class == JOB_THIEF || you.char_class == JOB_WANDERER)
            good_randrace = false;

Replacement in crawl-ref/source/newgame.cc at line 3863 [6.1132300]

B:BD[7.22036] → [7.22036:22085]

B:BD[7.22085] → [8.22440:22583]

               || (you.char_class != JOB_UNKNOWN
                   && !_is_good_combination(_get_species(index), you.char_class,
                                            good_randrace)));

[7.22036]

[5.13124]

               || you.char_class != JOB_UNKNOWN
                  && !_is_good_combination(_get_species(index), you.char_class,
                                           good_randrace));

Replacement in crawl-ref/source/newgame.cc at line 4001 [6.1132300]
∅:D[2.2821] → [8.24128:24170]
B:BD[8.24128] → [8.24128:24170]
```
                    "+ - Good random" EOL
```
[2.2821]
[8.24170]
```
                    "+ - Good random class" EOL
```
Deletion in crawl-ref/source/describe.cc at line 2098 [6.3736416]
B:BD[9.12850] → [3.4090:4188]
∅:D[3.4188] → [9.13062:13063]
B:BD[9.13062] → [9.13062:13063]
B:BD[9.13063] → [3.4189:4266]
∅:D[3.4266] → [9.13242:13243]
B:BD[9.13242] → [9.13242:13243]
B:BD[9.13243] → [3.4267:4320]
```
    case 'a':
        // Remove previous randart inscription
        _trim_randart_inscrip(item);
        if (!item.inscription.empty())
            item.inscription += ", ";
        item.inscription += ainscrip;
        break;
```

Insertion in crawl-ref/source/describe.cc at line 2101 [6.3736416]

[3.4383]

    case 'a':
        if (need_autoinscribe)
        {
            // Remove previous randart inscription.
            _trim_randart_inscrip(item);
            if (!item.inscription.empty())
                item.inscription += ", ";
            item.inscription += ainscrip;
            break;
        }
        // If autoinscription is impossible, prompt for an inscription instead.