fiddlerwoaroof/crawl - Change ORKHQ6NO4MLKUAIP4OAOF5M5JPANJ7K2RONIGPX2TFU3EH3W5ZEAC

Move checks for visibly special armour into their own function, a la

_weapon_is_visibly_special().

git-svn-id: https://crawl-ref.svn.sourceforge.net/svnroot/crawl-ref/trunk@9074 c06c8d41-db1a-0410-9941-cceddc491573

Created by dolorous on February 14, 2009

ORKHQ6NO4MLKUAIP4OAOF5M5JPANJ7K2RONIGPX2TFU3EH3W5ZEAC

Dependencies

In channels

main

Change contents

Deletion in crawl-ref/source/makeitem.cc at line 2934 [5.927]
∅:D[3.24658] → [4.13986:13987]
B:BD[4.13986] → [4.13986:13987]

Insertion in crawl-ref/source/makeitem.cc at line 2939 [5.927]

[4.14097]

[6.3524]

        && (one_chance_in(3) || get_equip_race(item) && one_chance_in(7)))
    {
        return (true);
    }
    return (false);
}
static bool _armour_is_visibly_special(const item_def &item)
{
    const int brand = get_armour_ego_type(item);
    const bool visibly_branded = (brand != SPARM_NORMAL);
    if (_item_is_mundane(item))
        return (false);
    if (get_equip_desc(item) != ISFLAG_NO_DESC)
        return (false);
    if (visibly_branded || is_random_artefact(item))
        return (true);
    if (item.plus

Replacement in crawl-ref/source/makeitem.cc at line 4520 [5.927]

B:BD[7.947] → [2.2851:2979]

∅:D[2.2979] → [4.21199:21251]

B:BD[7.1082] → [4.21199:21251]

        // If not given a racial type, and special, make shiny/runed/etc.
        if (get_armour_ego_type(item) != SPARM_NORMAL
            || item.plus != 0 && !one_chance_in(3))

[7.947]

[7.1136]

        if (_armour_is_visibly_special(item))