fiddlerwoaroof/crawl - Change U4RJT4J4ZCOPYRSP42IBYTKQYD2Z4YD3JY5S4ANN6TRVNADRB2BAC

Be more explicit about why los_maps test fails.

One class of false errors is when a stair gets placed in the LOS map.

Created by Robert Vollmert on October 18, 2009

U4RJT4J4ZCOPYRSP42IBYTKQYD2Z4YD3JY5S4ANN6TRVNADRB2BAC

Dependencies

In channels

main

Change contents

Insertion in crawl-ref/source/test/los_maps.lua at line 30 [3.287]
[3.1150]
[3.1150]
```
      local feat = dgn.grid(xa, ya)
```

Replacement in crawl-ref/source/test/los_maps.lua at line 32 [3.287]

B:BD[3.1199] → [3.1199:1311]

                          dgn.grid(xa, ya) == rock_wall or
                          dgn.grid(xa, ya) == floor)

[3.1199]

[2.1606]

                          feat == rock_wall or
                          feat == floor)
      local should_not_see = (x ~= 0 or y ~= 0) and
                              (feat == stone_wall or feat == water)
      if (not (should_see or should_not_see)) then
        assert(false, "Illegal feature " .. dgn.feature_name(feat) .. " (" ..
                      feat .. ") at " .. p .. " in " .. name .. ".")
      end

Replacement in crawl-ref/source/test/los_maps.lua at line 41 [3.287]

∅:D[2.1649] → [3.1354:1712]

B:BD[3.1354] → [3.1354:1712]

      if can_see and (not should_see) then
        assert(false, "los error in " .. name .."(iter #" .. checks ..
                      "): can see " .. p .. " but shouldn't.")
      elseif (not can_see) and should_see then
        assert(false, "los error in " .. name .. "(iter #" .. checks ..
                      "): should see " .. p .. " but can't.")

[2.1649]

[3.1712]

      local err = can_see and (not should_see) or (not can_see) and should_see
      if err then
        local cans = can_see and "can" or "can't"
        local shoulds = should_see and "should" or "shouldn't"
        local errstr = "LOS error in " .. name .. ": " .. shoulds ..
                       " see " .. p .. " (" .. feat .. ") but " .. cans .. "."
        assert(false, errstr)