fiddlerwoaroof/crawl - Change VIFRP3HZEONFR6PQRYZYM3YUEJOQ7T4F5CZY4MN4YJMB23FMU7XAC

Add a metric ton of compiler warnings to the Xcode project, and clean

up the source accordingly.

At some point these warnings should be merged into the makefile system, but I don't have the will to merge them into the 3451351235 individual makefiles at the moment.

git-svn-id: https://crawl-ref.svn.sourceforge.net/svnroot/crawl-ref/trunk@12 c06c8d41-db1a-0410-9941-cceddc491573

Created by nlanza on August 12, 2006

VIFRP3HZEONFR6PQRYZYM3YUEJOQ7T4F5CZY4MN4YJMB23FMU7XAC

Dependencies

In channels

main

Change contents

Replacement in crawl-ref/source/travel.h at line 117 [3.29464]

B:BD[3.33661] → [3.33661:33719]

    RUN_INTERLEVEL  = -3,   // Interlevel travel (Ctrl+G)

[3.33661]

[3.33719]

    RUN_INTERLEVEL  = -3    // Interlevel travel (Ctrl+G)

Replacement in crawl-ref/source/travel.h at line 126 [3.29464]
B:BD[3.33827] → [3.33827:33848]
```
    ES_ALTAR    = 8,
```
[3.33827]
[3.33848]
```
    ES_ALTAR    = 8
```
Replacement in crawl-ref/source/travel.cc at line 43 [3.39949]
B:BD[3.40747] → [3.40747:40772]
```
    ID_CANCEL   = -1000,
```
[3.40747]
[3.40772]
```
    ID_CANCEL   = -1000
```
Insertion in crawl-ref/source/travel.cc at line 902 [3.39949]
[3.68901]
[3.68901]
```
    unsigned char feature;
```
Replacement in crawl-ref/source/travel.cc at line 982 [3.39949]
B:BD[3.71757] → [3.71757:71804]
```
            unsigned char feature = grd[x][y];
```
[3.71757]
[3.71804]
```
            feature = grd[x][y];
```

Replacement in crawl-ref/source/travel.cc at line 1081 [3.39949]

B:BD[3.76205] → [3.76205:76262]

                    unsigned char feature = grd[dx][dy];

[3.76205]

[3.76262]

                    feature = grd[dx][dy];

Replacement in crawl-ref/source/stash.cc at line 415 [3.147324]

B:BD[3.158122] → [3.158122:158191]

        snprintf(additionals, sizeof additionals, " (+%u)", sz - 1);

[3.158122]

[3.158191]

        snprintf(additionals, sizeof additionals, " (+%lu)", (unsigned long) (sz - 1));

Insertion in crawl-ref/source/stash.cc at line 470 [3.147324]
[3.159691]
[3.159691]
```
    int i;
    
```
Replacement in crawl-ref/source/stash.cc at line 479 [3.147324]
B:BD[3.159929] → [3.159929:159977]
```
    for (unsigned i = 0; i < items.size(); ++i)
```
[3.159929]
[3.159977]
```
    for (i = 0; i < (int) items.size(); ++i)
```

Replacement in crawl-ref/source/stash.cc at line 515 [3.147324]

B:BD[3.161209] → [3.161209:161270]

                for (int i = desc.length() - 1; i >= 0; --i)

[3.161209]

[3.161270]

                for (i = desc.length() - 1; i >= 0; --i)

Replacement in crawl-ref/source/spl-util.cc at line 77 [4.245665]
B:BD[4.247688] → [4.247688:247747]
```
};                              // end init_playerspells()
```
[4.247688]
[4.247747]
```
}                               // end init_playerspells()
```
Replacement in crawl-ref/source/newgame.cc at line 3209 [4.1132300]
B:BD[3.229931] → [3.229931:229978]
```
            for (int i = 0; i < NUM_JOBS; i++)
```
[3.229931]
[3.229978]
```
            for (i = 0; i < NUM_JOBS; i++)
```

Replacement in crawl-ref/source/mutation.cc at line 1441 [4.1263003]

B:BD[4.1310164] → [4.1310164:1310224]

            for (int i = EQ_WEAPON; i < EQ_RIGHT_RING; i++)

[4.1310164]

[4.1310224]

            for (i = EQ_WEAPON; i < EQ_RIGHT_RING; i++)

Replacement in crawl-ref/source/mutation.cc at line 1459 [4.1263003]

B:BD[4.1310665] → [4.1310665:1310725]

            for (int i = EQ_WEAPON; i < EQ_RIGHT_RING; i++)

[4.1310665]

[4.1310725]

            for (i = EQ_WEAPON; i < EQ_RIGHT_RING; i++)

Replacement in crawl-ref/source/mutation.cc at line 1481 [4.1263003]

B:BD[4.1311292] → [4.1311292:1311352]

            for (int i = EQ_WEAPON; i < EQ_RIGHT_RING; i++)

[4.1311292]

[4.1311352]

            for (i = EQ_WEAPON; i < EQ_RIGHT_RING; i++)

Replacement in crawl-ref/source/monplace.cc at line 121 [4.1641732]
B:BD[4.1645037] → [4.1645037:1645068]
```
                int count = 0;
```
[4.1645037]
[4.1645068]
```
                count = 0;
```
Replacement in crawl-ref/source/menu.h at line 129 [3.255942]
B:BD[3.259007] → [3.259007:259033]
```
    MF_EASY_EXIT    = 64,
```
[3.259007]
[3.259033]
```
    MF_EASY_EXIT    = 64
```

Replacement in crawl-ref/source/menu.h at line 145 [3.255942]

B:BD[3.259440] → [3.259440:259499]

    void set_flags( int flags )   { this->flags = flags; }

[3.259440]

[3.259499]

    void set_flags( int new_flags )   { this->flags = new_flags; }

Replacement in crawl-ref/source/libutil.h at line 97 [4.2493627]
B:BD[3.321565] → [3.321565:321583]
```
    CK_CTRL_PGDN,
```
[3.321565]
[3.321583]
```
    CK_CTRL_PGDN
```

Replacement in crawl-ref/source/items.cc at line 1840 [4.2584728]

B:BD[3.357276] → [3.357276:357337]

    snprintf( buf, sizeof buf, "  (%u%s turn%s)", s->size(),

[3.357276]

[3.357337]

    snprintf( buf, sizeof buf, "  (%lu%s turn%s)", (unsigned long) (s->size()),

Deletion in crawl-ref/source/files.cc at line 393 [4.3084589]
B:BD[4.3092840] → [4.3092840:3092917]
```
    int fmenv = 0;     // not used again until after found_stair label {dlb}
```
Replacement in crawl-ref/source/files.cc at line 751 [4.3084589]
B:BD[4.3104878] → [4.3104878:3104894]
```
    fmenv = -1;
```
[4.3104878]
[4.3104894]
```
    int fmenv = -1;
```
Replacement in crawl-ref/source/externs.h at line 608 [4.3270163]
B:BD[3.442855] → [3.442855:442874]
```
        FSOP_TEXT,
```
[3.442855]
[3.442874]
```
        FSOP_TEXT
```
Replacement in crawl-ref/source/enum.h at line 153 [4.3287960]
B:BD[3.448073] → [3.448073:448101]
```
    AI_TELEPORT    = 0x400,
```
[3.448073]
[3.448101]
```
    AI_TELEPORT    = 0x400
```
Replacement in crawl-ref/source/enum.h at line 162 [4.3287960]
B:BD[3.448183] → [3.448183:448200]
```
    AIP_HP_LOSS,
```
[3.448183]
[3.448200]
```
    AIP_HP_LOSS
```
Replacement in crawl-ref/source/enum.h at line 184 [4.3287960]
B:BD[3.448437] → [3.448437:448468]
```
    AQ_WIZMODE          = 200,
```
[3.448437]
[4.3292832]
```
    AQ_WIZMODE          = 200
```
Replacement in crawl-ref/source/enum.h at line 608 [4.3287960]
B:BD[3.448628] → [3.448628:448647]
```
    CMD_CLEAR_MAP,
```
[3.448628]
[4.3304899]
```
    CMD_CLEAR_MAP
```
Replacement in crawl-ref/source/enum.h at line 2250 [4.3287960]
B:BD[3.449484] → [3.449484:449505]
```
    OSEL_WIELD = -2,
```
[3.449484]
[3.449505]
```
    OSEL_WIELD = -2
```
Replacement in crawl-ref/source/enum.h at line 2513 [4.3287960]
B:BD[4.3358563] → [4.3358563:3358610]
```
    SPMSL_POISONED_II,                 //    4
```
[4.3358563]
[4.3358610]
```
    SPMSL_POISONED_II                  //    4
```
Replacement in crawl-ref/source/enum.h at line 2865 [4.3287960]
B:BD[3.449560] → [3.449560:449585]
```
    SS_BACKWARD     = 1,
```
[3.449560]
[3.449585]
```
    SS_BACKWARD     = 1
```
Replacement in crawl-ref/source/direct.cc at line 68 [4.3697945]
B:BD[3.451372] → [3.451372:451399]
```
    LOS_NONE     = 0xFFFF,
```
[3.451372]
[3.451399]
```
    LOS_NONE     = 0xFFFF
```

Replacement in crawl-ref/source/direct.cc at line 481 [4.3697945]

B:BD[3.454696] → [3.454696:454772]

                            int dir = keyin == ';' || keyin == '/'? -1 : 1;

[3.454696]

[3.454772]

                            dir = keyin == ';' || keyin == '/'? -1 : 1;

Replacement in crawl-ref/source/direct.cc at line 502 [4.3697945]

B:BD[4.3708925] → [3.455512:455572]

                            int dir = keyin == '-'? -1 : 1;

[4.3708925]

[3.455572]

                            dir = keyin == '-'? -1 : 1;

Replacement in crawl-ref/source/defines.h at line 155 [4.3982910]

B:BD[3.478590] → [3.478590:478666]

        CHATTR_COLMASK = 0xF00, // Mask with this to get extra colour info.

[3.478590]

[4.3986350]

        CHATTR_COLMASK = 0xF00 // Mask with this to get extra colour info.

Insertion in crawl-ref/source/Crawl.xcodeproj/project.pbxproj at line 690 [2.216]

[2.59899]

				GCC_WARN_CHECK_SWITCH_STATEMENTS = YES;
				GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES;
				GCC_WARN_MISSING_PARENTHESES = YES;
				GCC_WARN_PEDANTIC = YES;
				GCC_WARN_SHADOW = NO;
				GCC_WARN_SIGN_COMPARE = YES;
				GCC_WARN_TYPECHECK_CALLS_TO_PRINTF = YES;

Insertion in crawl-ref/source/Crawl.xcodeproj/project.pbxproj at line 698 [2.216]
[2.59939]
[2.59939]
```
				GCC_WARN_UNUSED_FUNCTION = YES;
```
Insertion in crawl-ref/source/Crawl.xcodeproj/project.pbxproj at line 700 [2.216]
[2.59972]
[2.59972]
```
				GCC_WARN_UNUSED_VALUE = YES;
```

Add a metric ton of compiler warnings to the Xcode project, and clean

Dependencies

In channels

Change contents

Replacement in crawl-ref/source/travel.h at line 117 [3.29464]

Replacement in crawl-ref/source/travel.h at line 126 [3.29464]

Replacement in crawl-ref/source/travel.cc at line 43 [3.39949]

Insertion in crawl-ref/source/travel.cc at line 902 [3.39949]

Replacement in crawl-ref/source/travel.cc at line 982 [3.39949]

Replacement in crawl-ref/source/travel.cc at line 1081 [3.39949]

Replacement in crawl-ref/source/stash.cc at line 415 [3.147324]

Insertion in crawl-ref/source/stash.cc at line 470 [3.147324]

Replacement in crawl-ref/source/stash.cc at line 479 [3.147324]

Replacement in crawl-ref/source/stash.cc at line 515 [3.147324]

Replacement in crawl-ref/source/spl-util.cc at line 77 [4.245665]

Replacement in crawl-ref/source/newgame.cc at line 3209 [4.1132300]

Replacement in crawl-ref/source/mutation.cc at line 1441 [4.1263003]

Replacement in crawl-ref/source/mutation.cc at line 1459 [4.1263003]

Replacement in crawl-ref/source/mutation.cc at line 1481 [4.1263003]

Replacement in crawl-ref/source/monplace.cc at line 121 [4.1641732]

Replacement in crawl-ref/source/menu.h at line 129 [3.255942]

Replacement in crawl-ref/source/menu.h at line 145 [3.255942]

Replacement in crawl-ref/source/libutil.h at line 97 [4.2493627]

Replacement in crawl-ref/source/items.cc at line 1840 [4.2584728]

Deletion in crawl-ref/source/files.cc at line 393 [4.3084589]

Replacement in crawl-ref/source/files.cc at line 751 [4.3084589]

Replacement in crawl-ref/source/externs.h at line 608 [4.3270163]

Replacement in crawl-ref/source/enum.h at line 153 [4.3287960]

Replacement in crawl-ref/source/enum.h at line 162 [4.3287960]

Replacement in crawl-ref/source/enum.h at line 184 [4.3287960]

Replacement in crawl-ref/source/enum.h at line 608 [4.3287960]

Replacement in crawl-ref/source/enum.h at line 2250 [4.3287960]

Replacement in crawl-ref/source/enum.h at line 2513 [4.3287960]

Replacement in crawl-ref/source/enum.h at line 2865 [4.3287960]

Replacement in crawl-ref/source/direct.cc at line 68 [4.3697945]

Replacement in crawl-ref/source/direct.cc at line 481 [4.3697945]

Replacement in crawl-ref/source/direct.cc at line 502 [4.3697945]

Replacement in crawl-ref/source/defines.h at line 155 [4.3982910]

Insertion in crawl-ref/source/Crawl.xcodeproj/project.pbxproj at line 690 [2.216]

Insertion in crawl-ref/source/Crawl.xcodeproj/project.pbxproj at line 698 [2.216]

Insertion in crawl-ref/source/Crawl.xcodeproj/project.pbxproj at line 700 [2.216]