finchie/l10n_embed - Change BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC

Move interaction constructors back to individual types

Reverting earlier change, interactions still carry a reference to the environment but are constructed by calling Self::new() directly.

Created by finchie on August 8, 2025

BC22FLOQBQ6EOUSCN6THUXQDZYZPWSF6QJX5Z6WA4GYFR6BK4DZAC

Dependencies

In channels

main

Change contents

Replacement in l10n_embed_interaction/src/prompt/select.rs at line 15 [4.109]

B:BD[3.207] → [2.70:217]

    pub(crate) fn new_from_environment<L: Localize>(
        environment: &'environment InteractionEnvironment,
        prompt: L,
    ) -> Self {

[3.207]

[2.217]

    pub fn new<L: Localize>(environment: &'environment InteractionEnvironment, prompt: L) -> Self {

Replacement in l10n_embed_interaction/src/prompt/password.rs at line 20 [4.2012]
B:BD[3.829] → [2.558:611]
```
    pub(crate) fn new_from_environment<L: Localize>(
```
[3.829]
[2.611]
```
    pub fn new<L: Localize>(
```
Replacement in l10n_embed_interaction/src/prompt/input.rs at line 15 [4.6488]
B:BD[3.2129] → [2.1314:1367]
```
    pub(crate) fn new_from_environment<L: Localize>(
```
[3.2129]
[2.1367]
```
    pub fn new<L: Localize>(
```

Replacement in l10n_embed_interaction/src/prompt/confirm.rs at line 15 [4.8140]

B:BD[3.2760] → [2.1800:1947]

    pub(crate) fn new_from_environment<L: Localize>(
        environment: &'environment InteractionEnvironment,
        prompt: L,
    ) -> Self {

[3.2760]

[2.1947]

    pub fn new<L: Localize>(environment: &'environment InteractionEnvironment, prompt: L) -> Self {

Replacement in l10n_embed_interaction/src/progress.rs at line 18 [5.513]
B:BD[3.3142] → [3.3142:3195]
```
    pub(crate) fn new_from_environment<L: Localize>(
```
[3.3142]
[3.3195]
```
    pub fn new<L: Localize>(
```

Deletion in l10n_embed_interaction/src/lib.rs at line 55 [4.9269]

∅:D[6.602] → [3.3796:3949]

B:BD[3.3796] → [3.3796:3949]

B:BD[3.3949] → [2.2296:2530]

∅:D[2.2530] → [3.4104:4138]

B:BD[3.4104] → [3.4104:4138]

B:BD[3.4138] → [2.2531:2607]

∅:D[2.2607] → [3.4219:4260]

B:BD[3.4219] → [3.4219:4260]

B:BD[3.4299] → [3.4299:4418]

B:BD[3.4418] → [2.2608:2864]

    }
}
macro_rules! impl_constructor {
    ($prompt_name:ident, $prompt_type:ident) => {
        impl InteractionEnvironment {
            #[must_use]
            pub fn $prompt_name<'environment, L: Localize>(
                &'environment self,
                prompt: L,
            ) -> $prompt_type<'environment> {
                $prompt_type::new_from_environment(self, prompt)
            }
        }
    };
}
// Create constructors on InteractionEnvironment for different prompt types
impl_constructor!(new_confirm, Confirm);
impl_constructor!(new_input, Input);
impl_constructor!(new_password, Password);
impl_constructor!(new_select, Select);
// Special implementation for text editor as the signature is different
impl InteractionEnvironment {
    pub fn new_editor<'environment>(&'environment self, extension: &str) -> Editor<'environment> {
        Editor::new_from_environment(self, extension)

Deletion in l10n_embed_interaction/src/lib.rs at line 57 [4.9269]

∅:D[2.2872] → [3.4418:4732]

B:BD[3.4418] → [3.4418:4732]

∅:D[7.151] → [4.10328:10336]

∅:D[3.4732] → [4.10328:10336]

B:BD[4.10328] → [4.10328:10336]


// Special implementation for progress bars as the signature is different
impl InteractionEnvironment {
    pub fn new_progress<'environment, L: Localize>(
        &'environment self,
        message: L,
        length: u64,
    ) -> ProgressBar {
        ProgressBar::new_from_environment(self, message, length)
    }
}

Replacement in l10n_embed_interaction/src/editor.rs at line 10 [4.10371]

B:BD[3.4865] → [2.2929:3069]

    pub(crate) fn new_from_environment(
        environment: &'environment InteractionEnvironment,
        extension: &str,
    ) -> Self {

[3.4865]

[3.4965]

    pub fn new(environment: &'environment InteractionEnvironment, extension: &str) -> Self {