finchie/pijul_extension - Change TWEUQ64DU5ZXAEG67GQSS7GDEZ2O2JR5352WRVIIUK5J7ZOMO5QAC

Move threadsafe function builder logic into function-specific modules

Only affects initialize_source_control for now, but should help establish the pattern that modules own the logic to build their functions.

Created by finchie yesterday at 00:46

TWEUQ64DU5ZXAEG67GQSS7GDEZ2O2JR5352WRVIIUK5J7ZOMO5QAC

Dependencies

In channels

main

Change contents

Replacement in editors/vscode/src/event_loop/threadsafe_function.rs at line 13 [2.772]

B:BD[2.1076] → [4.204:491]

            initialize_source_control: env
                .create_function_from_closure(
                    "initialize_source_control",
                    initialize_source_control::callback,
                )?
                .build_threadsafe_function()
                .build()?,

[2.1076]

[3.968]

            initialize_source_control: initialize_source_control::build(env)?,

Replacement in editors/vscode/src/event_loop/threadsafe_function.rs at line 69 [2.772]

B:BD[4.1673] → [4.1673:1770]

    pub fn callback(function_call_context: FunctionCallContext) -> Result<Return, napi::Error> {

[4.1673]

[4.1770]

    pub fn build(env: &napi::Env) -> Result<Prototype, napi::Error> {
        env.create_function_from_closure("initialize_source_control", callback)?
            .build_threadsafe_function()
            .build()
    }
    fn callback(function_call_context: FunctionCallContext) -> Result<Return, napi::Error> {