fne/bga-pi - Change 2M6VZKEPY2DK3FFFEPWVXYCKISVY4UU3MQWHVZJ7APKDKIRDW5OAC

Improve notification timing; add cleanBoard notification to slow down mini-game teardown/setup. Refs #39

Created by Fabian Neumann on February 20, 2018

2M6VZKEPY2DK3FFFEPWVXYCKISVY4UU3MQWHVZJ7APKDKIRDW5OAC

Dependencies

In channels

main

81b54c6735b6845b7c95ed4f70f9f353e3fad2b8

Change contents

Insertion in pi.game.php at line 409 [6.1093769]

[2.625]

    }
    /**
     * Send a blank 'animate' notification to all players. Used to delay UI.
     */
    function notifyAnimate()
    {
        self::notifyAllPlayers("animate", "", array());

Insertion in pi.game.php at line 617 [6.1093769]
[7.80950]
[8.3014]
```
        $this->notifyAnimate();
```
Deletion in pi.game.php at line 848 [6.1093769]
∅:D[5.60] → [9.1175:1256]
B:BD[9.1175] → [9.1175:1256]
```
                    $this->tokens->getTokensOfTypeInLocation("cube_{$color}_%"),
```

Replacement in pi.game.php at line 849 [6.1093769]

B:BD[9.1337] → [10.1884:2041]

                    $this->tokens->getTokensOfTypeInLocation("pi_{$color}_%"),
                    $this->tokens->getTokensOfTypeInLocation("vp_{$color}_%")

[9.1337]

[5.61]

                    $this->tokens->getTokensOfTypeInLocation("vp_{$color}_%"),
                    $this->tokens->getTokensOfTypeInLocation("cube_{$color}_%"),
                    $this->tokens->getTokensOfTypeInLocation("pi_{$color}_%")

Insertion in pi.game.php at line 854 [6.1093769]
[9.1449]
[11.301]
```
            $this->notifyAnimate();
```

Replacement in pi.game.php at line 1019 [6.1093769]

B:BD[12.15119] → [13.1008:1066]

        $this->gamestate->nextState();  // start minigame

[12.15119]

[13.1066]


        // Trigger clean up in frontend. Sending only tokens that are to be
        // moved away.
        self::notifyAllPlayers("cleanBoard", "", array(
            'tokens' => array_values(array_merge(
                $this->tokens->getTokensInLocation('box'),
                $this->tokens->getTokensInLocation('offtable'),
                $this->tokens->getTokensInLocation('cubes_%'),
                $this->tokens->getTokensInLocation('discs_%')
            ))
        ));
        $this->notifyAnimate();
        $this->gamestate->nextState(); // start minigame

Insertion in pi.js at line 707 [6.1082103]

[4.630]


            dojo.subscribe('cleanBoard', this, "notif_cleanBoard");
            this.notifqueue.setSynchronous('cleanBoard', 1000);

Replacement in pi.js at line 722 [6.1082103]

B:BD[7.82555] → [14.0:66]

B:BD[14.66] → [3.0:65]

            dojo.subscribe('playerFailed', this, function () {});
            this.notifqueue.setSynchronous('playerFailed', 800);

[7.82555]

[14.132]

            this.notifqueue.setSynchronous('playerFailed', 1000);

Replacement in pi.js at line 725 [6.1082103]

B:BD[7.82623] → [14.134:197]

            this.notifqueue.setSynchronous('placeToken', 300);

[7.82623]

            this.notifqueue.setSynchronous('placeToken', 500);

Replacement in pi.js at line 727 [6.1082103]

B:BD[7.82693] → [14.198:262]

            this.notifqueue.setSynchronous('placeTokens', 300);

[7.82693]

            this.notifqueue.setSynchronous('placeTokens', 500);

Replacement in pi.js at line 730 [6.1082103]

B:BD[15.6201] → [3.66:131]

            this.notifqueue.setSynchronous('playerSolved', 800);

[15.6201]

[16.4358]

            this.notifqueue.setSynchronous('playerSolved', 1000);
            this.notifqueue.setSynchronous('animate', 1000);
        },
        notif_cleanBoard: function(notif) {
            this.playerHand.removeAll();
            this.evidenceDisplay.removeAll();
            this.evidenceDiscard.removeAll();
            for (player_id in this.playerDisplays) {
                this.playerDisplays[player_id].removeAll();
            }
            this.tiles.removeAll(); // from stock
            dojo.query('.locslot > div.stockitem').forEach(function (node) { dojo.destroy(node) }); // visually
            window.setTimeout(dojo.hitch(this, function () {
                this.placeTokens(notif.args.tokens, null, 10);
            }), 300);