fne/bga-pi - Change JFOUIO6VCPH5VI357A4ZMRFTHVPBMOVIASBVOUGM2WJS6FVRUGCQC

Improve validateCaseSelection

Created by Fabian Neumann on February 8, 2018

JFOUIO6VCPH5VI357A4ZMRFTHVPBMOVIASBVOUGM2WJS6FVRUGCQC

Dependencies

In channels

81b54c6735b6845b7c95ed4f70f9f353e3fad2b8

main

Change contents

Replacement in pi.js at line 212 [5.1082103]

B:BD[4.8806] → [3.254:364]

                    ehdls.push(dojo.connect(this.tiles, 'onChangeSelection', this, 'validateCaseSelection'));

[4.8806]

[4.8904]

                    ehdls.push(dojo.connect(this.tiles, 'onChangeSelection', this, 'onCaseSelectionChanged'));

Insertion in pi.js at line 459 [5.1082103]

[6.82553]

[7.3986]

        /**
         * Validate the case selection.
         *
         * Opts has (optional) keys:
         *
         * - `strict`: validate, i.e. check that *exactly* 3 tiles are chosen
         * - `clicked_id`: the id of the stock item that was just checked, and
         *   wants to be validated (and potentially unselected)
         */

Deletion in pi.js at line 473 [5.1082103]

B:BD[4.9363] → [4.9363:9718]

            if (opts.strict && selectedTiles.length != 3) {
                this.showMessage(_("You must select exactly 3 tiles."), "error");
                return false;
            } else if (selectedTiles.length > 3) {
                this.showMessage(_("You must not select more than 3 tiles."), "error");
                return false;
            }

Replacement in pi.js at line 474 [5.1082103]

B:BD[4.9803] → [4.9803:9872]

            selectedTiles.forEach(dojo.hitch(this, function (tile) {

[4.9803]

[4.9872]

            for (var i in selectedTiles) {
                var tile = selectedTiles[i];

Replacement in pi.js at line 481 [5.1082103]

B:BD[4.10468] → [2.2:56]

                    this.tiles.unselectItem(tile.id);

[4.10468]

                    if (opts.clicked_id) this.tiles.unselectItem(opts.clicked_id);

Replacement in pi.js at line 487 [5.1082103]

B:BD[2.254] → [2.254:308]

                    this.tiles.unselectItem(tile.id);

[2.254]

[2.308]

                    if (opts.clicked_id) this.tiles.unselectItem(opts.clicked_id);

Replacement in pi.js at line 491 [5.1082103]

∅:D[2.431] → [4.10520:10537]

B:BD[4.10520] → [4.10520:10537]

            }));

[2.431]

[4.10537]

            }
            if (opts.strict && selectedTiles.length != 3) {
                this.showMessage(_("You must select exactly 3 tiles."), "error");
                return false;
            }

Replacement in pi.js at line 549 [5.1082103]

B:BD[4.10624] → [4.10624:10739]

        onCaseSelectionChanged: function (control_name) {
            this.validateCaseSelection({strict: false});

[4.10624]

[5.1090439]

        onCaseSelectionChanged: function (control_name, id) {
            this.validateCaseSelection({clicked_id: id, strict: false});