grahamc/hydra - Change BIVZGPUTQ2C7X6NJQMVIDDO2OYNO4R3GROGQAWBVNSK2HSZ3REOQC

Optimise clickable rows

Set a click handler on the table instead of on every row. This should be faster on large tables. Also, it's easier to use: you just set the clickable-rows class on the table, and the row-link class on the <a> element that contains the "main" link of the row.

Created by Eelco Dolstra on February 22, 2013

BIVZGPUTQ2C7X6NJQMVIDDO2OYNO4R3GROGQAWBVNSK2HSZ3REOQC

Dependencies

In channels

main

upstream

Change contents

Replacement in src/root/build.tt at line 18 [6.7350]

B:BD[4.1990] → [5.11583:11649]

  <table class="tablesorter table table-striped table-condensed">

[4.1990]

[5.11649]

  <table class="tablesorter table table-striped table-condensed clickable-rows">

Replacement in src/root/build.tt at line 27 [6.7350]

B:BD[7.73] → [3.0:82]

          <tr [% IF has_log %] onclick="window.location = '[% log %]'" [% END %]>

[7.73]

[7.173]

          <tr>

Replacement in src/root/build.tt at line 56 [6.7350]

B:BD[7.1378] → [7.1378:1452]

              [%%] [%+ IF has_log; INCLUDE renderLogLinks url=log; END %]

[7.1378]

[7.1452]

              [%%] [%+ IF has_log; INCLUDE renderLogLinks url=log inRow=1; END %]

Replacement in src/root/channel-contents.tt at line 35 [8.3375]

B:BD[8.3688] → [9.2400:2464]

<table class="tablesorter table table-condensed table-striped">

[8.3688]

[10.21299]

<table class="tablesorter table table-condensed table-striped clickable-rows">

Replacement in src/root/channel-contents.tt at line 53 [8.3375]
B:BD[8.3977] → [3.83:134]
```
      <tr onclick="window.location = '[% uri %]'">
```
[8.3977]
[11.605]
```
      <tr>
```

Replacement in src/root/channel-contents.tt at line 55 [8.3375]

B:BD[11.678] → [11.678:775]

        <td><a href="[% uri %]"><tt>[% b.get_column('releasename') || b.nixname %]</tt></a></td>

[11.678]

[11.775]

        <td><a class="row-link" href="[% uri %]"><tt>[% b.get_column('releasename') || b.nixname %]</tt></a></td>

Replacement in src/root/common.tt at line 27 [13.2803]

B:BD[12.513] → [12.513:586]

<a href="[% c.uri_for('/project' project) %]"><tt>[% project %]</tt></a>

[12.513]

[12.586]

<a [% IF inRow %]class="row-link"[% END %] href="[% c.uri_for('/project' project) %]"><tt>[% project %]</tt></a>

Replacement in src/root/common.tt at line 32 [13.2803]

B:BD[12.621] → [12.621:699]

<a href="[% c.uri_for('/jobset' project jobset) %]"><tt>[% jobset %]</tt></a>

[12.621]

[12.699]

<a [% IF inRow %]class="row-link"[% END %] href="[% c.uri_for('/jobset' project jobset) %]"><tt>[% jobset %]</tt></a>

Replacement in src/root/common.tt at line 65 [13.2803]

B:BD[12.1331] → [3.135:230]

  <table class="table table-striped table-condensed [% IF !unsortable %]tablesorter[% END %]">

[12.1331]

[14.767]

  <table class="table table-striped table-condensed clickable-rows [% IF !unsortable %]tablesorter[% END %]">

Replacement in src/root/common.tt at line 98 [13.2803]

B:BD[12.1410] → [3.231:339]

    <tr onclick="if(event.which == 2) return true; window.location = '[% c.uri_for('/build' build.id) %]'">

[12.1410]

[12.1832]

    <tr>

Replacement in src/root/common.tt at line 107 [13.2803]

B:BD[12.2211] → [12.2211:2290]

      <td><a href="[% c.uri_for('/build' build.id) %]">[% build.id %]</a></td>

[12.2211]

[12.2290]

      <td><a class="row-link" href="[% c.uri_for('/build' build.id) %]">[% build.id %]</a></td>

Replacement in src/root/common.tt at line 385 [13.2803]

B:BD[12.9697] → [12.9697:9763]

  <table class="tablesorter table table-condensed table-striped">

[12.9697]

[12.9763]

  <table class="tablesorter table table-condensed table-striped clickable-rows">

Replacement in src/root/common.tt at line 401 [13.2803]
B:BD[15.4754] → [3.340:394]
```
        <tr onclick="window.location = '[% link %]'">
```
[15.4754]
[16.763]
```
        <tr>
```

Replacement in src/root/common.tt at line 405 [13.2803]

∅:D[17.3347] → [18.277:335]

B:BD[12.10056] → [18.277:335]

          <td><a href="[% link %]">[% eval.id %]</a></td>

[17.3347]

[18.335]

          <td><a class="row-link" href="[% link %]">[% eval.id %]</a></td>

Replacement in src/root/common.tt at line 443 [13.2803]

∅:D[12.11401] → [19.1435:1546]

B:BD[19.1435] → [19.1435:1546]

(<a href="[% url %]">log</a>, <a href="[% "$url/raw" %]">raw</a>, <a href="[% "$url/tail-reload" %]">tail</a>)

[12.11401]

[2.210]

(<a [% IF inRow %]class="row-link"[% END %] href="[% url %]">log</a>, <a href="[% "$url/raw" %]">raw</a>, <a href="[% "$url/tail-reload" %]">tail</a>)

Insertion in src/root/layout.tt at line 75 [6.11219]

[20.111]

[21.1601]

          $("table.clickable-rows").click(function(event) {
              if ($(event.target).closest("a").length) return;
              link = $(event.target).parents("tr").find("a.row-link");
              if (link.length == 1)
                window.location = link.attr("href");
          });

Replacement in src/root/overview.tt at line 18 [22.19073]

B:BD[22.19493] → [9.7862:7926]

<table class="tablesorter table table-condensed table-striped">

[22.19493]

[22.19521]

<table class="tablesorter table table-condensed table-striped clickable-rows">

Replacement in src/root/overview.tt at line 28 [22.19073]

B:BD[22.19668] → [3.537:611]

∅:D[3.611] → [23.0:172]

B:BD[22.19807] → [23.0:172]

    <tr onclick="window.location = '[% c.uri_for('/project' p.name) %]'">
      <td><span class="[% IF !p.enabled %]disabled-project[% END %] [%+ IF p.hidden %]hidden-project[% END %]">[% INCLUDE renderProjectName project = p.name %]</span></td>

[22.19668]

[22.19871]

    <tr>
      <td><span class="[% IF !p.enabled %]disabled-project[% END %] [%+ IF p.hidden %]hidden-project[% END %]">[% INCLUDE renderProjectName project=p.name inRow=1 %]</span></td>

Replacement in src/root/project.tt at line 17 [25.1667]

B:BD[10.33135] → [24.2955:3025]

      <table class="tablesorter table table-striped table-condensed">

[10.33135]

[24.3025]

      <table class="tablesorter table table-striped table-condensed clickable-rows">

Replacement in src/root/project.tt at line 30 [25.1667]

B:BD[24.3332] → [3.612:706]

            <tr onclick="window.location = '[% c.uri_for('/jobset' project.name j.name) %]'">

[24.3332]

[24.3499]

            <tr>

Replacement in src/root/project.tt at line 42 [25.1667]

B:BD[24.4089] → [23.173:372]

              <td><span class="[% IF !j.enabled %]disabled-jobset[% END %] [%+ IF j.hidden %]hidden-jobset[% END %]">[% INCLUDE renderJobsetName project = project.name jobset = j.name %]</span></td>

[24.4089]

[24.4182]

              <td><span class="[% IF !j.enabled %]disabled-jobset[% END %] [%+ IF j.hidden %]hidden-jobset[% END %]">[% INCLUDE renderJobsetName project=project.name jobset=j.name inRow=1 %]</span></td>

Replacement in src/root/project.tt at line 122 [25.1667]

B:BD[26.3197] → [27.479:547]

    <table class="tablesorter table table-condensed table-striped">

[26.3197]

[27.547]

    <table class="tablesorter table table-condensed table-striped clickable-rows">

Replacement in src/root/project.tt at line 131 [25.1667]

B:BD[27.707] → [27.707:778]

B:BD[27.778] → [3.707:763]

∅:D[3.763] → [27.852:926]

B:BD[27.852] → [27.852:926]

          [% link = c.uri_for('/release' project.name release.name) %]
          <tr onclick="window.location = '[% link %]'">
            <td><a href="[% link %]"><tt>[% release.name %]</tt></a></td>

[27.707]

[27.926]

          <tr>
            <td><a class="row-link" href="[% c.uri_for('/release' project.name release.name) %]"><tt>[% release.name %]</tt></a></td>

Replacement in src/root/view.tt at line 12 [28.8435]

B:BD[28.8595] → [9.15948:16012]

<table class="tablesorter table table-condensed table-striped">

[28.8595]

[28.8623]

<table class="tablesorter table table-condensed table-striped clickable-rows">

Replacement in src/root/view.tt at line 27 [28.8435]

B:BD[29.11681] → [29.11681:11752]

B:BD[29.11752] → [3.764:816]

      [% link = c.uri_for('/view' project.name view.name result.id) %]
      <tr onclick="window.location = '[% link %]'">

[29.11681]

[28.8957]

      <tr>

Replacement in src/root/view.tt at line 37 [28.8435]

B:BD[28.9292] → [29.11876:11934]

        <td><a href="[% link %]">[% result.id %]</a></td>

[28.9292]

[28.9326]

        <td><a class="row-link" href="[% c.uri_for('/view' project.name view.name result.id) %]">[% result.id %]</a></td>