grahamc/hydra2 - Change F6UHDFJXXDNY5MHXOTH6S33MCSE7RXMQI3ZYJESK4QESFDT4FLLQC

Refactor code

Extract the conditions before the loop, as they do not change due to channel definition.

Created by Nikola Knezevic on March 26, 2020

F6UHDFJXXDNY5MHXOTH6S33MCSE7RXMQI3ZYJESK4QESFDT4FLLQC

Dependencies

[2] KUORZDSR56BT6GF3E4SM6JJ3IH5UIFYAEIQ3I3AX367T63Q4QVQAC

In channels

main

Change contents

Insertion in src/lib/Hydra/Plugin/SlackNotification.pm at line 90 [2.69]

[2.668]

        my $jobName = showJobName $b;
        my $buildStatus = $b->buildstatus;
        my $cancelledOrAborted = $buildStatus == 4 || $buildStatus == 3;

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 95 [2.69]

B:BD[2.714] → [2.714:752]

        my $jobName = showJobName $b;

[2.714]

[2.752]

        my $sameAsPrevious = defined $prevBuild && ($buildStatus == $prevBuild->buildstatus);

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 102 [2.69]

B:BD[2.895] → [2.895:1042]

            # If build is cancelled or aborted, do not send email.
            next if ! $force && ($b->buildstatus == 4 || $b->buildstatus == 3);

[2.895]

[2.1042]

            # If build is cancelled or aborted, do not send Slack notification.
            next if ! $force && $cancelledOrAborted;

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 106 [2.69]

B:BD[2.1121] → [2.1121:1277]

            # with same buildstatus, do not send email.
            next if ! $force && defined $prevBuild && ($b->buildstatus == $prevBuild->buildstatus);

[2.1121]

[2.1277]

            # with same buildstatus, do not send Slack notification.
            next if ! $force && $sameAsPrevious;