grahamc/hydra2 - Change XNXX4WCQ7KIP24TIF6KQVZLCHM4R25MSSL4IFLFHNUBW5FQSTPWQC

api-test: clean up, use subtests

Created by Graham Christensen on April 28, 2021

XNXX4WCQ7KIP24TIF6KQVZLCHM4R25MSSL4IFLFHNUBW5FQSTPWQC

Dependencies

In channels

main

Change contents

Replacement in t/api-test.t at line 53 [3.36450]

B:BD[3.36937] → [4.31:150]

B:BD[4.150] → [5.0:58]

my $result = request_json({ uri => "/login", method => "POST", data => { username => "root", password => "wrong" } });
is($result->code(), 403, "Incorrect password rejected.");

[3.36937]

[4.210]

subtest "login" => sub {
    subtest "bad password" => sub {
        my $result = request_json({ uri => "/login", method => "POST", data => { username => "root", password => "wrong" } });
        is($result->code(), 403, "Incorrect password rejected.");
    };

Replacement in t/api-test.t at line 59 [3.36450]

∅:D[4.211] → [3.36937:37057]

B:BD[3.36937] → [3.36937:37057]

my $result = request_json({ uri => "/login", method => "POST", data => { username => "root", password => "foobar" } });

[4.211]

[3.37057]

    my $result = request_json({ uri => "/login", method => "POST", data => { username => "root", password => "foobar" } });

Replacement in t/api-test.t at line 61 [3.36450]
B:BD[3.37058] → [3.37058:37102]
```
my $user = decode_json($result->content());
```
[3.37058]
[3.37102]
```
    my $user = decode_json($result->content());
```

Replacement in t/api-test.t at line 63 [3.36450]

B:BD[3.37103] → [5.59:188]

∅:D[5.188] → [6.1006:1047]

B:BD[7.2165] → [6.1006:1047]

is($user->{username}, "root", "The root user is named root");
is($user->{userroles}->[0], "admin", "The root user is an admin");
$cookie = $result->header("set-cookie");

[3.37103]

[3.37244]

    is($user->{username}, "root", "The root user is named root");
    is($user->{userroles}->[0], "admin", "The root user is an admin");
    $cookie = $result->header("set-cookie");

Replacement in t/api-test.t at line 67 [3.36450]

B:BD[3.37245] → [3.37245:37319]

B:BD[3.37319] → [5.189:324]

$user = decode_json(request_json({ uri => "/current-user" })->content());
is($user->{username}, "root", "The current user is named root");
is($user->{userroles}->[0], "admin", "The current user is an admin");

[3.37245]

[3.37466]

    $user = decode_json(request_json({ uri => "/current-user" })->content());
    is($user->{username}, "root", "The current user is named root");
    is($user->{userroles}->[0], "admin", "The current user is an admin");
};

Replacement in t/api-test.t at line 72 [3.36450]

B:BD[3.37467] → [5.325:423]

is(request_json({ uri => '/project/sample' })->code(), 404, "Non-existent projects don't exist");

[3.37467]

[3.37567]

subtest "projects" => sub {
    is(request_json({ uri => '/project/sample' })->code(), 404, "Non-existent projects don't exist");

Replacement in t/api-test.t at line 75 [3.36450]

B:BD[3.37568] → [8.0:141]

B:BD[8.141] → [5.424:486]

$result = request_json({ uri => '/project/sample', method => 'PUT', data => { displayname => "Sample", enabled => "1", visible => "1", } });
is($result->code(), 201, "PUTting a new project creates it");

[3.37568]

[3.37757]

    my $result = request_json({ uri => '/project/sample', method => 'PUT', data => { displayname => "Sample", enabled => "1", visible => "1", } });
    is($result->code(), 201, "PUTting a new project creates it");

Replacement in t/api-test.t at line 78 [3.36450]

B:BD[3.37758] → [3.37758:37840]

my $project = decode_json(request_json({ uri => '/project/sample' })->content());

[3.37758]

[3.37840]

    my $project = decode_json(request_json({ uri => '/project/sample' })->content());

Replacement in t/api-test.t at line 80 [3.36450]

B:BD[3.37841] → [3.37841:37907]

ok((not @{$project->{jobsets}}), "A new project has no jobsets");

[3.37841]

[3.37907]

    ok((not @{$project->{jobsets}}), "A new project has no jobsets");
};

Replacement in t/api-test.t at line 83 [3.36450]

B:BD[3.37908] → [2.0:275]

∅:D[2.275] → [5.487:548]

B:BD[6.1317] → [5.487:548]

$result = request_json({ uri => '/jobset/sample/default', method => 'PUT', data => { nixexprpath => "default.nix", nixexprinput => "my-src", jobsetinputs => { "my-src" => { type => "path", value => $jobsetdir } }, enabled => "1", visible => "1", checkinterval => "3600"} });
is($result->code(), 201, "PUTting a new jobset creates it");

[3.37908]

[3.38220]

subtest "jobsets" => sub {
    my $result = request_json({ uri => '/jobset/sample/default', method => 'PUT', data => { nixexprpath => "default.nix", nixexprinput => "my-src", jobsetinputs => { "my-src" => { type => "path", value => $jobsetdir } }, enabled => "1", visible => "1", checkinterval => "3600"} });
    is($result->code(), 201, "PUTting a new jobset creates it");

Replacement in t/api-test.t at line 87 [3.36450]

B:BD[3.38221] → [3.38221:38309]

my $jobset = decode_json(request_json({ uri => '/jobset/sample/default' })->content());

[3.38221]

[3.38309]

    my $jobset = decode_json(request_json({ uri => '/jobset/sample/default' })->content());

Replacement in t/api-test.t at line 89 [3.36450]

B:BD[3.38310] → [9.387:474]

ok(exists $jobset->{jobsetinputs}->{"my-src"}, "The new jobset has a 'my-src' input");

[3.38310]

[10.228]

    ok(exists $jobset->{jobsetinputs}->{"my-src"}, "The new jobset has a 'my-src' input");

Replacement in t/api-test.t at line 91 [3.36450]

B:BD[10.229] → [5.549:667]

is($jobset->{jobsetinputs}->{"my-src"}->{"jobsetinputalts"}->[0], $jobsetdir, "The 'my-src' input is in $jobsetdir");

[10.229]

[10.244]

    is($jobset->{jobsetinputs}->{"my-src"}->{"jobsetinputalts"}->[0], $jobsetdir, "The 'my-src' input is in $jobsetdir");
};

Replacement in t/api-test.t at line 94 [3.36450]

B:BD[10.245] → [6.1439:1558]

ok(evalSucceeds($db->resultset('Jobsets')->find({ name => 'default' })), "Evaluating should exit with return code 0");

[10.245]

[6.1558]

subtest "evaluation" => sub {
    subtest "initial evaluaton" => sub {
        ok(evalSucceeds($db->resultset('Jobsets')->find({ name => 'default' })), "Evaluating should exit with return code 0");

Replacement in t/api-test.t at line 98 [3.36450]

∅:D[11.217] → [3.38737:38804]

∅:D[12.553] → [3.38737:38804]

∅:D[6.1559] → [3.38737:38804]

∅:D[13.2360] → [3.38737:38804]

∅:D[14.11616] → [3.38737:38804]

B:BD[3.38737] → [3.38737:38804]

B:BD[3.38804] → [5.668:723]

∅:D[5.723] → [3.38861:38939]

B:BD[3.38861] → [3.38861:38939]

B:BD[3.38939] → [5.724:799]

$result = request_json({ uri => '/jobset/sample/default/evals' });
is($result->code(), 200, "Can get evals of a jobset");
my $evals = decode_json($result->content())->{evals};
my $eval = $evals->[0];
is($eval->{hasnewbuilds}, 1, "The first eval of a jobset has new builds");

[6.1559]

[3.39016]

        my $result = request_json({ uri => '/jobset/sample/default/evals' });
        is($result->code(), 200, "Can get evals of a jobset");
        my $evals = decode_json($result->content())->{evals};
        my $eval = $evals->[0];
        is($eval->{hasnewbuilds}, 1, "The first eval of a jobset has new builds");
    };

Replacement in t/api-test.t at line 105 [3.36450]

B:BD[3.39017] → [6.1560:1775]


open(my $fh, ">>", "${jobsetdir}/default.nix") or die "didn't open?";
say $fh "\n";
close $fh;
ok(evalSucceeds($db->resultset('Jobsets')->find({ name => 'default' })), "Evaluating should exit with return code 0");

[3.39017]

[6.1775]

    subtest "second evaluation" => sub {
        open(my $fh, ">>", "${jobsetdir}/default.nix") or die "didn't open?";
        say $fh "\n";
        close $fh;
        ok(evalSucceeds($db->resultset('Jobsets')->find({ name => 'default' })), "Evaluating should exit with return code 0");

Replacement in t/api-test.t at line 111 [3.36450]

∅:D[11.293] → [3.39299:39401]

∅:D[6.1776] → [3.39299:39401]

∅:D[13.2529] → [3.39299:39401]

∅:D[14.11694] → [3.39299:39401]

B:BD[3.39299] → [3.39299:39401]

B:BD[3.39401] → [5.800:1051]

my $evals = decode_json(request_json({ uri => '/jobset/sample/default/evals' })->content())->{evals};
is(scalar(@$evals), 2, "Changing a jobset source creates the second evaluation");
isnt($evals->[0]->{jobsetevalinputs}->{"my-src"}->{revision}, $evals->[1]->{jobsetevalinputs}->{"my-src"}->{revision}, "Changing a jobset source changes its revision");

[6.1776]

[15.709]

        my $evals = decode_json(request_json({ uri => '/jobset/sample/default/evals' })->content())->{evals};
        is(scalar(@$evals), 2, "Changing a jobset source creates the second evaluation");
        isnt($evals->[0]->{jobsetevalinputs}->{"my-src"}->{revision}, $evals->[1]->{jobsetevalinputs}->{"my-src"}->{revision}, "Changing a jobset source changes its revision");

Replacement in t/api-test.t at line 115 [3.36450]

B:BD[15.710] → [16.498:599]

B:BD[16.599] → [5.1052:1168]

∅:D[5.1168] → [6.1777:1919]

B:BD[3.39798] → [6.1777:1919]

my $build = decode_json(request_json({ uri => "/build/" . $evals->[0]->{builds}->[0] })->content());
is($build->{job}, "job", "The build's job name is job");
is($build->{finished}, 0, "The build isn't finished yet");
ok($build->{buildoutputs}->{out}->{path} =~ /\/nix\/store\/[a-zA-Z0-9]{32}-job$/, "The build's outpath is in the Nix store and named 'job'");

[15.710]

[17.294]

        my $build = decode_json(request_json({ uri => "/build/" . $evals->[0]->{builds}->[0] })->content());
        is($build->{job}, "job", "The build's job name is job");
        is($build->{finished}, 0, "The build isn't finished yet");
        ok($build->{buildoutputs}->{out}->{path} =~ /\/nix\/store\/[a-zA-Z0-9]{32}-job$/, "The build's outpath is in the Nix store and named 'job'");

Insertion in t/api-test.t at line 120 [3.36450]

[17.295]

        subtest "search" => sub {
            my $search_project = decode_json(request_json({ uri => "/search/?query=sample" })->content());
            is($search_project->{projects}[0]->{name}, "sample", "Search for project 'sample' works");

Replacement in t/api-test.t at line 124 [3.36450]

B:BD[17.296] → [17.296:391]

B:BD[17.391] → [5.1169:1260]

my $search_project = decode_json(request_json({ uri => "/search/?query=sample" })->content());
is($search_project->{projects}[0]->{name}, "sample", "Search for project 'sample' works");

[17.296]

[17.484]

            my $search_build = decode_json(request_json({ uri => "/search/?query=" . $build->{buildoutputs}->{out}->{path} })->content());
            is($search_build->{builds}[0]->{buildoutputs}->{out}->{path}, $build->{buildoutputs}->{out}->{path}, "Search for builds work");
        };
    };
};

Deletion in t/api-test.t at line 130 [3.36450]

B:BD[17.485] → [17.485:612]

B:BD[17.612] → [5.1261:1389]

my $search_build = decode_json(request_json({ uri => "/search/?query=" . $build->{buildoutputs}->{out}->{path} })->content());
is($search_build->{builds}[0]->{buildoutputs}->{out}->{path}, $build->{buildoutputs}->{out}->{path}, "Search for builds work");

Replacement in t/api-test.t at line 131 [3.36450]
B:BD[6.1921] → [6.1921:1934]
```
done_testing;
```
[6.1921]
```
done_testing;
```