jaredj/glotawk - Change CBEBMHUSOH3BUSNKD2372DXTAZQBF5UPZCOYFSBPDX5J5QV5PMXQC

use keywords and abort to allow redirections in system commands to be passed through layers of functions. previously we used symbols for things that should not be shellquoted, such as redirection operators; but these were not self-evaluating, so they turned into nil after a few layers of lexpr evaluation. furthermore, the pipe symbol makes emacs forget which parentheses match which, and :pipe is clearer anyway, so we add letter-based indications of shell redirections in make-safe-shell-command, which turns out to be needed not only for system but also for reading from pipes.

Created by jaredj on September 15, 2025

CBEBMHUSOH3BUSNKD2372DXTAZQBF5UPZCOYFSBPDX5J5QV5PMXQC

Dependencies

In channels

main

Change contents

Insertion in lib.glotawk at line 137 [5.36]

[4.1272]

(defun make-safe-shell-command argv
  (let ((problem false))
    (label ((shellquote-string
             (lambda (x)
               (cond ((stringp x) (shellquote x))
                     ((eq x :pipe) "|")
                     ((eq x :gt)   ">")
                     ((eq x :gtgt) ">>")
                     ((eq x :lt)   "<")
                     ((keywordp x) (keyword-name x)) ; unquoted!
                     (true (setq problem true))))))
           (let ((words (mapcar shellquote-string argv)))
             (cond
              (problem (abort "make-safe-shell-command: could not with argv %s"
                              (repr argv)))
              (true (apply string-join " " words)))))))

Replacement in lib.glotawk at line 156 [5.36]

B:BD[6.138] → [6.138:442]

B:BD[6.442] → [2.714:766]

∅:D[2.766] → [6.497:535]

B:BD[6.497] → [6.497:535]

  (label ((shellquote-string
           (lambda (x) (cond ((stringp x) (shellquote x))
                             ((symbolp x) (sprintf "%s" x))))))
         (let* ((words (mapcar shellquote-string argv))
                (command (apply string-join " " words)))
           (cond (*show-system-command*
                  (*show-system-command* command)))
           (unsafe-system command))))

[6.138]

[4.1359]

  (let ((safe-command (apply make-safe-shell-command argv)))
    (cond (*show-system-command*
           (*show-system-command* safe-command)))
    (unsafe-system safe-command)))

Replacement in lib.glotawk at line 202 [5.36]

B:BD[7.297] → [7.297:343]

    (system "awk" script me-file '> new-file)

[7.297]

[3.2101]

    (system "awk" script me-file :gt new-file)

Insertion in first-symbols.awk at line 132 [9.17737]
[8.2976]
[8.2976]
```
    _symbol("make-safe-shell-command")
```