pcarbonn/pijul-vscode - Change 4PN3R2LY3SJGMP2HFAR7MBSFWOG633FSN2FEIQEZREDZVI4JB76QC

Fix lint/style issues

Created by GarettWithOneR on December 23, 2020

4PN3R2LY3SJGMP2HFAR7MBSFWOG633FSN2FEIQEZREDZVI4JB76QC

Dependencies

In channels

main

Change contents

Replacement in src/extension.ts at line 2 [3.106912]
B:BD[3.106975] → [4.0:37]
∅:D[4.37] → [5.19657:19691]
B:BD[3.106975] → [5.19657:19691]
```
import * as cp from "child_process";
import * as vscode from "vscode";
```
[3.106975]
[4.38]
```
import * as cp from 'child_process';
import * as vscode from 'vscode';
```
Replacement in src/extension.ts at line 6 [3.106912]
B:BD[2.26] → [2.26:61]
```
  path: string;
  version: string;
```
[2.26]
[2.61]
```
  path: string
  version: string
```
Insertion in src/extension.ts at line 10 [3.106912]
[4.210]
[2.64]
```
// TODO: Add lint rule to require function documentation
```
Replacement in src/extension.ts at line 12 [3.106912]
∅:D[2.224] → [4.210:225]
B:BD[4.210] → [4.210:225]
```
  if (!path) {
```
[2.224]
[4.225]
```
  if (path == null) {
```

Replacement in src/extension.ts at line 14 [3.106912]

B:BD[4.305] → [4.305:482]

    if (!config.get<boolean>("ignoreMissingInstallation")) {
      const selectInstallation = "Select a Pijul Executable";
      const ignore = "Don't Show this Warning Again";

[4.305]

[4.482]

    if (!(config.get<boolean>('ignoreMissingInstallation') ?? false)) {
      const selectInstallation = 'Select a Pijul Executable';
      const ignore = 'Don\'t Show this Warning Again';

Replacement in src/extension.ts at line 18 [3.106912]

B:BD[4.543] → [4.543:663]

        "No Pijul installation has been configured for use with the extension. Select one to enable Pijul integration",

[4.543]

[4.663]

        'No Pijul installation has been configured for use with the extension. Select one to enable Pijul integration',

Replacement in src/extension.ts at line 26 [3.106912]

B:BD[4.827] → [4.827:871]

        if (process.platform === "win32") {

[4.827]

[4.871]

        if (process.platform === 'win32') {

Replacement in src/extension.ts at line 28 [3.106912]
B:BD[4.897] → [4.897:929]
```
            svn: ["exe", "bat"]
```
[4.897]
[4.929]
```
            svn: ['exe', 'bat']
```

Replacement in src/extension.ts at line 40 [3.106912]

B:BD[4.1224] → [4.1224:1281]

        if (pijulInstallation && pijulInstallation[0]) {

[4.1224]

[4.1281]

        if (pijulInstallation?.[0] != null) {

Replacement in src/extension.ts at line 42 [3.106912]

B:BD[4.1336] → [4.1336:1396]

          await config.update("installationPath", exePath);

[4.1336]

[4.1396]

          await config.update('installationPath', exePath);

Replacement in src/extension.ts at line 44 [3.106912]

B:BD[4.1422] → [4.1422:1533]

          outputChannel.appendLine("Updated extension configuration to use Pijul installation at " + exePath);

[4.1422]

[4.1533]

          outputChannel.appendLine('Updated extension configuration to use Pijul installation at ' + exePath);

Replacement in src/extension.ts at line 47 [3.106912]

B:BD[4.1622] → [2.225:312]

          return Promise.reject(new Error("No executable selected in file dialogue"));

[4.1622]

[4.1640]

          return await Promise.reject(new Error('No executable selected in file dialogue'));

Replacement in src/extension.ts at line 50 [3.106912]

B:BD[4.1665] → [2.313:429]

        await config.update("ignoreMissingInstallation", true);
        return Promise.reject(new Error("Ignore"));

[4.1665]

[4.1739]

        await config.update('ignoreMissingInstallation', true);
        return await Promise.reject(new Error('Ignore'));

Replacement in src/extension.ts at line 55 [3.106912]

B:BD[4.1812] → [2.430:480]

      return Promise.reject(new Error("Ignore"));

[4.1812]

[4.1826]

      return await Promise.reject(new Error('Ignore'));

Replacement in src/extension.ts at line 59 [3.106912]

B:BD[4.1837] → [2.481:641]

  return new Promise<IPijul>((resolve, reject) => {
    const pathDefined = path || "pijul";
    const child = cp.spawn(pathDefined || "pijul", ["--version"]);

[4.1837]

[2.641]

  return await new Promise<IPijul>((resolve, reject) => {
    const pathDefined = path ?? 'pijul';
    const child = cp.spawn(pathDefined, ['--version']);

Replacement in src/extension.ts at line 63 [3.106912]

B:BD[2.675] → [2.675:935]

    child.stdout.on("data", (b: Buffer) => buffers.push(b));
    child.on("error", () => reject(new Error("Error checking version at " + path)));
    child.on("close", code => {
      if (code) {
        reject(new Error("Error checking version at " + path));

[2.675]

[2.935]


    child.stdout.on('data', (b: Buffer) => buffers.push(b));
    child.on('error', () => reject(new Error(`Error checking version at ${pathDefined}`)));
    child.on('close', code => {
      const tokens = Buffer.concat(buffers).toString('utf8').trim().split(' ');
      if (code != null || tokens[0] !== 'pijul') {
        reject(new Error(`Error checking version at ${pathDefined}`));

Replacement in src/extension.ts at line 73 [3.106912]

B:BD[2.950] → [2.950:1061]

        resolve({ path: pathDefined, version: Buffer.concat(buffers).toString("utf8").trim().split(" ")[1] });

[2.950]

[2.1061]

        resolve({ path: pathDefined, version: tokens[1] });

Replacement in src/extension.ts at line 86 [3.106912]

B:BD[5.19983] → [4.2150:2286]

∅:D[4.2286] → [5.20079:20248]

B:BD[5.20079] → [5.20079:20248]

async function _activate (_context: vscode.ExtensionContext, config: vscode.WorkspaceConfiguration, disposables: vscode.Disposable[]) {
  vscode.window.showInformationMessage("Pijul repository detected in workspace, extension has been activated.");
  console.debug("Pijul VS Code Integration Activated");

[5.19983]

[6.260]

async function _activate (_context: vscode.ExtensionContext, config: vscode.WorkspaceConfiguration, disposables: vscode.Disposable[]): Promise<void> {
  await vscode.window.showInformationMessage('Pijul repository detected in workspace, extension has been activated.');
  console.debug('Pijul VS Code Integration Activated');

Replacement in src/extension.ts at line 90 [3.106912]

B:BD[6.261] → [5.20249:20317]

  const outputChannel = vscode.window.createOutputChannel("Pijul");

[6.261]

[5.20317]

  const outputChannel = vscode.window.createOutputChannel('Pijul');

Replacement in src/extension.ts at line 92 [3.106912]

B:BD[5.20352] → [5.20352:20453]

  disposables.push(vscode.commands.registerCommand("pijul.showOutput", () => outputChannel.show()));

[5.20352]

[3.107539]

  disposables.push(vscode.commands.registerCommand('pijul.showOutput', () => outputChannel.show()));

Replacement in src/extension.ts at line 94 [3.106912]

B:BD[3.107540] → [2.1084:1151]

  const installationPath = config.get<string>("installationPath");

[3.107540]

[2.1151]

  const installationPath = config.get<string>('installationPath');

Replacement in src/extension.ts at line 98 [3.106912]
B:BD[2.1242] → [2.1242:1255]
```
  let pijul;
```
[2.1242]
[2.1255]
```
  let pijulInfo;
```

Replacement in src/extension.ts at line 101 [3.106912]

B:BD[2.1301] → [2.1301:1475]

      pijul = await checkPijulInstallation(installationPath, config, outputChannel);
      outputChannel.appendLine(`Using Pijul ${pijul.version} located at ${pijul.path}`);

[2.1301]

[2.1475]

      pijulInfo = await checkPijulInstallation(installationPath, config, outputChannel);
      outputChannel.appendLine(`Using Pijul ${pijulInfo.version} at ${pijulInfo.path}`);

Replacement in src/extension.ts at line 105 [3.106912]

B:BD[2.1532] → [2.1532:1879]

      if (err.message === "Ignore") {
        // Complete activation without finding the installation
        identifiedInstallation = true;
        return;
      } else {
        // Reset the configuration and try again
        vscode.window.showErrorMessage(`Failed to find pijul installation at ${err.message.split(" ").pop()}, resetting...`);

[2.1532]

[2.1879]

      if (err instanceof Error) {
        if (err.message === 'Ignore') {
          // Complete activation without finding the installation
          identifiedInstallation = true;
          return;
        } else {
          // Let the user know that the executable didn't work and try again
          await vscode.window.showErrorMessage(`Failed to find pijul installation at ${err.message?.split(' ')?.pop() ?? ''}, resetting...`);
        }

Insertion in src/extension.ts at line 116 [3.106912]

[2.1893]

  }
  if (pijulInfo != null) {
    // const pijul = new Pijul(pijulInfo);

Replacement in src/extension.ts at line 139 [3.106912]

B:BD[5.21077] → [5.21077:21145]

export async function activate (context: vscode.ExtensionContext) {

[5.21077]

[5.21145]

export async function activate (context: vscode.ExtensionContext): Promise<void> {

Replacement in src/extension.ts at line 149 [3.106912]

B:BD[5.21484] → [4.2343:2454]

  const config = vscode.workspace.getConfiguration("pijul");
  const enabled = config.get<boolean>("enabled");

[5.21484]

[4.2454]

  const config = vscode.workspace.getConfiguration('pijul');
  const enabled = config.get<boolean>('enabled');

Replacement in src/extension.ts at line 152 [3.106912]
B:BD[4.2455] → [4.2455:2472]
```
  if (enabled) {
```
[4.2455]
[4.2472]
```
  if (enabled ?? false) {
```
Replacement in src/extension.ts at line 163 [3.106912]
B:BD[5.21678] → [5.21678:21712]
```
export function deactivate () { }
```
[5.21678]
```
export function deactivate (): void { }
```

Replacement in src/test/suite/index.ts at line 1 [3.105009]

B:BD[3.105009] → [5.17829:17921]

import * as glob from "glob";
import * as Mocha from "mocha";
import * as path from "path";

[3.105009]

[3.105102]

import * as glob from 'glob';
import * as Mocha from 'mocha';
import * as path from 'path';

Replacement in src/test/suite/index.ts at line 5 [3.105009]
B:BD[3.105103] → [5.17922:17962]
```
export function run (): Promise<void> {
```
[3.105103]
[5.17962]
```
export async function run (): Promise<void> {
```
Replacement in src/test/suite/index.ts at line 8 [3.105009]
B:BD[5.18017] → [5.18017:18032]
```
    ui: "tdd",
```
[5.18017]
[5.18032]
```
    ui: 'tdd',
```
Replacement in src/test/suite/index.ts at line 12 [3.105009]
B:BD[3.105228] → [5.18055:18106]
```
  const testsRoot = path.resolve(__dirname, "..");
```
[3.105228]
[3.105278]
```
  const testsRoot = path.resolve(__dirname, '..');
```

Replacement in src/test/suite/index.ts at line 14 [3.105009]

B:BD[3.105279] → [5.18107:18232]

  return new Promise((resolve, reject) => {
    glob("**/**.test.js", { cwd: testsRoot }, (err, files) => {
      if (err) {

[3.105279]

[5.18232]

  return await new Promise((resolve, reject) => {
    glob('**/**.test.js', { cwd: testsRoot }, (err, files) => {
      if (err != null) {

Replacement in src/test/suite/extension.test.ts at line 1 [3.105784]
B:BD[3.105784] → [5.18700:18734]
∅:D[5.18734] → [3.105819:105820]
B:BD[3.105819] → [3.105819:105820]
```
import * as assert from "assert";
```
[3.105784]
[3.105820]
```
import * as assert from 'assert';
```
Replacement in src/test/suite/extension.test.ts at line 4 [3.105784]
B:BD[3.105926] → [5.18735:18769]
```
import * as vscode from "vscode";
```
[3.105926]
[3.105960]
```
import * as vscode from 'vscode';
```

Replacement in src/test/suite/extension.test.ts at line 8 [3.105784]

B:BD[3.106012] → [5.18770:18868]

suite("Extension Test Suite", () => {
  vscode.window.showInformationMessage("Start all tests.");

[3.106012]

[3.106109]

suite('Extension Test Suite', () => {
  // eslint-disable-next-line @typescript-eslint/no-floating-promises
  vscode.window.showInformationMessage('Start all tests.');

Replacement in src/test/suite/extension.test.ts at line 12 [3.105784]
B:BD[3.106110] → [5.18869:18899]
```
  test("Sample test", () => {
```
[3.106110]
[5.18899]
```
  test('Sample test', () => {
```
Replacement in src/test/runTest.ts at line 1 [3.106258]
B:BD[3.106258] → [5.19006:19036]
```
import * as path from "path";
```
[3.106258]
[3.106289]
```
import * as path from 'path';
import { runTests } from 'vscode-test';
```
Replacement in src/test/runTest.ts at line 4 [3.106258]
B:BD[3.106290] → [5.19037:19077]
∅:D[5.19077] → [3.106330:106331]
B:BD[3.106330] → [3.106330:106331]
B:BD[3.106331] → [5.19078:19103]
```
import { runTests } from "vscode-test";
async function main () {
```
[3.106290]
[5.19103]
```
async function main (): Promise<void> {
```

Replacement in src/test/runTest.ts at line 8 [3.106258]

B:BD[5.19222] → [5.19222:19294]

    const extensionDevelopmentPath = path.resolve(__dirname, "../../");

[5.19222]

[3.106539]

    const extensionDevelopmentPath = path.resolve(__dirname, '../../');

Replacement in src/test/runTest.ts at line 12 [3.106258]

B:BD[5.19364] → [5.19364:19437]

    const extensionTestsPath = path.resolve(__dirname, "./suite/index");

[5.19364]

[3.106676]

    const extensionTestsPath = path.resolve(__dirname, './suite/index');

Replacement in src/test/runTest.ts at line 17 [3.106258]
B:BD[5.19589] → [5.19589:19631]
```
    console.error("Failed to run tests");
```
[5.19589]
[5.19631]
```
    console.error('Failed to run tests');
```
Insertion in src/test/runTest.ts at line 22 [3.106258]
[3.106888]
[3.106888]
```
// eslint-disable-next-line @typescript-eslint/no-floating-promises
```

Fix lint/style issues

Dependencies

In channels

Change contents

Replacement in src/extension.ts at line 2 [3.106912]

Replacement in src/extension.ts at line 6 [3.106912]

Insertion in src/extension.ts at line 10 [3.106912]

Replacement in src/extension.ts at line 12 [3.106912]

Replacement in src/extension.ts at line 14 [3.106912]

Replacement in src/extension.ts at line 18 [3.106912]

Replacement in src/extension.ts at line 26 [3.106912]

Replacement in src/extension.ts at line 28 [3.106912]

Replacement in src/extension.ts at line 40 [3.106912]

Replacement in src/extension.ts at line 42 [3.106912]

Replacement in src/extension.ts at line 44 [3.106912]

Replacement in src/extension.ts at line 47 [3.106912]

Replacement in src/extension.ts at line 50 [3.106912]

Replacement in src/extension.ts at line 55 [3.106912]

Replacement in src/extension.ts at line 59 [3.106912]

Replacement in src/extension.ts at line 63 [3.106912]

Replacement in src/extension.ts at line 73 [3.106912]

Replacement in src/extension.ts at line 86 [3.106912]

Replacement in src/extension.ts at line 90 [3.106912]

Replacement in src/extension.ts at line 92 [3.106912]

Replacement in src/extension.ts at line 94 [3.106912]

Replacement in src/extension.ts at line 98 [3.106912]

Replacement in src/extension.ts at line 101 [3.106912]

Replacement in src/extension.ts at line 105 [3.106912]

Insertion in src/extension.ts at line 116 [3.106912]

Replacement in src/extension.ts at line 139 [3.106912]

Replacement in src/extension.ts at line 149 [3.106912]

Replacement in src/extension.ts at line 152 [3.106912]

Replacement in src/extension.ts at line 163 [3.106912]

Replacement in src/test/suite/index.ts at line 1 [3.105009]

Replacement in src/test/suite/index.ts at line 5 [3.105009]

Replacement in src/test/suite/index.ts at line 8 [3.105009]

Replacement in src/test/suite/index.ts at line 12 [3.105009]

Replacement in src/test/suite/index.ts at line 14 [3.105009]

Replacement in src/test/suite/extension.test.ts at line 1 [3.105784]

Replacement in src/test/suite/extension.test.ts at line 4 [3.105784]

Replacement in src/test/suite/extension.test.ts at line 8 [3.105784]

Replacement in src/test/suite/extension.test.ts at line 12 [3.105784]

Replacement in src/test/runTest.ts at line 1 [3.106258]

Replacement in src/test/runTest.ts at line 4 [3.106258]

Replacement in src/test/runTest.ts at line 8 [3.106258]

Replacement in src/test/runTest.ts at line 12 [3.106258]

Replacement in src/test/runTest.ts at line 17 [3.106258]

Insertion in src/test/runTest.ts at line 22 [3.106258]