voroskoi/exercism - Change 3YL5F3GP4G2E2KDK2IJ2BA5S75YEW34P7BAKTNZZHXZRJHT2CNPQC

go: pythagorean: pass test on exercism.org, little tweaks here and there

Created by voroskoi on September 19, 2021

3YL5F3GP4G2E2KDK2IJ2BA5S75YEW34P7BAKTNZZHXZRJHT2CNPQC

Dependencies

In channels

main

Change contents

File deletion: trivial_test.go, pythagorean_triplet_test.go, trivial_test.go

BFD:BFD[6.10] → [6.11:28]

BF:BFD[6.28] → [7.53:53]

BFD:BFD[7.22] → [7.23:52]

BF:BFD[7.52] → [7.53:53]

BF:BFD[6.10] → [5.1403:1429]

BF:BFD[5.1429] → [7.53:53]

B:BD[7.53] → [6.29:50]

∅:D[6.50] → [7.603:628]

B:BD[7.603] → [7.603:628]

∅:D[6.74] → [7.628:903]

B:BD[7.628] → [7.628:903]

B:BD[7.903] → [6.75:117]

∅:D[6.117] → [7.949:1330]

B:BD[7.949] → [7.949:1330]

B:BD[7.1330] → [6.118:148]

∅:D[6.148] → [7.1364:1541]

B:BD[7.1364] → [7.1364:1541]

B:BD[7.1541] → [6.149:173]

∅:D[6.173] → [7.1569:1637]

B:BD[7.1569] → [7.1569:1637]

B:BD[7.1637] → [6.174:194]

∅:D[6.194] → [7.1661:1666]

B:BD[7.1661] → [7.1661:1666]

B:BD[7.628] → [6.51:74]

package trivial_test
import (
	"pythagorean"
	"reflect"
	"testing"
)
var rangeTests = []struct {
	min, max int
	ts       []pythagorean.Triplet
}{
	{1, 10, []pythagorean.Triplet{{3, 4, 5}, {6, 8, 10}}},
	{11, 20, []pythagorean.Triplet{{12, 16, 20}}},
}
func TestRange(t *testing.T) {
	for _, test := range rangeTests {
		ts := trivial.Range(test.min, test.max)
		if !reflect.DeepEqual(ts, test.ts) {
			t.Fatalf("Range(%d, %d) = %v, want %v",
				test.min, test.max, ts, test.ts)
		}
	}
}
var sumTests = []struct {
	sum int
	ts  []pythagorean.Triplet
}{
	{180, []pythagorean.Triplet{{18, 80, 82}, {30, 72, 78}, {45, 60, 75}}},
	{1000, []pythagorean.Triplet{{200, 375, 425}}},
}
func TestSum(t *testing.T) {
	for _, test := range sumTests {
		ts := trivial.Sum(test.sum)
		if !reflect.DeepEqual(ts, test.ts) {
			t.Fatalf("Sum(%d) = %v, want %v",
				test.sum, ts, test.ts)
		}
	}
}
func BenchmarkRange(b *testing.B) {
	for i := 0; i < b.N; i++ {
		trivial.Range(1, 100)
	}
}
func BenchmarkSum(b *testing.B) {
	for i := 0; i < b.N; i++ {
		trivial.Sum(1000)
	}
}
	"pythagorean/trivial"

File deletion: euclid_test.go, euclid_test.go

BFD:BFD[8.9] → [8.10:26]

BF:BFD[8.26] → [8.27:27]

BF:BFD[8.9] → [5.1470:1495]

BF:BFD[5.1495] → [8.27:27]

B:BD[8.27] → [8.28:1113]

package euclid_test
import (
	"pythagorean"
	"pythagorean/euclid"
	"reflect"
	"testing"
)
var rangeTests = []struct {
	min, max int
	ts       []pythagorean.Triplet
}{
	{1, 10, []pythagorean.Triplet{{3, 4, 5}, {6, 8, 10}}},
	{11, 20, []pythagorean.Triplet{{12, 16, 20}}},
}
func TestRange(t *testing.T) {
	for _, test := range rangeTests {
		ts := euclid.Range(test.min, test.max)
		if !reflect.DeepEqual(ts, test.ts) {
			t.Fatalf("Range(%d, %d) = %v, want %v",
				test.min, test.max, ts, test.ts)
		}
	}
}
var sumTests = []struct {
	sum int
	ts  []pythagorean.Triplet
}{
	{180, []pythagorean.Triplet{{18, 80, 82}, {30, 72, 78}, {45, 60, 75}}},
	{1000, []pythagorean.Triplet{{200, 375, 425}}},
}
func TestSum(t *testing.T) {
	for _, test := range sumTests {
		ts := euclid.Sum(test.sum)
		if !reflect.DeepEqual(ts, test.ts) {
			t.Fatalf("Sum(%d) = %v, want %v",
				test.sum, ts, test.ts)
		}
	}
}
func BenchmarkRange(b *testing.B) {
	for i := 0; i < b.N; i++ {
		euclid.Range(1, 100)
	}
}
func BenchmarkSum(b *testing.B) {
	for i := 0; i < b.N; i++ {
		euclid.Sum(1000)
	}
}

Replacement in go/pythagorean-triplet/euclid/euclid.go at line 11 [8.1126]
B:BD[8.1380] → [2.0:47]
```
	trp := make(map[pythagorean.Triplet]struct{})
```
[8.1380]
[2.47]
```
	trp := map[pythagorean.Triplet]struct{}{}
```

Replacement in go/pythagorean-triplet/euclid/euclid.go at line 26 [8.1126]

B:BD[8.1966] → [8.1966:2051]

					// this only counts unique triplets
					// https://stackoverflow.com/a/9251352

[8.1966]

[2.302]

					// this only counts unique triplets // https://stackoverflow.com/a/9251352

Insertion in go/pythagorean-triplet/euclid/euclid.go at line 32 [8.1126]
[8.2206]
[2.367]
```
	// we have to sort the results
```

File deletion: dickson_test.go, dickson_test.go

BFD:BFD[9.10] → [9.11:28]

BF:BFD[9.28] → [9.29:29]

BF:BFD[9.10] → [5.1536:1562]

BF:BFD[5.1562] → [9.29:29]

B:BD[9.29] → [9.30:1121]

package dickson_test
import (
	"pythagorean"
	"pythagorean/dickson"
	"reflect"
	"testing"
)
var rangeTests = []struct {
	min, max int
	ts       []pythagorean.Triplet
}{
	{1, 10, []pythagorean.Triplet{{3, 4, 5}, {6, 8, 10}}},
	{11, 20, []pythagorean.Triplet{{12, 16, 20}}},
}
func TestRange(t *testing.T) {
	for _, test := range rangeTests {
		ts := dickson.Range(test.min, test.max)
		if !reflect.DeepEqual(ts, test.ts) {
			t.Fatalf("Range(%d, %d) = %v, want %v",
				test.min, test.max, ts, test.ts)
		}
	}
}
var sumTests = []struct {
	sum int
	ts  []pythagorean.Triplet
}{
	{180, []pythagorean.Triplet{{18, 80, 82}, {30, 72, 78}, {45, 60, 75}}},
	{1000, []pythagorean.Triplet{{200, 375, 425}}},
}
func TestSum(t *testing.T) {
	for _, test := range sumTests {
		ts := dickson.Sum(test.sum)
		if !reflect.DeepEqual(ts, test.ts) {
			t.Fatalf("Sum(%d) = %v, want %v",
				test.sum, ts, test.ts)
		}
	}
}
func BenchmarkRange(b *testing.B) {
	for i := 0; i < b.N; i++ {
		dickson.Range(1, 100)
	}
}
func BenchmarkSum(b *testing.B) {
	for i := 0; i < b.N; i++ {
		dickson.Sum(1000)
	}
}

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 8 [9.1135]
B:BD[9.1348] → [3.0:27]
```
const MAX = 500 * 500 / 8
```

Insertion in go/pythagorean-triplet/dickson/dickson.go at line 9 [9.1135]

[4.1]

// MAX is arbitrary to pass tests. This solution precalculates factors so obviously faster

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 11 [9.1135]
∅:D[4.18] → [9.1348:1349]
∅:D[3.27] → [9.1348:1349]
B:BD[9.1348] → [9.1348:1349]
B:BD[9.1349] → [3.28:58]
```
var factors = genFactors(MAX)
```
Deletion in go/pythagorean-triplet/dickson/dickson.go at line 12 [9.1135]
B:BD[9.1349] → [4.19:73]
```
var factors = genFactors(((MAX / 4) * (MAX / 4)) / 2)
```
Solving an order conflict in go/pythagorean-triplet/dickson/dickson.go at line 12 [9.1135]
[3.59]

Insertion in go/pythagorean-triplet/dickson/dickson.go at line 12 [9.1135]

[0.251]

[4.73]

// we need the factors of r*r/2: r goes up to max/2, so (max/2)*(max/2)/2 should be enough
// the last 3/4 is just bluffing, I am not aware of hard facts
var factors = genFactors(((MAX / 2) * (MAX / 2)) / 2 * 3 / 4)

Insertion in go/pythagorean-triplet/dickson/dickson.go at line 18 [9.1135]
[9.1495]
[9.1495]
```
	// factors := genFactors((max / 2) * (max / 2) / 2 * 3 / 4)
```

Replacement in go/pythagorean-triplet/dickson/dickson.go at line 22 [9.1135]

B:BD[9.1544] → [9.1544:1596]

B:BD[9.1596] → [3.60:88]

B:BD[9.1596] → [4.75:103]

∅:D[3.88] → [9.1628:1849]

∅:D[4.103] → [9.1628:1849]

B:BD[9.1628] → [9.1628:1849]

	for c < max {
		for r := 2; r < max/2; r = r + 2 {
			fact := factors[(r*r)/2]
			fact := factors[(r*r)/2]
			for i := 0; i < len(fact)/2; i++ {
				s := fact[i]
				t := (r * r) / 2 / fact[i]
				a = r + s
				b = r + t
				c = r + s + t
				if a >= min && c <= max {
					ret = append(ret, pythagorean.Triplet{a, b, c})
				}

[9.1544]

[9.1849]


	// r is an _even_ integer, t and s are the factors of r*r/2
	for r := 2; r < max/2 && c < max; r = r + 2 {
		fact := factors[(r*r)/2]
		for i := 0; i < len(fact)/2; i++ {
			s := fact[i]
			t := (r * r) / 2 / s // r*r = 2*s*t
			a = r + s
			b = r + t
			c = r + s + t
			if a >= min && c <= max {
				ret = append(ret, pythagorean.Triplet{a, b, c})

Replacement in go/pythagorean-triplet/dickson/dickson.go at line 41 [9.1135]

B:BD[3.167] → [3.167:243]

func genFactors(max int) map[int][]int {
	var factors = make(map[int][]int)

[3.167]

[3.243]

func genFactors(max int) [][]int {
	var factors = make([][]int, max)

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 46 [9.1135]

B:BD[9.1876] → [4.104:356]

// https://www.geeksforgeeks.org/find-all-divisors-of-first-n-natural-numbers
func genFactors(max int) map[int][]int {
	var factors = make(map[int][]int)
	for i := 1; i < max; i++ {
		for j := i; j < max; j += i {
			factors[j] = append(factors[j], i)

Solving an order conflict in go/pythagorean-triplet/dickson/dickson.go at line 46 [9.1135]
[3.341]
[9.2010]
Deletion in go/pythagorean-triplet/dickson/dickson.go at line 49 [9.1135]
B:BD[9.2017] → [4.357:373]
```
	return factors
```
Solving an order conflict in go/pythagorean-triplet/dickson/dickson.go at line 49 [9.1135]
[3.358]
[9.2064]

go: pythagorean: pass test on exercism.org, little tweaks here and there

Dependencies

In channels

Change contents

File deletion: trivial_test.go, pythagorean_triplet_test.go, trivial_test.go

File deletion: euclid_test.go, euclid_test.go

Replacement in go/pythagorean-triplet/euclid/euclid.go at line 11 [8.1126]

Replacement in go/pythagorean-triplet/euclid/euclid.go at line 26 [8.1126]

Insertion in go/pythagorean-triplet/euclid/euclid.go at line 32 [8.1126]

File deletion: dickson_test.go, dickson_test.go

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 8 [9.1135]

Insertion in go/pythagorean-triplet/dickson/dickson.go at line 9 [9.1135]

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 11 [9.1135]

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 12 [9.1135]

Solving an order conflict in go/pythagorean-triplet/dickson/dickson.go at line 12 [9.1135]

Insertion in go/pythagorean-triplet/dickson/dickson.go at line 12 [9.1135]

Insertion in go/pythagorean-triplet/dickson/dickson.go at line 18 [9.1135]

Replacement in go/pythagorean-triplet/dickson/dickson.go at line 22 [9.1135]

Replacement in go/pythagorean-triplet/dickson/dickson.go at line 41 [9.1135]

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 46 [9.1135]

Solving an order conflict in go/pythagorean-triplet/dickson/dickson.go at line 46 [9.1135]

Deletion in go/pythagorean-triplet/dickson/dickson.go at line 49 [9.1135]

Solving an order conflict in go/pythagorean-triplet/dickson/dickson.go at line 49 [9.1135]