Open source Nest implementation

#3 Broken code in the main channel

Closed on October 14, 2021
fzzr on October 12, 2021

There’s conflict-diff in the main channel. 😖

zj on October 12, 2021

Thanks for opening this discussion, could you be more specific? I’ll fix right away @fzzr.

fzzr added a change on October 12, 2021
clean code by APaw7DxxSKk1nPAJLAupKXWz1Ly74HchRnwCnSQBnJv3,
I43RAQTR6WY7KFUFBU5ALAWSNNQZPHSHATOVXFCERQRFTTK5OHNQC
main
fzzr on October 12, 2021

could you be more specific?

Just clone the repo and you will see this:

Cargo.toml

...
regex = "1"
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
tokio = "1"
================================
tokio = "1"
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
uuid = { version = "0.8", features = ["serde", "v4"] }
...
fzzr on October 12, 2021

I’ve just fixed it there.

zj on October 12, 2021

https://nest.pijul.com/zj/nidobyte:main/W3M3C7CCWHJWQ.4UCAA

I can’t find it there, maybe I’ve not yet synced all patches. I’ll look at your patch in a bit and either apply that or fix it myself. The sent patch is removing some lines right now I don’t think are intentional.

fzzr on October 12, 2021

Hah! :)

https://nest.pijul.com/zj/nidobyte:main/W3M3C7CCWHJWQ.4UCAA

Look at the lines 14-15 there in the Cargo.toml.

fzzr on October 12, 2021

I’ll look at your patch in a bit and either apply that or fix it myself.

Thanks. There’s only

  • resolve conflicts
  • update/rebuild Cargo.lock
zj on October 12, 2021

Haha, good one. I was looking for literal conflict markers :) The <<<< part. My bad. Will fix soon

zj on October 12, 2021

Nice, so cloning locally again I do get them. Thanks for pointing it out.

zj on October 12, 2021

@fzzr this should be resolved. Was indeed missing a patch locally, and wasn’t properly validating before updating here. Could you verify?

fzzr on October 14, 2021

@zj I agree, this is resolved. Thanks!

fzzr on October 14, 2021

Well, I’m sure this discussion should be closed. Thank you 😊

fzzr closed this discussion on October 14, 2021