Sivecano/dwl - Change XXOC2AY53ZWML6TVPKX6BHGKZJNRET4IWRSTCVMJQJZMK3MFD3TQC

Handle monitor unplug

Floating widndows with "x < removed monitor's width" aren't resized (they used to disappear in negative coordinates).

Actually delete monitors when they are unplugged, recalculate sgeom and give a new monitor to clients that were on the removed one with setmon()

arrangefloat() funcion has been exploded to save iterations in cleanupmon().

Also if a monitor that supports auto suspension is turned off, dwl will count it as unplugged (it will become unreachable and all clients will be moved to the leftmost monitor). However, if at least one monitor isn't plugged in, dwl will still crash the same as before.

Unlike sway, when the output configuration is changed and restored, (unplug + plug the same monitor for example) previous application positions aren't kept. This is due to the fact that on sway every workspace is unique among all monitors.

Created by Stivvo on September 14, 2020

XXOC2AY53ZWML6TVPKX6BHGKZJNRET4IWRSTCVMJQJZMK3MFD3TQC

Dependencies

In channels

main

Change contents

Deletion in dwl.c at line 198 [4.4]
B:BD[3.563] → [2.3:51]
```
static void arrangefloat(Monitor *m, int sign);
```

Deletion in dwl.c at line 473 [4.4]

B:BD[2.60] → [2.60:267]

∅:D[5.58] → [3.764:772]

∅:D[2.267] → [3.764:772]

B:BD[3.764] → [3.764:772]

arrangefloat(Monitor *m, int sign)
{
	Client *c;
	wl_list_for_each(c, &clients, link) {
		if (c->isfloating)
			resize(c, c->geom.x + m->w.width * sign, c->geom.y,
					c->geom.width, c->geom.height, 0);
	}
}
void

Replacement in dwl.c at line 690 [4.4]

B:BD[6.200] → [6.200:232]

	Monitor *m = wlr_output->data;

[6.200]

[6.232]

	Monitor *m = wlr_output->data, *newmon;
	Client *c;

Replacement in dwl.c at line 694 [4.4]

B:BD[6.268] → [6.268:278]

	free(m);

[6.268]

[7.75]

	wl_list_remove(&m->frame.link);
	wl_list_remove(&m->link);
	wlr_output_layout_remove(output_layout, m->wlr_output);

Insertion in dwl.c at line 698 [4.4]

[7.76]

[8.30]

	sgeom = *wlr_output_layout_get_box(output_layout, NULL);

Replacement in dwl.c at line 700 [4.4]

B:BD[8.45] → [2.268:290]

	arrangefloat(m, -1);

[8.45]

[9.92]


	wl_list_for_each(newmon, &mons, link) {
		wl_list_for_each(c, &clients, link) {
			if (c->isfloating && c->geom.x > m->m.width) {
				resize(c, c->geom.x - m->w.width, c->geom.y,
						c->geom.width, c->geom.height, 0);
			}
			if (c->mon == m)
				setmon(c, newmon, 0);
		}
		break;
	}
	free(m);

Replacement in dwl.c at line 843 [4.4]

B:BD[2.392] → [2.392:414]

		arrangefloat(m, 1);

[2.392]

[2.414]

		Client *c;
		wl_list_for_each(c, &clients, link) {
			if (c->isfloating)
				resize(c, c->geom.x + m->w.width, c->geom.y,
						c->geom.width, c->geom.height, 0);
		}