eschnett/cactusamrex - Change LHPZHX4FMRYBM7NI22QTP3VZDBYFRSNTY3L6BEEFPPF5KWCFFIHQC

CarpetX: Begin to track why regions are valid or invalid

Created by Erik Schnetter on December 18, 2019

LHPZHX4FMRYBM7NI22QTP3VZDBYFRSNTY3L6BEEFPPF5KWCFFIHQC

Dependencies

In channels

master

main

Change contents

Insertion in CarpetX/src/driver.cxx at line 163 [8.15972]
[6.137]
[7.1414]
```
    scalargroupdata.why_valid.resize(group.numtimelevels);
```

Insertion in CarpetX/src/driver.cxx at line 167 [8.15972]

[6.206]

[7.1549]

      scalargroupdata.why_valid.at(tl).resize(scalargroupdata.numvars);

Replacement in CarpetX/src/driver.cxx at line 171 [8.15972]

B:BD[7.1824] → [7.1824:1887]

B:BD[7.1887] → [9.0:129]

        scalargroupdata.valid.at(tl).at(vi).valid_int = false;
        scalargroupdata.valid.at(tl).at(vi).valid_outer = true;
        scalargroupdata.valid.at(tl).at(vi).valid_ghosts = true;

[7.1824]

[7.1949]

        auto &valid = scalargroupdata.valid.at(tl).at(vi);
        valid.valid_int = false;
        valid.valid_outer = true;
        valid.valid_ghosts = true;
        scalargroupdata.why_valid.at(tl).at(vi) = {"SetupGlobals"};

Insertion in CarpetX/src/driver.cxx at line 319 [8.15972]
[10.311]
[11.1855]
```
    groupdata.why_valid.resize(group.numtimelevels);
```

Insertion in CarpetX/src/driver.cxx at line 324 [8.15972]

[10.379]

[12.386]

      groupdata.why_valid.at(tl) =
          vector<why_valid_t>(groupdata.numvars, {"SetupLevel"});

Replacement in CarpetX/src/driver.cxx at line 624 [8.15972]
B:BD[13.3683] → [10.650:688]
```
    for (int tl = 0; tl < ntls; ++tl)
```
[13.3683]
[10.688]
```
    for (int tl = 0; tl < ntls; ++tl) {
```

Insertion in CarpetX/src/driver.cxx at line 626 [8.15972]

[10.755]

      groupdata.why_valid.at(tl) =
          vector<why_valid_t>(groupdata.numvars, {"MakeNewLevelFromCoarse"});
    }

Replacement in CarpetX/src/driver.cxx at line 633 [8.15972]

B:BD[12.690] → [12.690:763]

B:BD[12.763] → [9.130:279]

        all_invalid &= !coarsegroupdata.valid.at(tl).at(vi).valid_int &&
                       !coarsegroupdata.valid.at(tl).at(vi).valid_outer &&
                       !coarsegroupdata.valid.at(tl).at(vi).valid_ghosts;

[12.690]

[12.834]

        all_invalid &= !coarsegroupdata.valid.at(tl).at(vi).valid_any();

Replacement in CarpetX/src/driver.cxx at line 636 [8.15972]

B:BD[12.916] → [12.916:975]

B:BD[12.975] → [9.280:403]

          groupdata.valid.at(tl).at(vi).valid_int = false;
          groupdata.valid.at(tl).at(vi).valid_outer = false;
          groupdata.valid.at(tl).at(vi).valid_ghosts = false;

[12.916]

[12.1034]

          groupdata.valid.at(tl).at(vi) = valid_t(false);
          groupdata.why_valid.at(tl).at(vi) = {
              "MakeNewLevelFromCoarse: coarse grid is all invalid"};

Replacement in CarpetX/src/driver.cxx at line 643 [8.15972]

∅:D[14.57] → [15.102:167]

B:BD[15.102] → [15.102:167]

B:BD[15.167] → [9.404:540]

∅:D[9.540] → [15.233:304]

B:BD[15.233] → [15.233:304]

B:BD[15.304] → [9.541:626]

          if (!(coarsegroupdata.valid.at(tl).at(vi).valid_int &&
                coarsegroupdata.valid.at(tl).at(vi).valid_outer &&
                coarsegroupdata.valid.at(tl).at(vi).valid_ghosts)) {
            valid_t all_valid;
            all_valid.valid_int = true;
            all_valid.valid_outer = true;
            all_valid.valid_ghosts = true;

[14.57]

[14.58]

          if (!coarsegroupdata.valid.at(tl).at(vi).valid_all()) {
            valid_t all_valid(true);

Replacement in CarpetX/src/driver.cxx at line 664 [8.15972]

B:BD[12.1529] → [12.1529:1644]

B:BD[12.1644] → [9.627:879]

          groupdata.valid.at(tl).at(vi).valid_int =
              coarsegroupdata.valid.at(tl).at(vi).valid_int &&
              coarsegroupdata.valid.at(tl).at(vi).valid_outer &&
              coarsegroupdata.valid.at(tl).at(vi).valid_ghosts;
          groupdata.valid.at(tl).at(vi).valid_outer = false;
          groupdata.valid.at(tl).at(vi).valid_ghosts = false;

[12.1529]

[12.1764]

          auto &valid = groupdata.valid.at(tl).at(vi);
          valid.valid_int = coarsegroupdata.valid.at(tl).at(vi).valid_all();
          valid.valid_outer = false;
          valid.valid_ghosts = false;
          groupdata.why_valid.at(tl).at(vi) = {
              "MakeNewLevelFromCoarse: prolongated"};

Insertion in CarpetX/src/driver.cxx at line 750 [8.15972]

[10.1432]

[16.129]

      auto why_valid = vector<why_valid_t>(groupdata.numvars, {"RemakeLevel"});

Replacement in CarpetX/src/driver.cxx at line 771 [8.15972]

B:BD[12.2026] → [12.2026:2101]

B:BD[12.2101] → [9.880:1035]

∅:D[9.1035] → [12.2176:2245]

B:BD[12.2176] → [12.2176:2245]

B:BD[12.2245] → [9.1036:1177]

∅:D[9.1177] → [12.2312:2313]

B:BD[12.2312] → [12.2312:2313]

          all_invalid &= !coarsegroupdata.valid.at(tl).at(vi).valid_int &&
                         !coarsegroupdata.valid.at(tl).at(vi).valid_outer &&
                         !coarsegroupdata.valid.at(tl).at(vi).valid_ghosts &&
                         !groupdata.valid.at(tl).at(vi).valid_int &&
                         !groupdata.valid.at(tl).at(vi).valid_outer &&
                         !groupdata.valid.at(tl).at(vi).valid_ghosts;

[12.2026]

[12.2313]

          all_invalid &= !coarsegroupdata.valid.at(tl).at(vi).valid_any() &&
                         !groupdata.valid.at(tl).at(vi).valid_any();

Replacement in CarpetX/src/driver.cxx at line 777 [8.15972]

B:BD[12.2500] → [9.1178:1408]

B:BD[9.1408] → [2.975:1034]

∅:D[2.1034] → [9.1409:1530]

B:BD[12.2731] → [9.1409:1530]

            const bool cond =
                coarsegroupdata.valid.at(tl).at(vi).valid_int &&
                coarsegroupdata.valid.at(tl).at(vi).valid_outer &&
                coarsegroupdata.valid.at(tl).at(vi).valid_ghosts &&
                groupdata.valid.at(tl).at(vi).valid_int &&
                groupdata.valid.at(tl).at(vi).valid_outer &&
                groupdata.valid.at(tl).at(vi).valid_ghosts;

[12.2500]

[12.2802]

            const bool cond = coarsegroupdata.valid.at(tl).at(vi).valid_all() &&
                              groupdata.valid.at(tl).at(vi).valid_all();

Replacement in CarpetX/src/driver.cxx at line 780 [8.15972]

B:BD[12.2825] → [12.2825:3354]

              CCTK_VERROR("Found invalid input data: RemakeLevel level %d, "
                          "variable %s%s: need everything defined, have coarse "
                          "%s, have current %s",
                          leveldata.level,
                          CCTK_FullVarName(groupdata.firstvarindex + vi),
                          string("_p", tl).c_str(),
                          string(coarsegroupdata.valid.at(tl).at(vi)).c_str(),
                          string(groupdata.valid.at(tl).at(vi)).c_str());

[12.2825]

[17.285]

              CCTK_VERROR(
                  "Found invalid input data: RemakeLevel level %d, "
                  "variable %s%s: need everything defined, have coarse "
                  "%s (%s), have current %s (%s)",
                  leveldata.level,
                  CCTK_FullVarName(groupdata.firstvarindex + vi),
                  string("_p", tl).c_str(),
                  string(coarsegroupdata.valid.at(tl).at(vi)).c_str(),
                  string(coarsegroupdata.why_valid.at(tl).at(vi)).c_str(),
                  string(groupdata.valid.at(tl).at(vi)).c_str(),
                  string(groupdata.why_valid.at(tl).at(vi)).c_str());

Replacement in CarpetX/src/driver.cxx at line 808 [8.15972]

∅:D[18.62] → [19.516:581]

B:BD[19.516] → [19.516:581]

B:BD[19.581] → [9.1531:1666]

∅:D[9.1666] → [19.646:705]

B:BD[19.646] → [19.646:705]

B:BD[19.705] → [9.1667:1788]

                coarsegroupdata.valid.at(tl).at(vi).valid_int &&
                coarsegroupdata.valid.at(tl).at(vi).valid_outer &&
                coarsegroupdata.valid.at(tl).at(vi).valid_ghosts &&
                groupdata.valid.at(tl).at(vi).valid_int &&
                groupdata.valid.at(tl).at(vi).valid_outer &&
                groupdata.valid.at(tl).at(vi).valid_ghosts;

[18.62]

[9.1788]

                coarsegroupdata.valid.at(tl).at(vi).valid_all() &&
                groupdata.valid.at(tl).at(vi).valid_all();

Insertion in CarpetX/src/driver.cxx at line 812 [8.15972]

[9.1881]

[19.806]

            why_valid.at(vi) = {"RemakeLevel: copied and prolongated"};

Insertion in CarpetX/src/driver.cxx at line 818 [8.15972]
[10.1901]
[20.2531]
```
      groupdata.why_valid.at(tl) = move(why_valid);
```
Insertion in CarpetX/src/driver.cxx at line 853 [8.15972]
[21.2154]
[22.316]
```
#warning "CONTINUE HERE: why_valid"
```
Replacement in CarpetX/src/driver.hxx at line 96 [8.15275]
B:BD[3.1018] → [3.1018:1049]
```
  constexpr bool all() const {
```
[3.1018]
[3.1049]
```
  constexpr bool valid_all() const {
```
Replacement in CarpetX/src/driver.hxx at line 99 [8.15275]
B:BD[3.1106] → [3.1106:1137]
```
  constexpr bool any() const {
```
[3.1106]
[3.1137]
```
  constexpr bool valid_any() const {
```

Insertion in CarpetX/src/driver.hxx at line 124 [8.15275]

[10.2769]

[3.1197]

struct why_valid_t {
  string why_int, why_outer, why_ghosts;
  why_valid_t() : why_valid_t("<unknown reason>") {}
  why_valid_t(const string &why)
      : why_int(why), why_outer(why), why_ghosts(why) {}
  friend ostream &operator<<(ostream &os, const why_valid_t why) {
    return os << "why_valid_t{int:" << why.why_int << ","
              << "outer:" << why.why_outer << ","
              << "ghosts:" << why.why_ghosts << "}";
  }
  operator string() const {
    ostringstream buf;
    buf << *this;
    return buf.str();
  }
};

Replacement in CarpetX/src/driver.hxx at line 172 [8.15275]

B:BD[7.2641] → [7.2641:2704]

    vector<vector<valid_t> > valid; // [time level][var index]

[7.2641]

[7.2704]

    vector<vector<valid_t> > valid;         // [time level][var index]
    vector<vector<why_valid_t> > why_valid; // [time level][var index]

Replacement in CarpetX/src/schedule.cxx at line 268 [24.531]
B:BD[23.16690] → [5.0:24]
```
    if (!valid.any()) {
```
[23.16690]
[9.6688]
```
    if (!valid.valid_any()) {
```
Replacement in CarpetX/src/schedule.cxx at line 312 [24.531]
B:BD[12.5039] → [5.25:48]
```
    if (valid.all()) {
```
[12.5039]
[9.7661]
```
    if (valid.valid_all()) {
```
Replacement in CarpetX/src/schedule.cxx at line 356 [24.531]
B:BD[7.5887] → [5.49:68]
```
  if (valid.all())
```
[7.5887]
[7.5929]
```
  if (valid.valid_all())
```
Replacement in CarpetX/src/schedule.cxx at line 377 [24.531]
B:BD[7.6437] → [5.69:89]
```
  if (!valid.any())
```
[7.6437]
[7.6481]
```
  if (!valid.valid_any())
```

Replacement in CarpetX/src/schedule.cxx at line 495 [24.531]

B:BD[4.3126] → [4.3126:3173]

            if (!(wr.any() && to_check.any()))

[4.3126]

[4.3173]

            if (!(wr.valid_any() && to_check.valid_any()))

Replacement in CarpetX/src/schedule.cxx at line 559 [24.531]
B:BD[4.5366] → [4.5366:5403]
```
            assert(did_check.any());
```
[4.5366]
[4.5403]
```
            assert(did_check.valid_any());
```

CarpetX: Begin to track why regions are valid or invalid

Dependencies

In channels

Change contents

Insertion in CarpetX/src/driver.cxx at line 163 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 167 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 171 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 319 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 324 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 624 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 626 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 633 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 636 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 643 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 664 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 750 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 771 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 777 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 780 [8.15972]

Replacement in CarpetX/src/driver.cxx at line 808 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 812 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 818 [8.15972]

Insertion in CarpetX/src/driver.cxx at line 853 [8.15972]

Replacement in CarpetX/src/driver.hxx at line 96 [8.15275]

Replacement in CarpetX/src/driver.hxx at line 99 [8.15275]

Insertion in CarpetX/src/driver.hxx at line 124 [8.15275]

Replacement in CarpetX/src/driver.hxx at line 172 [8.15275]

Replacement in CarpetX/src/schedule.cxx at line 268 [24.531]

Replacement in CarpetX/src/schedule.cxx at line 312 [24.531]

Replacement in CarpetX/src/schedule.cxx at line 356 [24.531]

Replacement in CarpetX/src/schedule.cxx at line 377 [24.531]

Replacement in CarpetX/src/schedule.cxx at line 495 [24.531]

Replacement in CarpetX/src/schedule.cxx at line 559 [24.531]