eschnett/cactusamrex - Change LKRIJNWIJKODEMID26XESRMJD54V2T7R4OVFVBX3RHCPBICZ4V2QC

Define fluxes in the AMReX convention (integrated over space and time)

Created by Erik Schnetter on November 4, 2019

LKRIJNWIJKODEMID26XESRMJD54V2T7R4OVFVBX3RHCPBICZ4V2QC

Dependencies

In channels

master

main

Change contents

Deletion in CarpetX/src/schedule.cxx at line 1692 [5.531]

B:BD[3.4756] → [4.13604:13644]

∅:D[4.13644] → [3.4772:4990]

B:BD[3.4772] → [3.4772:4990]

#warning "TODO: scale fluxes correctly"
      const Geometry &geom0 = ghext->amrcore->Geom(level);
      const CCTK_REAL *restrict gdx = geom0.CellSize();
      CCTK_REAL dt = 0.25 * pow(0.5, 2) * gdx[0];
      CCTK_REAL dx = 1.0 * pow(0.5, level) * gdx[0];

Replacement in CarpetX/src/schedule.cxx at line 1697 [5.531]

B:BD[3.5298] → [3.5298:5375]

                                     flux_groupdata.numvars, -dt * dx * dx);

[3.5298]

[3.5375]

                                     flux_groupdata.numvars, -1);

Replacement in CarpetX/src/schedule.cxx at line 1699 [5.531]

B:BD[3.5453] → [3.5453:5584]

                                    flux_finegroupdata.numvars,
                                    dt * (0.5 * dx) * (0.5 * dx));

[3.5453]

[3.5584]

                                    flux_finegroupdata.numvars, 1);

Deletion in HydroToyCarpetX/src/evolve.cxx at line 23 [2.27888]
B:BD[2.28301] → [2.28301:28341]
```
  const CCTK_REAL dt = CCTK_DELTA_TIME;
```
Insertion in HydroToyCarpetX/src/evolve.cxx at line 26 [2.27888]
[2.28473]
[2.28473]
```
  const CCTK_REAL dV1 = 1 / (dx * dy * dz);
```

Deletion in HydroToyCarpetX/src/evolve.cxx at line 28 [2.27888]

B:BD[2.28474] → [2.28474:28580]

  const CCTK_REAL dt_dx = dt / dx;
  const CCTK_REAL dt_dy = dt / dy;
  const CCTK_REAL dt_dz = dt / dz;

Replacement in HydroToyCarpetX/src/evolve.cxx at line 78 [2.27888]

B:BD[2.30411] → [2.30411:30552]

  auto vec_dt_dx = CCTK_VEC_REAL::set1(dt_dx);
  auto vec_dt_dy = CCTK_VEC_REAL::set1(dt_dy);
  auto vec_dt_dz = CCTK_VEC_REAL::set1(dt_dz);

[2.30411]

[2.30552]

  const auto vec_dV1 = CCTK_VEC_REAL::set1(dV1);

Replacement in HydroToyCarpetX/src/evolve.cxx at line 105 [2.27888]

B:BD[2.31826] → [2.31826:31956]

          auto u = u_p - (vec_dt_dx * (fx1 - fx0) + vec_dt_dy * (fy1 - fy0) +
                          vec_dt_dz * (fz1 - fz0));

[2.31826]

[2.31956]

          auto u = u_p - vec_dV1 * ((fx1 - fx0) + (fy1 - fy0) + (fz1 - fz0));

Deletion in HydroToyCarpetX/src/fluxes.cxx at line 23 [2.32342]
B:BD[2.32755] → [2.32755:32785]
```
#warning "TODO: scale fluxes"
```

Insertion in HydroToyCarpetX/src/fluxes.cxx at line 27 [2.32342]

[2.32957]

  const CCTK_REAL dAx = dt * dy * dz;
  const CCTK_REAL dAy = dt * dx * dz;
  const CCTK_REAL dAz = dt * dx * dy;

Insertion in HydroToyCarpetX/src/fluxes.cxx at line 93 [2.32342]

[2.35475]


  const auto vec_dAx = CCTK_VEC_REAL::set1(dAx);
  const auto vec_dAy = CCTK_VEC_REAL::set1(dAy);
  const auto vec_dAz = CCTK_VEC_REAL::set1(dAz);

Insertion in HydroToyCarpetX/src/fluxes.cxx at line 110 [2.32342]

[2.35938]


  // For refluxing, AMReX expects fluxes to be integrated over the
  // faces both in space and time.

Replacement in HydroToyCarpetX/src/fluxes.cxx at line 129 [2.32342]

B:BD[2.36672] → [2.36672:36747]

          auto fx = llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

[2.36672]

[2.36747]

          auto fx =
              vec_dAx * llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

Replacement in HydroToyCarpetX/src/fluxes.cxx at line 171 [2.32342]

B:BD[2.38480] → [2.38480:38555]

          auto fy = llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

[2.38480]

[2.38555]

          auto fy =
              vec_dAy * llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

Replacement in HydroToyCarpetX/src/fluxes.cxx at line 213 [2.32342]

B:BD[2.40288] → [2.40288:40363]

          auto fz = llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

[2.40288]

[2.40363]

          auto fz =
              vec_dAz * llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

Insertion in HydroToyCarpetX/src/hydrotoy.cxx at line 218 [7.6253]

[6.6659]

[2.43572]

  const CCTK_REAL dt = CCTK_DELTA_TIME;
  const CCTK_REAL dx = CCTK_DELTA_SPACE(0);
  const CCTK_REAL dy = CCTK_DELTA_SPACE(1);
  const CCTK_REAL dz = CCTK_DELTA_SPACE(2);
  const CCTK_REAL dAx = dt * dy * dz;
  const CCTK_REAL dAy = dt * dx * dz;
  const CCTK_REAL dAz = dt * dx * dy;

Replacement in HydroToyCarpetX/src/hydrotoy.cxx at line 270 [7.6253]

∅:D[8.4649] → [6.8751:8819]

B:BD[6.8751] → [6.8751:8819]

      return llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

[8.4649]

[6.8819]

      return dAx * llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

Replacement in HydroToyCarpetX/src/hydrotoy.cxx at line 294 [7.6253]

∅:D[8.4869] → [6.9570:9638]

B:BD[6.9570] → [6.9570:9638]

      return llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

[8.4869]

[6.9638]

      return dAy * llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

Replacement in HydroToyCarpetX/src/hydrotoy.cxx at line 318 [7.6253]

∅:D[8.5089] → [6.10389:10457]

B:BD[6.10389] → [6.10389:10457]

      return llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

[8.5089]

[6.10457]

      return dAz * llf(lambda_m, lambda_p, var_m, var_p, flux_m, flux_p);

Deletion in HydroToyCarpetX/src/hydrotoy.cxx at line 339 [7.6253]
B:BD[7.7058] → [8.5201:5241]
```
  const CCTK_REAL dt = CCTK_DELTA_TIME;
```
Insertion in HydroToyCarpetX/src/hydrotoy.cxx at line 342 [7.6253]
[8.5373]
[8.6071]
```
  const CCTK_REAL dV1 = 1 / (dx * dy * dz);
```

Replacement in HydroToyCarpetX/src/hydrotoy.cxx at line 401 [7.6253]

B:BD[9.4375] → [9.4375:4543]

      return dt * ((fx(p.I + p.DI(0)) - fx(p.I)) / dx +
                   (fy(p.I + p.DI(1)) - fy(p.I)) / dy +
                   (fz(p.I + p.DI(2)) - fz(p.I)) / dz);

[9.4375]

[8.7490]

      return dV1 *
             ((fx(p.I + p.DI(0)) - fx(p.I)) + (fy(p.I + p.DI(1)) - fy(p.I)) +
              (fz(p.I + p.DI(2)) - fz(p.I)));