eschnett/cactusamrex - Change WUOXLOK3CHUS2F3IEE6IOPUJBXLWJU4AHGJP44PMM2NED2ALVKZQC

CarpetX: Correct definition of standard deviation (oops)

Created by Erik Schnetter on June 20, 2020

WUOXLOK3CHUS2F3IEE6IOPUJBXLWJU4AHGJP44PMM2NED2ALVKZQC

Dependencies

[2] IBJK5HBMWKXUMHT7E2W5OVCA7SJYFRAHMJFP5K5CHWDQXBLEBC2QC
[3] B7Y552HZXBV2PD22T7ZXGFJKUYU23A7XDWV4XZK46SGQKX7U45PQC
[4] VAF66DTVLDWNG7N2PEQYEH4OH5SPSMFBXKPR2PU67IIM6CVPCJ7AC

In channels

master

main

Change contents

Insertion in CarpetX/src/reduction.cxx at line 121 [4.870]

[3.18434]

#warning                                                                       \
    "TODO: Don't overcount vertex-centred grid boundaries; introduce a weight function"

Replacement in CarpetX/src/reduction.hxx at line 63 [4.2777]

B:BD[2.519] → [2.519:574]

    return sqrt(fmax1(T(0), vol * sum2 - pow21(sum)));

[2.519]

[2.574]

    return sqrt(fmax1(T(0), sum2 / vol - pow21(sum / vol)));