fiddlerwoaroof/crawl - Change BUAX73QNMJM7I5T3HLNV7IJUWTQDCFK4BFQGNWA4M3M2C2CXJCHAC

After some thought, allow mundane items to be artefacts again, but more

rarely than non-mundane items. After all, there are some unrandarts made from mundane items, so there's precedent for it.

Created by David Lawrence Ramsey on October 31, 2009

BUAX73QNMJM7I5T3HLNV7IJUWTQDCFK4BFQGNWA4M3M2C2CXJCHAC

Dependencies

In channels

main

Change contents

Replacement in crawl-ref/source/makeitem.cc at line 940 [6.927]
B:BD[5.3123] → [5.3123:3158]
```
            do_curse_item( item );
```
[5.3123]
[5.3158]
```
            do_curse_item(item);
```
Replacement in crawl-ref/source/makeitem.cc at line 947 [6.927]
B:BD[6.31748] → [5.3326:3361]
```
            do_curse_item( item );
```
[6.31748]
[6.31795]
```
            do_curse_item(item);
```

Replacement in crawl-ref/source/makeitem.cc at line 957 [6.927]

B:BD[5.3565] → [7.30185:30261]

        return _try_make_item_special_unrand(item, force_type, item_level);

[5.3565]

[5.3747]

        return (_try_make_item_special_unrand(item, force_type, item_level));

Replacement in crawl-ref/source/makeitem.cc at line 2225 [6.927]

B:BD[6.81450] → [4.2845:2917]

    // Hide armours and crystal plate mail normally don't get egos, but

[6.81450]

[8.2781]

    // Skin armours and crystal plate mail normally don't get egos, but

Insertion in crawl-ref/source/makeitem.cc at line 2228 [6.927]
[9.2517]
[4.2918]
```
        || item.sub_type == ARM_ANIMAL_SKIN
```
Deletion in crawl-ref/source/makeitem.cc at line 3011 [6.927]
B:BD[10.13708] → [11.2894:2925]
∅:D[11.2925] → [12.24609:24633]
∅:D[13.3300] → [12.24609:24633]
B:BD[10.13887] → [12.24609:24633]
B:BD[10.13915] → [10.13915:13916]
```
    if (item_is_mundane(item))
        return (false);
```
Insertion in crawl-ref/source/makeitem.cc at line 3017 [6.927]
[10.14063]
[10.14063]
```
    if (item_is_mundane(item))
        return (false);
```
Deletion in crawl-ref/source/makeitem.cc at line 3033 [6.927]
B:BD[14.2976] → [14.2976:2977]
B:BD[14.2977] → [11.2926:2957]
∅:D[11.2957] → [14.3009:3033]
B:BD[14.3009] → [14.3009:3033]
```
    if (item_is_mundane(item))
        return (false);
```
Insertion in crawl-ref/source/makeitem.cc at line 3040 [6.927]
[14.3184]
[2.2672]
```
    if (item_is_mundane(item))
        return (false);
```

Replacement in crawl-ref/source/itemprop.cc at line 587 [15.646661]

B:BD[11.3147] → [11.3147:3205]

// Is item something that no one would bother enchanting?

[11.3147]

[11.3205]

// Is item something that no one would usually bother enchanting?

Replacement in crawl-ref/source/effects.cc at line 1965 [18.3382105]

B:BD[16.3759] → [17.3625:3686]

                bool is_mundane   = (sparm == SPARM_NORMAL);

[16.3759]

[17.3686]

                bool is_plain     = (sparm == SPARM_NORMAL);

Replacement in crawl-ref/source/effects.cc at line 1973 [18.3382105]

B:BD[16.4209] → [17.3730:3783]

                if (!is_mundane && agent != GOD_XOM)

[16.4209]

[16.4245]

                if (!is_plain && agent != GOD_XOM)

Replacement in crawl-ref/source/effects.cc at line 1986 [18.3382105]

B:BD[16.4753] → [17.3830:3878]

                if (is_mundane || is_redundant)

[16.4753]

[16.4788]

                if (is_plain || is_redundant)

Replacement in crawl-ref/source/effects.cc at line 1990 [18.3382105]

B:BD[16.4886] → [16.4886:4944]

                        // Make sure the item is mundane.

[16.4886]

[16.4944]

                        // Make sure the item is plain.

Replacement in crawl-ref/source/effects.cc at line 1994 [18.3382105]

B:BD[16.5075] → [16.5075:5117]

                        // mundane items.

[16.5075]

[16.5117]

                        // plain items.

Replacement in crawl-ref/source/effects.cc at line 2000 [18.3382105]

B:BD[16.5253] → [17.3879:3960]

                    else if (is_mundane && agent != GOD_XOM && one_chance_in(3))

[16.5253]

[16.5324]

                    else if (is_plain && agent != GOD_XOM && one_chance_in(3))

Replacement in crawl-ref/source/effects.cc at line 2002 [18.3382105]

B:BD[16.5346] → [17.3961:4032]

                        // If the item is mundane and there aren't any

[16.5346]

[17.4032]

                        // If the item is plain and there aren't any

Replacement in crawl-ref/source/artefact.cc at line 1948 [18.893152]
B:BD[19.3114] → [3.2609:2640]
```
    if (item_is_mundane(item))
```
[19.3114]
[3.2640]
```
    if (item_is_mundane(item) && !one_chance_in(4))
```

Replacement in crawl-ref/source/artefact.cc at line 1951 [18.893152]

∅:D[3.2665] → [19.3114:3165]

B:BD[19.3114] → [19.3114:3165]

B:BD[19.3165] → [20.19108:19216]

    ASSERT(!item.props.exists( KNOWN_PROPS_KEY ));
    ASSERT(!item.props.exists( ARTEFACT_NAME_KEY ));
    ASSERT(!item.props.exists( ARTEFACT_APPEAR_KEY ));

[3.2665]

[7.60716]

    ASSERT(!item.props.exists(KNOWN_PROPS_KEY));
    ASSERT(!item.props.exists(ARTEFACT_NAME_KEY));
    ASSERT(!item.props.exists(ARTEFACT_APPEAR_KEY));

Replacement in crawl-ref/source/artefact.cc at line 1957 [18.893152]
B:BD[7.60833] → [7.60833:60883]
```
    for (vec_size i = 0; i < ART_PROPERTIES; i++)
```
[7.60833]
[19.3383]
```
    for (vec_size i = 0; i < ART_PROPERTIES; ++i)
```

After some thought, allow mundane items to be artefacts again, but more

Dependencies

In channels

Change contents

Replacement in crawl-ref/source/makeitem.cc at line 940 [6.927]

Replacement in crawl-ref/source/makeitem.cc at line 947 [6.927]

Replacement in crawl-ref/source/makeitem.cc at line 957 [6.927]

Replacement in crawl-ref/source/makeitem.cc at line 2225 [6.927]

Insertion in crawl-ref/source/makeitem.cc at line 2228 [6.927]

Deletion in crawl-ref/source/makeitem.cc at line 3011 [6.927]

Insertion in crawl-ref/source/makeitem.cc at line 3017 [6.927]

Deletion in crawl-ref/source/makeitem.cc at line 3033 [6.927]

Insertion in crawl-ref/source/makeitem.cc at line 3040 [6.927]