finchie/pijul_extension - Change QY4Z5ZXZ7G6DZFCTRPX7D6TIDZ5DHSDTLOWFDANIPUHOEKQRAIXAC

Refactor `event_loop/threadsafe_function` file into `event_loop::js_function` module

Moves the existing threadsafe_function.rs into js_function/mod.rs, and splits initialize_source_control into its own file. Most of the noise is changing terminology from "threadsafe function" to "js function" to better clarify its purpose.

Created by finchie yesterday at 01:12

QY4Z5ZXZ7G6DZFCTRPX7D6TIDZ5DHSDTLOWFDANIPUHOEKQRAIXAC

Dependencies

In channels

main

Change contents

Replacement in editors/vscode/src/event_loop/mod.rs at line 13 [2.171]
∅:D[8.83] → [4.1534:1559]
B:BD[3.1733] → [4.1534:1559]
```
mod threadsafe_function;
```
[8.83]
[2.259]
```
mod js_function;
```

Replacement in editors/vscode/src/event_loop/mod.rs at line 28 [2.171]

B:BD[2.455] → [4.1621:1758]

async fn event_loop(
    threadsafe_functions: threadsafe_function::ThreadsafeFunctions,
    mut receiver: UnboundedReceiver<Event>,
) {

[2.455]

[2.517]

async fn event_loop(js_functions: js_function::Functions, mut receiver: UnboundedReceiver<Event>) {

Replacement in editors/vscode/src/event_loop/mod.rs at line 47 [2.171]

B:BD[6.1532] → [8.84:314]

                    event::open_workspace_folder::handle(
                        raw_uri,
                        &mut repositories,
                        &threadsafe_functions,
                    )
                    .await

[6.1532]

[4.2519]

                    event::open_workspace_folder::handle(raw_uri, &mut repositories, &js_functions)
                        .await

Replacement in editors/vscode/src/event_loop/mod.rs at line 64 [2.171]

B:BD[7.5487] → [7.5487:5586]

    let threadsafe_functions = threadsafe_function::ThreadsafeFunctions::get(env, vscode_object)?;

[7.5487]

[4.2738]

    let js_functions = js_function::Functions::get(env, vscode_object)?;

Replacement in editors/vscode/src/event_loop/mod.rs at line 76 [2.171]

B:BD[5.161] → [5.161:255]

    std::thread::spawn(move || runtime.block_on(event_loop(threadsafe_functions, receiver)));

[5.161]

[4.2926]

    std::thread::spawn(move || runtime.block_on(event_loop(js_functions, receiver)));

File addition: js_function (d--x------)
[2.138]
File move: threadsafe_function.rs → mod.rs
BF:BFD[2.138] → [4.725:771]
BF:BF[4.771] → [4.772:772]
[0.435]
[4.772]
Replacement in editors/vscode/src/event_loop/js_function/mod.rs at line 5 [4.772]
B:BD[4.833] → [4.833:866]
```
pub struct ThreadsafeFunctions {
```
[4.833]
[7.46]
```
mod initialize_source_control;
pub struct Functions {
```
Replacement in editors/vscode/src/event_loop/js_function/mod.rs at line 12 [4.772]
B:BD[4.968] → [4.968:995]
```
impl ThreadsafeFunctions {
```
[4.968]
[7.116]
```
impl Functions {
```

Deletion in editors/vscode/src/event_loop/js_function/mod.rs at line 48 [4.772]

B:BD[7.1049] → [7.1049:1673]

B:BD[7.1673] → [10.80:393]

∅:D[10.393] → [7.1770:2511]

B:BD[7.1770] → [7.1770:2511]

∅:D[6.1401] → [4.1525:1533]

∅:D[7.2511] → [4.1525:1533]

B:BD[4.1525] → [4.1525:1533]


mod initialize_source_control {
    use napi::bindgen_prelude::{FnArgs, FunctionCallContext};
    use crate::vscode_sys;
    pub type Arguments = (vscode_sys::reference::UriRef, String, String, String);
    pub type Return = (
        vscode_sys::reference::SourceControlRef,
        vscode_sys::reference::SourceControlResourceGroupRef,
        vscode_sys::reference::SourceControlResourceGroupRef,
    );
    pub type Prototype = napi::threadsafe_function::ThreadsafeFunction<
        FnArgs<Arguments>,
        Return,
        FnArgs<Arguments>,
        napi::Status,
        false,
        false,
        0,
    >;
    pub fn build(env: &napi::Env) -> Result<Prototype, napi::Error> {
        env.create_function_from_closure("initialize_source_control", callback)?
            .build_threadsafe_function()
            .build()
    }
    fn callback(function_call_context: FunctionCallContext) -> Result<Return, napi::Error> {
        let (repository_uri_ref, pijul_label, changes_label, untracked_label): Arguments =
            function_call_context.args()?;
        let source_control = vscode_sys::scm::create_source_control(
            function_call_context.env,
            "pijul",
            &pijul_label,
            &repository_uri_ref.get_inner(function_call_context.env)?,
        )?;
        let unrecorded_changes = source_control.create_resource_group("changes", &changes_label)?;
        let untracked_paths =
            source_control.create_resource_group("untracked", &untracked_label)?;
        Ok((
            source_control.create_ref()?,
            unrecorded_changes.create_ref()?,
            untracked_paths.create_ref()?,
        ))
    }
}

File addition: initialize_source_control.rs (----------)

[0.435]

use napi::bindgen_prelude::{FnArgs, FunctionCallContext};
use crate::vscode_sys;
pub type Arguments = (vscode_sys::reference::UriRef, String, String, String);
pub type Return = (
    vscode_sys::reference::SourceControlRef,
    vscode_sys::reference::SourceControlResourceGroupRef,
    vscode_sys::reference::SourceControlResourceGroupRef,
);
pub type Prototype = napi::threadsafe_function::ThreadsafeFunction<
    FnArgs<Arguments>,
    Return,
    FnArgs<Arguments>,
    napi::Status,
    false,
    false,
    0,
>;
pub fn build(env: &napi::Env) -> Result<Prototype, napi::Error> {
    env.create_function_from_closure("initialize_source_control", callback)?
        .build_threadsafe_function()
        .build()
}
fn callback(function_call_context: FunctionCallContext) -> Result<Return, napi::Error> {
    let (repository_uri_ref, pijul_label, changes_label, untracked_label): Arguments =
        function_call_context.args()?;
    let source_control = vscode_sys::scm::create_source_control(
        function_call_context.env,
        "pijul",
        &pijul_label,
        &repository_uri_ref.get_inner(function_call_context.env)?,
    )?;
    let unrecorded_changes = source_control.create_resource_group("changes", &changes_label)?;
    let untracked_paths = source_control.create_resource_group("untracked", &untracked_label)?;
    Ok((
        source_control.create_ref()?,
        unrecorded_changes.create_ref()?,
        untracked_paths.create_ref()?,
    ))
}

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 7 [8.383]
B:BD[8.516] → [8.516:581]
```
use crate::event_loop::threadsafe_function::ThreadsafeFunctions;
```
[8.516]
[8.581]
```
use crate::event_loop::js_function::Functions;
```
Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 9 [8.383]
B:BD[8.582] → [8.582:647]
```
#[tracing::instrument(skip(repositories, threadsafe_functions))]
```
[8.582]
[8.647]
```
#[tracing::instrument(skip(repositories, js_functions))]
```
Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 13 [8.383]
B:BD[8.744] → [8.744:792]
```
    threadsafe_functions: &ThreadsafeFunctions,
```
[8.744]
[8.792]
```
    js_functions: &Functions,
```

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 85 [8.383]

B:BD[9.2035] → [9.2035:2171]

        let repository_uri = match threadsafe_functions
            .uri_file(repository_path.to_string())
            .await
        {

[9.2035]

[9.2171]

        let repository_uri = match js_functions.uri_file(repository_path.to_string()).await {

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 93 [8.383]

B:BD[8.1915] → [9.2393:2488]

        let (source_control, unrecorded_changes, untracked_paths) = match threadsafe_functions

[8.1915]

[9.2488]

        let (source_control, unrecorded_changes, untracked_paths) = match js_functions

Refactor `event_loop/threadsafe_function` file into `event_loop::js_function` module

Dependencies

In channels

Change contents

Replacement in editors/vscode/src/event_loop/mod.rs at line 13 [2.171]

Replacement in editors/vscode/src/event_loop/mod.rs at line 28 [2.171]

Replacement in editors/vscode/src/event_loop/mod.rs at line 47 [2.171]

Replacement in editors/vscode/src/event_loop/mod.rs at line 64 [2.171]

Replacement in editors/vscode/src/event_loop/mod.rs at line 76 [2.171]

File addition: js_function (d--x------)

File move: threadsafe_function.rs → mod.rs

Replacement in editors/vscode/src/event_loop/js_function/mod.rs at line 5 [4.772]

Replacement in editors/vscode/src/event_loop/js_function/mod.rs at line 12 [4.772]

Deletion in editors/vscode/src/event_loop/js_function/mod.rs at line 48 [4.772]

File addition: initialize_source_control.rs (----------)

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 7 [8.383]

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 9 [8.383]

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 13 [8.383]

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 85 [8.383]

Replacement in editors/vscode/src/event_loop/event/open_workspace_folder.rs at line 93 [8.383]