itai.sharim/TagFight - Change Y4T55M6RWGCCDBFO6OPEEVDBO3SZ4F3XESUZJST3LUQYGTIFG72AC

Rune Editor - Make ports subclass aware. Cleanup.

Created by itai.sharim on October 6, 2023

Y4T55M6RWGCCDBFO6OPEEVDBO3SZ4F3XESUZJST3LUQYGTIFG72AC

Dependencies

In channels

main

Change contents

Replacement in Assets/Scripts/Combat/Runes/RuneEffect.cs at line 11 [4.290]

B:BD[4.444] → [5.12040:12096]

        public string DisplayName = "New Rune Effect";

[4.444]

[4.473]

        public string DisplayName = System.Guid.NewGuid().ToString();

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Set/PawnResourceSet.cs at line 39 [3.520]

B:BD[3.1678] → [3.1678:1755]

                UnityEngine.Debug.LogError($"{Guid} Inner types are null");

[3.1678]

[3.1755]

                UnityEngine.Debug.LogError($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Set/ContextResourceSet.cs at line 42 [3.3987]

B:BD[3.5456] → [3.5456:5533]

                UnityEngine.Debug.LogError($"{Guid} Inner types are null");

[3.5456]

[3.5533]

                UnityEngine.Debug.LogError($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Operator/Zip.cs at line 34 [3.8989]

B:BD[3.9999] → [3.9999:10076]

                UnityEngine.Debug.LogError($"{Guid} Inner types are null");

[3.9999]

[3.10076]

                UnityEngine.Debug.LogError($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Operator/Operate.cs at line 37 [3.12966]

B:BD[3.14067] → [3.14067:14144]

                UnityEngine.Debug.LogError($"{Guid} Inner types are null");

[3.14067]

[3.14144]

                UnityEngine.Debug.LogError($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Operator/Fold.cs at line 22 [3.15276]

B:BD[3.15956] → [3.15956:16033]

                UnityEngine.Debug.LogError($"{Guid} Inner types are null");

[3.15956]

[3.16033]

                UnityEngine.Debug.LogError($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PawnResourceGet.cs at line 17 [3.17762]

B:BD[3.18307] → [3.18307:18379]

                UnityEngine.Debug.Log($"{Guid} Inner types are null");

[3.18307]

[3.18379]

                UnityEngine.Debug.Log($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PathAreaGet.cs at line 8 [3.20675]
B:BD[3.20822] → [3.20822:20880]
```
    public class PathAreaGet : OutputStep<IAreaOfEffect>
```
[3.20822]
[3.20880]
```
    public class PathAreaGet : OutputStep<PathArea>
```
Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PathAreaGet.cs at line 25 [3.20675]
B:BD[3.21326] → [3.21326:21386]
```
        public override string ToString() => "Circle AOE";
```
[3.21326]
[3.21386]
```
        public override string ToString() => "Path AOE";
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PathAreaGet.cs at line 27 [3.20675]

B:BD[3.21388] → [3.21388:21475]

        public override IAreaOfEffect Run(EffectInput blackBoard) => new PathArea() {

[3.21388]

[3.21475]

        public override PathArea Run(EffectInput blackBoard) => new() {

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/ContextResourceGet.cs at line 21 [3.22067]

B:BD[3.22825] → [3.22825:22902]

                UnityEngine.Debug.LogError($"{Guid} Inner types are null");

[3.22825]

[3.22902]

                UnityEngine.Debug.LogError($"{this} Inner types are null");

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/ConeAreaGet.cs at line 8 [3.26925]
B:BD[3.27072] → [3.27072:27130]
```
    public class ConeAreaGet : OutputStep<IAreaOfEffect>
```
[3.27072]
[3.27130]
```
    public class ConeAreaGet : OutputStep<ConeArea>
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/ConeAreaGet.cs at line 31 [3.26925]

B:BD[3.27689] → [3.27689:28015]

        public override IAreaOfEffect Run(EffectInput blackBoard) {
            return new ConeArea() {
                Radius = (float)(_radius.Node != null ? _radius.Node.Run(blackBoard) : default),
                Angle = (float)(_angle.Node != null ? _angle.Node.Run(blackBoard) : default),
            };
        }

[3.27689]

[3.28015]

        public override ConeArea Run(EffectInput blackBoard) => new() {
            Radius = (float)(_radius.Node != null ? _radius.Node.Run(blackBoard) : default),
            Angle = (float)(_angle.Node != null ? _angle.Node.Run(blackBoard) : default),
        };

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/CircleAreaGet.cs at line 8 [3.28356]
B:BD[3.28503] → [3.28503:28563]
```
    public class CircleAreaGet : OutputStep<IAreaOfEffect>
```
[3.28503]
[3.28563]
```
    public class CircleAreaGet : OutputStep<CircleArea>
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/CircleAreaGet.cs at line 22 [3.28356]

B:BD[3.28903] → [3.28903:28992]

        public override IAreaOfEffect Run(EffectInput blackBoard) => new CircleArea() {

[3.28903]

[3.28992]

        public override CircleArea Run(EffectInput blackBoard) => new() {

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 134 [6.237]
B:BD[5.33697] → [2.11654:11688]
```
  Position: {x: 68.51999, y: 327}
```
[5.33697]
[5.33726]
```
  Position: {x: 69, y: 335}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 136 [6.237]
B:BD[5.33771] → [2.11689:11702]
```
  _value: 10
```
[5.33771]
[5.33783]
```
  _value: 5
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 204 [6.237]
B:BD[2.12073] → [2.12073:12101]
```
  Position: {x: 69, y: 463}
```
[2.12073]
[2.12101]
```
  Position: {x: 69, y: 412}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 219 [6.237]
B:BD[5.35966] → [5.35966:35996]
```
  DisplayName: Set Circle AOE
```
[5.35966]
[5.35996]
```
  DisplayName: Set  AOE
```
Insertion in Assets/ScriptableObjects/Runes/TestRune.asset at line 227 [6.237]
[2.12229]
[7.5797]
```
  - {fileID: 6644894672603807178}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 265 [6.237]
B:BD[5.36944] → [2.12230:12270]
```
    Node: {fileID: 6326256876420960218}
```
[5.36944]
[6.733]
```
    Node: {fileID: 6644894672603807178}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 403 [6.237]
B:BD[2.12641] → [2.12641:12670]
```
  Position: {x: 236, y: 362}
```
[2.12641]
[2.12670]
```
  Position: {x: 249, y: 189}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 406 [6.237]
B:BD[2.12726] → [2.12726:12767]
```
    Node: {fileID: -5229030080647256284}
```
[2.12726]
[2.12767]
```
    Node: {fileID: 0}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 408 [6.237]
B:BD[2.12777] → [2.12777:12818]
```
    Node: {fileID: -3588640908992573351}
```
[2.12777]
[5.40075]
```
    Node: {fileID: 0}
```

Insertion in Assets/ScriptableObjects/Runes/TestRune.asset at line 432 [6.237]

[5.40756]

--- !u!114 &6644894672603807178
MonoBehaviour:
  m_ObjectHideFlags: 0
  m_CorrespondingSourceObject: {fileID: 0}
  m_PrefabInstance: {fileID: 0}
  m_PrefabAsset: {fileID: 0}
  m_GameObject: {fileID: 0}
  m_Enabled: 1
  m_EditorHideFlags: 0
  m_Script: {fileID: 11500000, guid: f4cad4d5d3585fd4b81d7232454ed130, type: 3}
  m_Name: PathAreaGet
  m_EditorClassIdentifier: 
  Position: {x: 216, y: 362}
  Guid: 4f76c739-80b8-43b7-9340-10ff9370d8db
  _width:
    Node: {fileID: -5229030080647256284}
  _length:
    Node: {fileID: -3588640908992573351}

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 477 [6.237]
B:BD[5.41596] → [2.12819:12848]
```
  Position: {x: 236, y: 250}
```
[5.41596]
[5.41625]
```
  Position: {x: 249, y: 77}
```

Replacement in Assets/Scenes/SampleScene.unity at line 5764 [8.780110080]

B:BD[8.780121071] → [2.13014:13095]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

[8.780121071]

[9.33888019]

  m_LocalRotation: {x: 0.22914572, y: -0.07070914, z: 0.01669216, w: 0.970677}

Replacement in Assets/Scenes/SampleScene.unity at line 7939 [8.780110080]

B:BD[8.780162310] → [2.13096:13177]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

[8.780162310]

[9.33918016]

  m_LocalRotation: {x: 0.22914572, y: -0.07070914, z: 0.01669216, w: 0.970677}

Replacement in Assets/Scenes/SampleScene.unity at line 8480 [8.780110080]
B:BD[10.107447] → [2.13178:13193]
```
      value: 1
```
[10.107447]
[10.107462]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8485 [8.780110080]
B:BD[10.107630] → [2.13194:13209]
```
      value: 1
```
[10.107630]
[10.107645]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8490 [8.780110080]
B:BD[10.107820] → [2.13210:13228]
```
      value: -170
```
[10.107820]
[10.107835]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8570 [8.780110080]
B:BD[10.115852] → [2.13229:13244]
```
      value: 1
```
[10.115852]
[10.115867]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8575 [8.780110080]
B:BD[10.116037] → [2.13245:13260]
```
      value: 1
```
[10.116037]
[10.116052]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8685 [8.780110080]
B:BD[10.117142] → [2.13261:13276]
```
      value: 1
```
[10.117142]
[11.26089]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8690 [8.780110080]
B:BD[10.117278] → [2.13277:13292]
```
      value: 1
```
[10.117278]
[10.117293]
```
      value: 0
```
Replacement in Assets/Scenes/SampleScene.unity at line 8695 [8.780110080]
B:BD[10.117470] → [2.13293:13310]
```
      value: -60
```
[10.117470]
[10.117485]
```
      value: 0
```

Replacement in Assets/Editor/Rune/RuneEffectView.cs at line 141 [4.33420]

B:BD[4.34987] → [4.34987:35046]

                && endPort.portType == startPort.portType

[4.34987]

[4.35046]

                && (startPort.direction == Direction.Input && startPort.portType.IsAssignableFrom(endPort.portType)
                    || startPort.direction == Direction.Output && endPort.portType.IsAssignableFrom(startPort.portType))

Deletion in Assets/Editor/Rune/RuneEditor.cs at line 125 [4.40896]
B:BD[4.44815] → [5.43667:43739]
```
            runeEffect.DisplayName = System.Guid.NewGuid().ToString();
```

Rune Editor - Make ports subclass aware. Cleanup.

Dependencies

In channels

Change contents

Replacement in Assets/Scripts/Combat/Runes/RuneEffect.cs at line 11 [4.290]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Set/PawnResourceSet.cs at line 39 [3.520]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Set/ContextResourceSet.cs at line 42 [3.3987]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Operator/Zip.cs at line 34 [3.8989]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Operator/Operate.cs at line 37 [3.12966]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Operator/Fold.cs at line 22 [3.15276]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PawnResourceGet.cs at line 17 [3.17762]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PathAreaGet.cs at line 8 [3.20675]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PathAreaGet.cs at line 25 [3.20675]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/PathAreaGet.cs at line 27 [3.20675]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/ContextResourceGet.cs at line 21 [3.22067]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/ConeAreaGet.cs at line 8 [3.26925]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/ConeAreaGet.cs at line 31 [3.26925]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/CircleAreaGet.cs at line 8 [3.28356]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/Get/CircleAreaGet.cs at line 22 [3.28356]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 134 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 136 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 204 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 219 [6.237]

Insertion in Assets/ScriptableObjects/Runes/TestRune.asset at line 227 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 265 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 403 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 406 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 408 [6.237]

Insertion in Assets/ScriptableObjects/Runes/TestRune.asset at line 432 [6.237]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 477 [6.237]

Replacement in Assets/Scenes/SampleScene.unity at line 5764 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 7939 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8480 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8485 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8490 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8570 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8575 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8685 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8690 [8.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 8695 [8.780110080]

Replacement in Assets/Editor/Rune/RuneEffectView.cs at line 141 [4.33420]

Deletion in Assets/Editor/Rune/RuneEditor.cs at line 125 [4.40896]