eschnett/cactusamrex - Change 3HPNY5XHNPWR6RVX4LYEVDFJQWSB2CMS7J6XPAKATQ2UPFTXD33QC

CarpetX: Output more information when nans are found

Created by Erik Schnetter on January 8, 2020

3HPNY5XHNPWR6RVX4LYEVDFJQWSB2CMS7J6XPAKATQ2UPFTXD33QC

Dependencies

In channels

master

main

Change contents

Insertion in CarpetX/src/schedule.cxx at line 31 [5.531]
[3.576]
[4.3731]
```
#include <limits>
```

Replacement in CarpetX/src/schedule.cxx at line 333 [5.531]

B:BD[6.1051] → [7.19:52]

  atomic<bool> found_nan{false};

[6.1051]

  size_t nan_count{0};
  array<int, 3> nan_imin, nan_imax;
  array<CCTK_REAL, 3> nan_xmin, nan_xmax;
  for (int d = 0; d < 3; ++d) {
    nan_imin[d] = numeric_limits<int>::max();
    nan_imax[d] = numeric_limits<int>::min();
    nan_xmin[d] = +1.0 / 0.0;
    nan_xmax[d] = -1.0 / 0.0;
  }
  const auto nan_update{
      [&](const GridDescBase &grid, const Loop::PointDesc &p) {
#pragma omp critical
        {
          ++nan_count;
          nan_imin[0] = min(nan_imin[0], grid.lbnd[0] + p.i);
          nan_imin[1] = min(nan_imin[1], grid.lbnd[1] + p.j);
          nan_imin[2] = min(nan_imin[2], grid.lbnd[2] + p.k);
          nan_imax[0] = max(nan_imax[0], grid.lbnd[0] + p.i);
          nan_imax[1] = max(nan_imax[1], grid.lbnd[1] + p.j);
          nan_imax[2] = max(nan_imax[2], grid.lbnd[2] + p.k);
          nan_xmin[0] = fmin(nan_xmin[0], p.x);
          nan_xmin[1] = fmin(nan_xmin[1], p.y);
          nan_xmin[2] = fmin(nan_xmin[2], p.z);
          nan_xmax[0] = fmax(nan_xmax[0], p.x);
          nan_xmax[1] = fmax(nan_xmax[1], p.y);
          nan_xmax[2] = fmax(nan_xmax[2], p.z);
        }
      }};
  const auto nan_check{[&](const GridDescBase &grid,
                           const GF3D1<const CCTK_REAL> &ptr_,
                           const Loop::PointDesc &p) {
    if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
      nan_update(grid, p);
  }};

Replacement in CarpetX/src/schedule.cxx at line 376 [5.531]

∅:D[8.3482] → [9.7661:7941]

∅:D[10.48] → [9.7661:7941]

B:BD[9.7661] → [9.7661:7941]

      grid.loop_idx(where_t::everywhere, groupdata.indextype,
                    groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                      if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                        found_nan = true;
                    });

[8.3482]

[6.1782]

      grid.loop_idx(
          where_t::everywhere, groupdata.indextype, groupdata.nghostzones,
          [&](const Loop::PointDesc &p) { nan_check(grid, ptr_, p); });

Replacement in CarpetX/src/schedule.cxx at line 381 [5.531]

B:BD[9.7969] → [9.7969:8257]

        grid.loop_idx(where_t::interior, groupdata.indextype,
                      groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                        if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                          found_nan = true;
                      });

[9.7969]

[9.8257]

        grid.loop_idx(
            where_t::interior, groupdata.indextype, groupdata.nghostzones,
            [&](const Loop::PointDesc &p) { nan_check(grid, ptr_, p); });

Replacement in CarpetX/src/schedule.cxx at line 385 [5.531]

B:BD[9.8286] → [9.8286:8574]

        grid.loop_idx(where_t::boundary, groupdata.indextype,
                      groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                        if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                          found_nan = true;
                      });

[9.8286]

[9.8574]

        grid.loop_idx(
            where_t::boundary, groupdata.indextype, groupdata.nghostzones,
            [&](const Loop::PointDesc &p) { nan_check(grid, ptr_, p); });

Replacement in CarpetX/src/schedule.cxx at line 389 [5.531]

B:BD[9.8604] → [9.8604:8820]

B:BD[9.8820] → [11.1234:1304]

        grid.loop_idx(where_t::ghosts, groupdata.indextype,
                      groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                        if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                          found_nan = true;
                      });

[9.8604]

[11.1304]

        grid.loop_idx(
            where_t::ghosts, groupdata.indextype, groupdata.nghostzones,
            [&](const Loop::PointDesc &p) { nan_check(grid, ptr_, p); });

Replacement in CarpetX/src/schedule.cxx at line 395 [5.531]

B:BD[7.330] → [2.80:254]

  if (CCTK_BUILTIN_EXPECT(found_nan, false)) {
    CCTK_VINFO("%s: Grid function \"%s\" has nans on refinement level %d, time "
               "level %d; expected valid %s",

[7.330]

[2.254]

  if (CCTK_BUILTIN_EXPECT(nan_count > 0, false)) {
    CCTK_VINFO(
        "%s: Grid function \"%s\" has %td nans on refinement level %d, time "
        "level %d, in box [%d,%d,%d]:[%d,%d,%d] (%g,%g,%g):(%g,%g,%g); "
        "expected valid %s",

Replacement in CarpetX/src/schedule.cxx at line 401 [5.531]

B:BD[2.332] → [2.332:368]

               leveldata.level, tl,

[2.332]

[2.368]

        size_t(nan_count), leveldata.level, tl, nan_imin[0], nan_imin[1],
        nan_imin[2], nan_imax[0], nan_imax[1], nan_imax[2], double(nan_xmin[0]),
        double(nan_xmin[1]), double(nan_xmin[2]), double(nan_xmax[0]),
        double(nan_xmax[1]), double(nan_xmax[2]),

Replacement in CarpetX/src/schedule.cxx at line 504 [5.531]
B:BD[12.6585] → [12.6585:6618]
```
  atomic<bool> found_nan{false};
```
[12.6585]
[12.6618]
```
  atomic<size_t> nan_count{0};
```
Replacement in CarpetX/src/schedule.cxx at line 508 [5.531]
∅:D[9.9223] → [12.6766:6790]
B:BD[12.6766] → [12.6766:6790]
```
      found_nan = true;
```
[9.9223]
[12.6790]
```
      ++nan_count;
```

Replacement in CarpetX/src/schedule.cxx at line 512 [5.531]

B:BD[12.6801] → [9.9224:9269]

∅:D[9.9269] → [14.747:924]

B:BD[12.7034] → [14.747:924]

  if (CCTK_BUILTIN_EXPECT(found_nan, false))
    CCTK_VERROR(
        "%s: Grid Scalar \"%s\" has nans on time level %d; expected valid %s",
        msg().c_str(), CCTK_FullVarName(scalargroupdata.firstvarindex + vi), tl,

[12.6801]

[15.8286]

  if (CCTK_BUILTIN_EXPECT(nan_count > 0, false))
    CCTK_VERROR("%s: Grid Scalar \"%s\" has %td nans on time level %d; "
                "expected valid %s",
                msg().c_str(),
                CCTK_FullVarName(scalargroupdata.firstvarindex + vi),
                size_t(nan_count), tl,