eschnett/cactusamrex - Change 67UXOK4QSZFAPVZXU2MJMD7I2232JCK4QDMIOMVMEQNQUGN7632AC

CarpetX: Use !isfinite instead of isnan when checking grid functions

Created by Erik Schnetter on January 23, 2020

67UXOK4QSZFAPVZXU2MJMD7I2232JCK4QDMIOMVMEQNQUGN7632AC

Dependencies

In channels

master

main

Change contents

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 183 [6.1186]
B:BD[6.5476] → [7.0:28]
```
    assert(!CCTK_isnan(y));
```
[6.5476]
[2.257]
```
    assert(CCTK_isfinite(y));
```
Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 189 [6.1186]
B:BD[2.380] → [2.380:409]
```
    assert(!CCTK_isnan(y1));
```
[2.380]
[2.409]
```
    assert(CCTK_isfinite(y1));
```
Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 216 [6.1186]
B:BD[6.6190] → [7.29:57]
```
    assert(!CCTK_isnan(y));
```
[6.6190]
[6.6213]
```
    assert(CCTK_isfinite(y));
```
Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 322 [6.1186]
∅:D[3.1527] → [7.58:91]
∅:D[8.996] → [7.58:91]
B:BD[6.8554] → [7.58:91]
```
        assert(!CCTK_isnan(y1));
```
[3.1527]
[6.8582]
```
        assert(CCTK_isfinite(y1));
```
Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 356 [6.1186]
B:BD[9.3222] → [7.92:132]
```
          assert(!CCTK_isnan(y1[off]));
```
[9.3222]
[9.3257]
```
          assert(CCTK_isfinite(y1[off]));
```

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 391 [6.1186]

B:BD[4.1588] → [4.1588:1634]

            assert(!CCTK_isnan(y1[off + 1]));

[4.1588]

[4.1634]

            assert(CCTK_isfinite(y1[off + 1]));

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 450 [6.1186]

B:BD[6.10007] → [7.178:240]

        assert(!CCTK_isnan(fineptr[finebox.index(fineind)]));

[6.10007]

[6.10064]

        assert(CCTK_isfinite(fineptr[finebox.index(fineind)]));

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 542 [6.1186]

B:BD[6.13924] → [7.241:304]

          assert(!CCTK_isnan(crseptr[crse.box().index(ind)]));

[6.13924]

[6.13982]

          assert(CCTK_isfinite(crseptr[crse.box().index(ind)]));

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 555 [6.1186]
B:BD[6.14282] → [7.305:335]
```
      assert(!CCTK_isnan(x));
```
[6.14282]
[6.14307]
```
      assert(CCTK_isfinite(x));
```
Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 566 [6.1186]
B:BD[6.14559] → [7.336:369]
```
    //   assert(!CCTK_isnan(x));
```
[6.14559]
[6.14587]
```
    //   assert(CCTK_isfinite(x));
```
Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 568 [6.1186]
B:BD[6.14635] → [7.370:409]
```
      assert(!CCTK_isnan(tmps[1][i]));
```
[6.14635]
[6.14669]
```
      assert(CCTK_isfinite(tmps[1][i]));
```

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 598 [6.1186]

B:BD[6.15725] → [7.410:473]

          assert(!CCTK_isnan(fineptr[fine.box().index(ind)]));

[6.15725]

[6.15783]

          assert(CCTK_isfinite(fineptr[fine.box().index(ind)]));

Replacement in CarpetX/src/schedule.cxx at line 372 [11.531]

B:BD[10.1302] → [10.1302:1361]

    if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))

[10.1302]

[10.1361]

    if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(ptr_(p.I)), false))

Replacement in CarpetX/src/schedule.cxx at line 406 [11.531]

∅:D[5.1214] → [10.2132:2328]

B:BD[10.2132] → [10.2132:2328]

B:BD[10.2328] → [12.4686:4757]

∅:D[12.4757] → [10.2329:2403]

B:BD[13.332] → [10.2329:2403]

    CCTK_VINFO(
        "%s: Grid function \"%s\" has %td nans on refinement level %d, time "
        "level %d, in box [%d,%d,%d]:[%d,%d,%d] (%g,%g,%g):(%g,%g,%g); "
        "expected valid %s",
        msg().c_str(), CCTK_FullVarName(groupdata.firstvarindex + vi),
        size_t(nan_count), leveldata.level, tl, nan_imin[0], nan_imin[1],

[5.1214]

[5.1215]

      CCTK_VINFO(
          "%s: Grid function \"%s\" has %td nans on refinement level %d, time "
          "level %d, in box [%d,%d,%d]:[%d,%d,%d] (%g,%g,%g):(%g,%g,%g); "
          "expected valid %s",
          msg().c_str(), CCTK_FullVarName(groupdata.firstvarindex + vi),
          size_t(nan_count), leveldata.level, tl, nan_imin[0], nan_imin[1],

Replacement in CarpetX/src/schedule.cxx at line 415 [11.531]
∅:D[5.1423] → [12.4758:4814]
B:BD[10.2605] → [12.4758:4814]
```
        string(groupdata.valid.at(tl).at(vi)).c_str());
```
[5.1423]
[13.431]
```
          string(groupdata.valid.at(tl).at(vi)).c_str());
```

Replacement in CarpetX/src/schedule.cxx at line 417 [11.531]

B:BD[13.432] → [13.432:705]

    for (MFIter mfi(*leveldata.mfab0, mfitinfo); mfi.isValid(); ++mfi) {
      const GridPtrDesc1 grid(leveldata, groupdata, mfi);
      const Array4<const CCTK_REAL> &vars = groupdata.mfab.at(tl)->array(mfi);
      const GF3D1<const CCTK_REAL> ptr_ = grid.gf3d(vars, vi);

[13.432]

[13.705]

      for (MFIter mfi(*leveldata.mfab0, mfitinfo); mfi.isValid(); ++mfi) {
        const GridPtrDesc1 grid(leveldata, groupdata, mfi);
        const Array4<const CCTK_REAL> &vars = groupdata.mfab.at(tl)->array(mfi);
        const GF3D1<const CCTK_REAL> ptr_ = grid.gf3d(vars, vi);

Replacement in CarpetX/src/schedule.cxx at line 422 [11.531]

B:BD[13.706] → [13.706:2167]

      if (valid.valid_int)
        grid.loop_idx(where_t::interior, groupdata.indextype,
                      groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                        if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                          CCTK_VINFO("[%d,%d,%d] (%g,%g,%g) %g", p.i, p.j, p.k,
                                     double(p.x), double(p.y), double(p.z),
                                     double(ptr_(p.I)));
                      });
      if (valid.valid_outer)
        grid.loop_idx(where_t::boundary, groupdata.indextype,
                      groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                        if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                          CCTK_VINFO("[%d,%d,%d] (%g,%g,%g) %g", p.i, p.j, p.k,
                                     double(p.x), double(p.y), double(p.z),
                                     double(ptr_(p.I)));
                      });
      if (valid.valid_ghosts)
        grid.loop_idx(where_t::ghosts, groupdata.indextype,
                      groupdata.nghostzones, [&](const Loop::PointDesc &p) {
                        if (CCTK_BUILTIN_EXPECT(CCTK_isnan(ptr_(p.I)), false))
                          CCTK_VINFO("[%d,%d,%d] (%g,%g,%g) %g", p.i, p.j, p.k,
                                     double(p.x), double(p.y), double(p.z),
                                     double(ptr_(p.I)));
                      });
    }

[13.706]

[13.2167]

        if (valid.valid_int)
          grid.loop_idx(
              where_t::interior, groupdata.indextype, groupdata.nghostzones,
              [&](const Loop::PointDesc &p) {
                if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(ptr_(p.I)), false))
                  CCTK_VINFO("[%d,%d,%d] (%g,%g,%g) %g", p.i, p.j, p.k,
                             double(p.x), double(p.y), double(p.z),
                             double(ptr_(p.I)));
              });
        if (valid.valid_outer)
          grid.loop_idx(
              where_t::boundary, groupdata.indextype, groupdata.nghostzones,
              [&](const Loop::PointDesc &p) {
                if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(ptr_(p.I)), false))
                  CCTK_VINFO("[%d,%d,%d] (%g,%g,%g) %g", p.i, p.j, p.k,
                             double(p.x), double(p.y), double(p.z),
                             double(ptr_(p.I)));
              });
        if (valid.valid_ghosts)
          grid.loop_idx(
              where_t::ghosts, groupdata.indextype, groupdata.nghostzones,
              [&](const Loop::PointDesc &p) {
                if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(ptr_(p.I)), false))
                  CCTK_VINFO("[%d,%d,%d] (%g,%g,%g) %g", p.i, p.j, p.k,
                             double(p.x), double(p.y), double(p.z),
                             double(ptr_(p.I)));
              });
      }

Replacement in CarpetX/src/schedule.cxx at line 451 [11.531]

∅:D[14.8871] → [15.707:798]

∅:D[13.2168] → [15.707:798]

B:BD[16.563] → [15.707:798]

B:BD[15.798] → [17.103:213]

B:BD[17.213] → [18.6827:6904]

    CCTK_VERROR(
        "%s: Grid function \"%s\" has nans on refinement level %d, time "
        "level %d; expected valid %s",
        msg().c_str(), CCTK_FullVarName(groupdata.firstvarindex + vi),
        leveldata.level, tl, string(groupdata.valid.at(tl).at(vi)).c_str());

[13.2168]

[13.2169]

      CCTK_VERROR(
          "%s: Grid function \"%s\" has nans on refinement level %d, time "
          "level %d; expected valid %s",
          msg().c_str(), CCTK_FullVarName(groupdata.firstvarindex + vi),
          leveldata.level, tl, string(groupdata.valid.at(tl).at(vi)).c_str());
    }

Replacement in CarpetX/src/schedule.cxx at line 521 [11.531]

B:BD[19.312] → [14.9167:9223]

    if (CCTK_BUILTIN_EXPECT(CCTK_isnan(*ptr), false)) {

[19.312]

[10.2638]

    if (CCTK_BUILTIN_EXPECT(!CCTK_isfinite(*ptr), false)) {

Replacement in CarpetX/src/schedule.cxx at line 1238 [11.531]

∅:D[5.1714] → [20.7020:7152]

B:BD[20.7020] → [20.7020:7152]

      CCTK_VINFO("Grid extent:");
      CCTK_VINFO("  gsh=[%d,%d,%d]", gsh[0], gsh[1], gsh[2]);
      CCTK_VINFO("Domain extent:");

[5.1714]

[5.1715]

        CCTK_VINFO("Grid extent:");
        CCTK_VINFO("  gsh=[%d,%d,%d]", gsh[0], gsh[1], gsh[2]);
        CCTK_VINFO("Domain extent:");

Replacement in CarpetX/src/schedule.cxx at line 1247 [11.531]
∅:D[5.2060] → [20.7335:7371]
B:BD[20.7335] → [20.7335:7371]
```
      CCTK_VINFO("Time stepping:");
```
[5.2060]
[5.2061]
```
        CCTK_VINFO("Time stepping:");
```

Replacement in CarpetX/src/schedule.cxx at line 1285 [11.531]

∅:D[5.2271] → [21.0:79]

B:BD[22.5624] → [21.0:79]

∅:D[21.79] → [23.451:506]

B:BD[23.451] → [23.451:506]

B:BD[23.506] → [21.80:344]

B:BD[21.344] → [13.2174:2250]

∅:D[13.2250] → [21.345:787]

B:BD[23.792] → [21.345:787]

      const double pts0 = ghext->leveldata.at(0).mfab0->boxArray().d_numPts();
      for (const auto &leveldata : ghext->leveldata) {
        const int sz = leveldata.mfab0->size();
        const double pts = leveldata.mfab0->boxArray().d_numPts();
        if (leveldata.level == 0) {
          CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%)",
                     leveldata.level, sz, pts,
                     100 * pts / (pow(2.0, dim * leveldata.level) * pts0));
        } else {
          const double ptsc = ghext->leveldata.at(leveldata.level - 1)
                                  .mfab0->boxArray()
                                  .d_numPts();
          CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%, %.0f%%)",
                     leveldata.level, sz, pts,
                     100 * pts / (pow(2.0, dim * leveldata.level) * pts0),
                     100 * pts / (pow(2.0, dim) * ptsc));

[5.2271]

[21.787]

        const double pts0 = ghext->leveldata.at(0).mfab0->boxArray().d_numPts();
        for (const auto &leveldata : ghext->leveldata) {
          const int sz = leveldata.mfab0->size();
          const double pts = leveldata.mfab0->boxArray().d_numPts();
          if (leveldata.level == 0) {
            CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%)",
                       leveldata.level, sz, pts,
                       100 * pts / (pow(2.0, dim * leveldata.level) * pts0));
          } else {
            const double ptsc = ghext->leveldata.at(leveldata.level - 1)
                                    .mfab0->boxArray()
                                    .d_numPts();
            CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%, %.0f%%)",
                       leveldata.level, sz, pts,
                       100 * pts / (pow(2.0, dim * leveldata.level) * pts0),
                       100 * pts / (pow(2.0, dim) * ptsc));
          }

Deletion in CarpetX/src/schedule.cxx at line 1303 [11.531]
B:BD[21.797] → [5.2272:2280]
```
      }
```

Replacement in CarpetX/src/schedule.cxx at line 1532 [11.531]

∅:D[5.2376] → [24.8129:8228]

∅:D[20.8600] → [24.8129:8228]

B:BD[24.8129] → [24.8129:8228]

B:BD[24.8228] → [23.801:874]

B:BD[23.874] → [25.294:329]

∅:D[25.329] → [23.874:929]

B:BD[23.874] → [23.874:929]

B:BD[23.929] → [21.798:1062]

B:BD[21.1062] → [13.2251:2327]

∅:D[13.2327] → [21.1063:1505]

B:BD[23.1215] → [21.1063:1505]

      CCTK_VINFO("  old levels %d, new levels %d", old_numlevels,
                 new_numlevels);
      double pts0 = ghext->leveldata.at(0).mfab0->boxArray().d_numPts();
      assert(current_level == -1);
      for (const auto &leveldata : ghext->leveldata) {
        const int sz = leveldata.mfab0->size();
        const double pts = leveldata.mfab0->boxArray().d_numPts();
        if (leveldata.level == 0) {
          CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%)",
                     leveldata.level, sz, pts,
                     100 * pts / (pow(2.0, dim * leveldata.level) * pts0));
        } else {
          const double ptsc = ghext->leveldata.at(leveldata.level - 1)
                                  .mfab0->boxArray()
                                  .d_numPts();
          CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%, %.0f%%)",
                     leveldata.level, sz, pts,
                     100 * pts / (pow(2.0, dim * leveldata.level) * pts0),
                     100 * pts / (pow(2.0, dim) * ptsc));

[5.2376]

[21.1505]

        CCTK_VINFO("  old levels %d, new levels %d", old_numlevels,
                   new_numlevels);
        double pts0 = ghext->leveldata.at(0).mfab0->boxArray().d_numPts();
        assert(current_level == -1);
        for (const auto &leveldata : ghext->leveldata) {
          const int sz = leveldata.mfab0->size();
          const double pts = leveldata.mfab0->boxArray().d_numPts();
          if (leveldata.level == 0) {
            CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%)",
                       leveldata.level, sz, pts,
                       100 * pts / (pow(2.0, dim * leveldata.level) * pts0));
          } else {
            const double ptsc = ghext->leveldata.at(leveldata.level - 1)
                                    .mfab0->boxArray()
                                    .d_numPts();
            CCTK_VINFO("  level %d: %d boxes, %.0f cells (%.4g%%, %.0f%%)",
                       leveldata.level, sz, pts,
                       100 * pts / (pow(2.0, dim * leveldata.level) * pts0),
                       100 * pts / (pow(2.0, dim) * ptsc));
          }

Deletion in CarpetX/src/schedule.cxx at line 1555 [11.531]
∅:D[5.2383] → [24.8275:8281]
∅:D[26.16975] → [24.8275:8281]
B:BD[24.8275] → [24.8275:8281]
```
    }
```

CarpetX: Use !isfinite instead of isnan when checking grid functions

Dependencies

In channels

Change contents

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 183 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 189 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 216 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 322 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 356 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 391 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 450 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 542 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 555 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 566 [6.1186]

Replacement in CarpetX/src/prolongate_3d_rf2.cxx at line 568 [6.1186]