itai.sharim/TagFight - Change BJF3R3X6UV7VZ4FUKHMPMYFN3RDEKLNXHLHA2H7QLQVRADSPZD4QC

events popping several times bug

Created by itai.sharim on October 1, 2022

BJF3R3X6UV7VZ4FUKHMPMYFN3RDEKLNXHLHA2H7QLQVRADSPZD4QC

Dependencies

In channels

main

Change contents

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 2 [3.24775]
[3.24873]
[3.24873]
```
using System.Linq;
```

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 18 [3.24775]

[4.3379]

                    print($"WeaponView unregister {_selectedWeaver}");

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 24 [3.24775]

[4.3571]

                    print($"WeaponView register {_selectedWeaver}");

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 34 [3.24775]

[5.139064]

[6.61742]

        }
        protected void OnDestroy() {
            eventAggregator.OnUnitSelected -= EventAggregator_OnUnitSelected;
            eventAggregator.OnPartyMemberSelected -= PartyMemberPortrait_OnPartyMemberSelected;
            SelectedWeaver = null;
            Clear();

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 44 [3.24775]
[6.61839]
[6.61839]
```
            print ($"WeaponView Weaver_OnWeaponEquipped");
```
Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 50 [3.24775]
∅:D[5.139168] → [6.62077:62099]
B:BD[6.62077] → [6.62077:62099]
```
            Clear();
```
Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 57 [3.24775]
B:BD[6.62463] → [6.62463:62485]
```
            Clear();
```
Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 64 [3.24775]
[6.62720]
[6.62720]
```
            var currentWeaponIndex = 0;
```

Replacement in Assets/Scripts/UI/HUD/WeaponView.cs at line 67 [3.24775]

B:BD[6.62790] → [6.62790:62905]

                var weaponSelectUI = Instantiate(weaponSelectUIPrefab, transform).GetComponent<WeaponSelectUI>();

[6.62790]

[6.62905]

                WeaponSelectUI weaponSelectUI;
                if (currentWeaponIndex < transform.childCount) {
                    weaponSelectUI = transform.GetChild(currentWeaponIndex).GetComponent<WeaponSelectUI>();
                }
                else {
                    weaponSelectUI = Instantiate(weaponSelectUIPrefab, transform).GetComponent<WeaponSelectUI>();
                }

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 75 [3.24775]

[6.62956]

                weaponSelectUI.gameObject.SetActive(true);
                currentWeaponIndex++;

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 78 [3.24775]

[6.62971]


            for (; currentWeaponIndex < transform.childCount; currentWeaponIndex++) {
                transform.GetChild(currentWeaponIndex).gameObject.SetActive(false);
            }

Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 102 [3.24775]
B:BD[3.27086] → [2.1660:1698]
∅:D[2.1698] → [5.139169:139248]
B:BD[6.63704] → [5.139169:139248]
```
        protected void OnDestroy() {
            eventAggregator.OnUnitSelected -= EventAggregator_OnUnitSelected;
```
Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 103 [3.24775]
B:BD[3.27204] → [5.139249:139346]
∅:D[5.139346] → [4.3911:3947]
B:BD[6.63887] → [4.3911:3947]
∅:D[4.3947] → [6.63952:63963]
B:BD[6.63952] → [6.63952:63963]
```
            eventAggregator.OnPartyMemberSelected -= PartyMemberPortrait_OnPartyMemberSelected;
            SelectedWeaver = null;
        }
```

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 18 [7.2445]

[4.4160]

                    // print($"unregister from {_selectedWeaver}");

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 25 [7.2445]
[4.4459]
[4.4459]
```
                    // print($"register to {_selectedWeaver}");
```

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 36 [7.2445]

[5.139587]

[7.2778]

            eventAggregator.OnPartyMemberSelected += EventAggregator_OnPartyMemberSelected;
        }

Replacement in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 39 [7.2445]

B:BD[7.2780] → [5.139588:139681]

            eventAggregator.OnPartyMemberSelected += EventAggregator_OnPartyMemberSelected;

[7.2780]

[8.44815]

        protected void OnDestroy() {
            SelectedWeaver = null;
            eventAggregator.OnUnitSelected -= EventAggregator_OnUnitSelected;
            eventAggregator.OnPartyMemberSelected -= EventAggregator_OnPartyMemberSelected;
            Clear();

Replacement in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 47 [7.2445]
B:BD[8.44912] → [4.4694:4716]
```
            Clear();
```
[8.44912]
[4.4716]
```
            // print($"RuneWeaveView Weaver_OnWeaponEquipped {e.Weaver}");
```

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 52 [7.2445]

[6.65818]

[4.4799]

            // print("RuneWeaveView EventAggregator_OnRuneWeavingBankChanged");

Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 55 [7.2445]
∅:D[9.1364] → [6.65871:65897]
∅:D[4.4852] → [6.65871:65897]
B:BD[6.65871] → [6.65871:65897]
```
                Clear();
```
Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 59 [7.2445]
[5.139777]
[9.1573]
```
            // print("RuneWeaveView EventAggregator_OnUnitSelected");
```
Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 62 [7.2445]
[9.1736]
[4.4940]
```
                // print($"Changing weaver to {weaver}");
```
Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 64 [7.2445]
∅:D[4.4982] → [9.1736:1762]
B:BD[9.1736] → [9.1736:1762]
```
                Clear();
```

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 69 [7.2445]

[5.139896]

[9.1963]

            // print("RuneWeaveView EventAggregator_OnPartyMemberSelected");

Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 73 [7.2445]
∅:D[4.5112] → [9.2059:2085]
B:BD[9.2059] → [9.2059:2085]
```
                Clear();
```

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 78 [7.2445]

[4.5281]

            var currentWeaveIndex = 0;
            var originalChildCount = transform.childCount - 1; // excluding template

Replacement in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 81 [7.2445]

∅:D[4.5390] → [6.66106:66232]

∅:D[10.28243020] → [6.66106:66232]

B:BD[6.66106] → [6.66106:66232]

                var runeWeaveSelectUI = Instantiate(weaveSelectButtonTemplate, transform).GetComponent<RuneWeaveSelectUI>();

[4.5390]

[6.66232]

                RuneWeaveSelectUI runeWeaveSelectUI;
                if (currentWeaveIndex < originalChildCount) {
                    runeWeaveSelectUI = transform.GetChild(currentWeaveIndex + 1).GetComponent<RuneWeaveSelectUI>();
                }
                else {
                    runeWeaveSelectUI = Instantiate(weaveSelectButtonTemplate, transform).GetComponent<RuneWeaveSelectUI>();
                }

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 89 [7.2445]

[6.66288]

                runeWeaveSelectUI.gameObject.SetActive(true);
                currentWeaveIndex++;
            }
            for (; currentWeaveIndex < transform.childCount - 1; currentWeaveIndex++) {
                transform.GetChild(currentWeaveIndex + 1).gameObject.SetActive(false);

Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 106 [7.2445]

B:BD[6.66580] → [2.1777:1815]

∅:D[2.1815] → [6.66608:66707]

B:BD[6.66608] → [6.66608:66707]

B:BD[6.66707] → [4.5391:5427]

B:BD[4.5427] → [5.139897:139976]

        protected void OnDestroy() {
            eventAggregator.OnRuneWeavingBankChanged -= EventAggregator_OnRuneWeavingBankChanged;
            SelectedWeaver = null;
            eventAggregator.OnUnitSelected -= EventAggregator_OnUnitSelected;

Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 107 [7.2445]
B:BD[9.2408] → [5.139977:140070]
∅:D[9.2509] → [6.66707:66718]
∅:D[5.140070] → [6.66707:66718]
B:BD[6.66707] → [6.66707:66718]
```
            eventAggregator.OnPartyMemberSelected -= EventAggregator_OnPartyMemberSelected;
        }
```

Replacement in Assets/Scenes/SampleScene.unity at line 881 [11.780110080]

B:BD[11.780121071] → [2.5097:5178]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

[11.780121071]

[12.33888019]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

Replacement in Assets/Scenes/SampleScene.unity at line 3555 [11.780110080]

B:BD[11.780162310] → [2.5179:5260]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

[11.780162310]

[12.33918016]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

events popping several times bug

Dependencies

In channels

Change contents

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 2 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 18 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 24 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 34 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 44 [3.24775]

Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 50 [3.24775]

Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 57 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 64 [3.24775]

Replacement in Assets/Scripts/UI/HUD/WeaponView.cs at line 67 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 75 [3.24775]

Insertion in Assets/Scripts/UI/HUD/WeaponView.cs at line 78 [3.24775]

Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 102 [3.24775]

Deletion in Assets/Scripts/UI/HUD/WeaponView.cs at line 103 [3.24775]

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 18 [7.2445]

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 25 [7.2445]

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 36 [7.2445]

Replacement in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 39 [7.2445]

Replacement in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 47 [7.2445]

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 52 [7.2445]

Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 55 [7.2445]

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 59 [7.2445]

Insertion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 62 [7.2445]

Deletion in Assets/Scripts/UI/HUD/RuneWeaveView.cs at line 64 [7.2445]